mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Cryolitia PukNgae <cryolitia@uniontech.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Alex Lanzano" <lanzano.alex@gmail.com>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Yao Zi" <ziyao@disroot.org>, WangYuli <wangyuli@deepin.org>,
	"Jun Zhan" <zhanjun@uniontech.com>,
	niecheng1@uniontech.com2
Subject: Re: [PATCH v3] iio: imu: bmi270: Match PNP ID found on newer GPD firmware
Date: Thu, 21 Aug 2025 15:56:52 +0800	[thread overview]
Message-ID: <C559DC784053B698+aaafc990-e62a-4b71-86ba-a1ea4ce1c069@uniontech.com> (raw)
In-Reply-To: <CAHp75VeTgWifRnqYxi8P_yfMv_GMvJJi4+xJNB98gtKp0z93=A@mail.gmail.com>


On 21/08/2025 15.36, Andy Shevchenko wrote:
> On Thu, Aug 21, 2025 at 9:17 AM Cryolitia PukNgae via B4 Relay
> <devnull+cryolitia.uniontech.com@kernel.org> wrote:
>> From: Cryolitia PukNgae <cryolitia@uniontech.com>
>>
>> GPD devices originally used BMI160 sensors with the "BMI0160" PNP ID.
>> When they switched to BMI260 sensors in newer hardware, they reused
>> the existing Windows driver which accepts both "BMI0160" and "BMI0260"
>> IDs. Consequently, they kept "BMI0160" in DSDT tables for new BMI260
>> devices, causing driver mismatches in Linux.
>>
>> 1. GPD updated BIOS v0.40+[1] for newer devices to report "BMI0260" for
>> BMI260 sensors to avoid loading bmi160 driver on Linux. While this
> the bmi160 driver
>
>> isn't Bosch's VID;
>> 2. Bosch's official Windows driver uses "BMI0260" as a compatible ID
>> 3. We're seeing real devices shipping with "BMI0260" in DSDT
>>
>> The DSDT excerpt of GPD G1619-04 with BIOS v0.40:
>>
>> Scope (_SB.I2CC)
>> {
>>      Device (BMA2)
>>      {
>>          Name (_ADR, Zero)  // _ADR: Address
>>          Name (_HID, "BMI0260")  // _HID: Hardware ID
>>          Name (_CID, "BMI0260")  // _CID: Compatible ID
>>          Name (_DDN, "Accelerometer")  // _DDN: DOS Device Name
>>          Name (_UID, One)  // _UID: Unique ID
>>          Method (_CRS, 0, NotSerialized)  // _CRS: Current Resource Settings
>>          {
>>              Name (RBUF, ResourceTemplate ()
>>              {
>>                  I2cSerialBusV2 (0x0069, ControllerInitiated, 0x00061A80,
>>                      AddressingMode7Bit, "\\_SB.I2CC",
>>                      0x00, ResourceConsumer, , Exclusive,
>>                      )
>>              })
>>              Return (RBUF) /* \_SB_.I2CC.BMA2._CRS.RBUF */
>>          }
>>          # omit some noise
>>      }
>> }
>>
>> Link: http://download.softwincn.com/WIN%20Max%202024/Max2-7840-BIOS-V0.41.zip #1
> This blank line is not supposed to be here (the tag block is
> considered as the last lines in the commit message without blank
> lines, like a text paragraph).
>
>> Signed-off-by: Cryolitia PukNgae <cryolitia@uniontech.com>
> ...
>
> No need to resend for these nit-picks, I hope Jonathan will tweak them
> whilst applying.
> Reviewed-by: Andy Shevchenko <andy@kernel.org>
>
Oops, I edited it without seeing this line before sending it out. I hope 
it won't cause too much bother. thx for your review.


      reply	other threads:[~2025-08-21  7:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-21  6:17 Cryolitia PukNgae via B4 Relay
2025-08-21  7:36 ` Andy Shevchenko
2025-08-21  7:56   ` Cryolitia PukNgae [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C559DC784053B698+aaafc990-e62a-4b71-86ba-a1ea4ce1c069@uniontech.com \
    --to=cryolitia@uniontech.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=lanzano.alex@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=niecheng1@uniontech.com2 \
    --cc=nuno.sa@analog.com \
    --cc=wangyuli@deepin.org \
    --cc=zhanjun@uniontech.com \
    --cc=ziyao@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®