From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B83D1E633C for ; Sat, 11 Apr 2026 11:41:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775907690; cv=none; b=cIQ/oHoViLn2dG/oRJ8lpIm8Rss3AmPMW0rpmX9EE5sG4tkbASedguu7nNZZHqETxQ4QJp+BOSxlncXq5cr+hZvhWYhryVgsjTFVCLYxSDpU7YnvYyBCY3nxTPf/L98Ry4yIVU37LKDIepJ8C7Lfdmc7wp+NQ/R3UESyWNSuzT4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775907690; c=relaxed/simple; bh=IPzksGCaeU8esTm/mi3KW34X7blXPfSuUJ2zW8oL9sM=; h=Date:From:To:CC:Subject:In-Reply-To:References:Message-ID: MIME-Version:Content-Type; b=jX+eynjNE3Yzz+yVXi30gzz6fcKUe1NdQcxIlwqDBS4/p/CoviFX0i2aPZSk3o3zhyHBwRI693z6sH3gaPWZLdIp+mCbXd+oPN34f4Vb3LXvA75cOXuw95nuNWNEa8fAOk7oBHWKuOvWOjMaz+60+I0A3PMZLd7ujYYd/+wu+Ss= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EGtEW5Ot; arc=none smtp.client-ip=209.85.216.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EGtEW5Ot" Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-35e5770d013so22659a91.0 for ; Sat, 11 Apr 2026 04:41:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1775907689; x=1776512489; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to; bh=Ymxe3oBr0g81Y9358jhnJsOB6rs9CQpqhpch175KhCo=; b=EGtEW5OtCIBOoGSTFL2SDzJbN3vZykrlTmKBwBtE4wpv4vTto195EPhbyN5fGBGnoQ gTJPhewPf62V9HRrZBxo05mstgPzFCEkRua0cB9ZyDZ3KuhW/nklgimZ3z0lnOBtbNJG ckwBTSVMwQXTi1aKnS0AnYZcmYWgQb/m3qL/Xj/lEE6wlwLNK6xNGVRxKkSnvq2spC4a i5aDnQGxOlsi6JkRemY14piTnhFZyTziEVFs9wWfmBVzftjVUMPgcgGgTDW1aEsJbmt1 0yRpiH/cAYb1PSHjbs2/UYAQs5eaRLS89JyrlTrqmh5O1suFqgObJGozAZK8NejG/3S7 OJVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775907689; x=1776512489; h=content-transfer-encoding:mime-version:message-id:references :in-reply-to:user-agent:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ymxe3oBr0g81Y9358jhnJsOB6rs9CQpqhpch175KhCo=; b=JBSAGwHMAev4z/YzOtkMA3+ae6s+Z7h+9Ew/lIz25nDeUB/Da4OSwFjJBB3hu0ZwEL Xb+53v+67EgLPAzOJ+GnqjbAkpqzZcmgazWLzMGJij6Kg6EFb4s2AT/0rfyG2rxLgLBV 04bDqkE81Ru4L5b+Q8+5zDU5hvxaegCR/4q2fEsDBa+ziITYvRE+hqjL0bY+Fl8Ta9tE e9uO36mEpCRja2JVsnihEihVbMfac0bD3/OGkag/aDd0Rt9e9TbZCfPiVJP2/wyTygq3 WL+RLtdJFEeKSw/hYjmfgWAkLmX2ZpqFOzZSWBpSxkKCY+1x3mdc86weN82mVXawT8x6 44Mg== X-Forwarded-Encrypted: i=1; AJvYcCXOlG5KHTm4hmMxh7Kmy/xwEuQwqToJwwNFppISSw7uHha8KJDX9W5qGdjuBM/eYbDl0ltTqzy7HLoDPW8=@vger.kernel.org X-Gm-Message-State: AOJu0YwpysivYPQKRTBbbq2JKOZRS/R32FUYxf5747ydDlyBua8Jz4yb gz3WD+lXCghnUaIMO5Ax9HaGBg2M35EmPK84XGe6/XMTdfq28asb2b+D X-Gm-Gg: AeBDietgkaiTE4ea5LQUr/nLGYpJ4Et21z2nyJs27ODY4pJ3531OqfuIgUpQKpmwQ0I x43jtG7kFk9gk68KSEvI5j6Sy3mlrPJP/MzkhzGGARBa1uuUSRn+h3UUyVQedpwhhSG985UzhOv WKW+X3nIOpR5ZUqV3QVuO6ITod7rOqubvK3c6hq2PTrx88VyiDMUblGWtl87ObhLl8VgXisBr58 00vKZvS5LVRexOczlP1K/yseZCqpDn+kPMVPkkl0NK0Fz7wjR4l7zMV5ZC463X1pgcjWK1RJ6ZD HxAfXff1ZMwSIAVzY9eDf9XUyxZSov9Wrb/YuIttaSQ/4WIRXei8MKnhN15/KHxyrXiV2wEJAe/ kdMkiCdBFfjAn0Q4oWymrdbLgnW/bgD+BoZeyE2RBS5D2P7refUHP+TPMdM6RFLRLrdTzF2WKBO KdhG7UULx1WPQOdCyGwlY7Qv1yp1Tnsc315dhaxKA= X-Received: by 2002:a17:90b:4b0e:b0:35d:9b54:c6ff with SMTP id 98e67ed59e1d1-35e4282922fmr7013437a91.15.1775907688821; Sat, 11 Apr 2026 04:41:28 -0700 (PDT) Received: from ehlo.thunderbird.net ([2401:4900:1955:aff9:1:0:8c78:2328]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c79216ffa87sm4532424a12.5.2026.04.11.04.41.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Apr 2026 04:41:28 -0700 (PDT) Date: Sat, 11 Apr 2026 17:11:23 +0530 From: Sanjay Chitroda To: Andy Shevchenko CC: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, kees@kernel.org, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v5_4/5=5D_iio=3A_ssp=5Fsensors=3A_us?= =?US-ASCII?Q?e_devm_APIs_for_mutex_and_IRQ_resources?= User-Agent: Thunderbird for Android In-Reply-To: References: <20260406080852.2727453-1-sanjayembedded@gmail.com> <20260406080852.2727453-5-sanjayembedded@gmail.com> Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 7 April 2026 6:12:57=E2=80=AFpm IST, Andy Shevchenko wrote: >On Mon, Apr 06, 2026 at 01:38:51PM +0530, Sanjay Chitroda wrote: > >> Convert mutex initialization and IRQ registration to use devm-managed >> helpers, tying their lifetime to the device=2E >>=20 >> This removes the need for explicit cleanup in the error and remove >> paths, as the resources are automatically released on probe failure >> or device unbind=2E > >=2E=2E=2E > >> - mutex_init(&data->comm_lock); >> + ret =3D devm_mutex_init(&spi->dev, &data->comm_lock); >> + if (ret < 0) { >> + dev_err(&spi->dev, "Failed to init comm_lock mutex\n"); > >The message is not needed here=2E > >> + goto err_setup_spi; > >This is half-baked solution=2E When devm is in use there is shouldn't be = goto=2E >after it=2E > >> + } > Hi Andy, Thank you for your input=2E I will replace pending goto and drop newly added redundant error message a= nd send next series with change=2E >=2E=2E=2E > >> - ret =3D request_threaded_irq(data->spi->irq, NULL, >> - ssp_irq_thread_fn, >> - IRQF_TRIGGER_FALLING | IRQF_ONESHOT, >> - "SSP_Int", data); >> + ret =3D devm_request_threaded_irq(&spi->dev, data->spi->irq, NULL, >> + ssp_irq_thread_fn, >> + IRQF_TRIGGER_FALLING | IRQF_ONESHOT, >> + "SSP_Int", data); >> if (ret < 0) { > >> dev_err(&spi->dev, "Irq request fail\n"); > >Now you should also remove this dup message=2E devm APIs in IRQ core prin= t >a message for you=2E > >> - goto err_setup_irq; >> + goto err_setup_spi; >> } >