From: "Wilck, Martin" <martin.wilck@ts.fujitsu.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tpmdd-devel@lists.sourceforge.net"
<tpmdd-devel@lists.sourceforge.net>
Subject: Re: [PATCH] base/platform: fix panic when probe function is NULL
Date: Tue, 1 Dec 2015 11:41:53 +0100 [thread overview]
Message-ID: <C5A28EF7B98F574C85C70238C8E9ECC04E682BF148@ABGEX74E.FSC.NET> (raw)
In-Reply-To: <20151127101125.GS19888@pengutronix.de>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1838 bytes --]
Hello Uwe,
> This sounds like a separate issue though. Looking at init_tis there is:
>
> rc = platform_driver_register(&tis_drv);
> if (rc < 0)
> return rc;
> pdev = platform_device_register_simple("tpm_tis", -1, NULL, 0);
> if (IS_ERR(pdev)) {
> rc = PTR_ERR(pdev);
> goto err_dev;
> }
> rc = tpm_tis_init(&pdev->dev, &tis_default_info, NULL);
>
> tpm_tis_init calls tpmm_chip_alloc which barfs when pdev (i.e. the return value
> of platform_device_register_simple above) isn't bound. It is not allowed
> to assume that the device is bound after the above function calls.
Can you please explain again why you think that assumption is invalid?
As far as I understand the code, the assumption would be correct in
4.3.0 and earlier:
platform_driver_register() registers a platform driver with name
"tpm_tis". platform_device_register_simple() registers a device with the
same name. This will call platform_device_add()/device_add() and start
probing for a platform device. Platform bus probing in platform_match()
falls back to a simple match between driver and device name if all else
fails. That match succeeds for the "tpm_tis" driver. Thus
driver_probe_device() will be called, and in the absence of a
driver-specific probe routine, will succeed. Thus after
platform_device_register_simple() returns, device and driver will be
bound. This matches also actual behavior of the pre-4.4 code.
Please explain what I am overlooking. I am just trying to understand.
As far as tpm_tis is concerned, Jason's current patch set is going to
fix this for good anyway.
Regards
Martin
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next prev parent reply other threads:[~2015-12-01 10:41 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-26 19:01 martin.wilck
2015-11-26 20:30 ` [tpmdd-devel] " Jason Gunthorpe
2015-11-27 7:32 ` Wilck, Martin
2015-11-28 16:40 ` Jarkko Sakkinen
2015-11-28 16:49 ` Jarkko Sakkinen
2015-11-28 22:52 ` Jason Gunthorpe
2015-11-30 12:50 ` Jarkko Sakkinen
2015-11-27 10:11 ` Uwe Kleine-König
2015-11-30 7:42 ` Wilck, Martin
2015-11-30 11:50 ` [PATCH v2] base/platform: return success " martin.wilck
2015-12-01 20:30 ` Uwe Kleine-König
2015-12-01 10:41 ` Wilck, Martin [this message]
2015-12-01 13:24 ` [PATCH] base/platform: fix panic " Uwe Kleine-König
2015-12-01 15:19 ` Wilck, Martin
2015-12-01 17:25 ` [tpmdd-devel] " Jason Gunthorpe
2015-12-01 18:26 ` Peter Huewe
2015-12-01 18:40 ` Jason Gunthorpe
2015-12-01 18:54 ` Aw: " Peter Huewe
2015-12-01 19:03 ` Jason Gunthorpe
2015-11-28 16:34 ` Jarkko Sakkinen
2015-11-29 9:54 ` Uwe Kleine-König
2015-11-30 12:56 ` Jarkko Sakkinen
2015-11-30 13:06 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C5A28EF7B98F574C85C70238C8E9ECC04E682BF148@ABGEX74E.FSC.NET \
--to=martin.wilck@ts.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®