From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753191AbbIJHvO (ORCPT ); Thu, 10 Sep 2015 03:51:14 -0400 Received: from mga09.intel.com ([134.134.136.24]:2236 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751227AbbIJHvM (ORCPT ); Thu, 10 Sep 2015 03:51:12 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,503,1437462000"; d="scan'208";a="786443209" From: "Zha, Qipeng" To: Lee Jones CC: "linux-kernel@vger.kernel.org" , "broonie@kernel.org" Subject: RE: [PATCH v5 1/2] mfd: update Intel soc PMIC header file to support Broxton WC PMIC Thread-Topic: [PATCH v5 1/2] mfd: update Intel soc PMIC header file to support Broxton WC PMIC Thread-Index: AQHQ3xKVZbh9yU32E0aE1cdvAs1NCZ41d7qw Date: Thu, 10 Sep 2015 07:51:04 +0000 Message-ID: References: <1440519457-127907-1-git-send-email-qipeng.zha@intel.com> <20150825084650.GM19409@x1> In-Reply-To: <20150825084650.GM19409@x1> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t8A7pTvW031597 >> >> +#define INIT_REGMAP_IRQ(_irq, _off, _mask) \ >> + [_irq] = { .reg_offset = (_off), .mask = (_mask) } >> + >No, that's not what I asked. >Either this macro is going to be useful to *everyone*, or it's probably not useful to *anyone*. If it's going to exist, it should exist in the core header file, not Intel's own. Jones, can we keep current change as for intel's own ? not sure if Mark agree to merge this macro to core regmap header file. Maybe some driver want to initialize regmap_irq structure with different/customed way. Thanks. {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I