From: Song Liu <songliubraving@fb.com>
To: allanzhang <allanzhang@google.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>, Martin Lau <kafai@fb.com>,
Yonghong Song <yhs@fb.com>,
"David S. Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 0/2] bpf: Allow bpf_skb_event_output for more prog types
Date: Tue, 25 Jun 2019 00:00:35 +0000 [thread overview]
Message-ID: <C74526B1-7426-4F84-A5D3-DA444A17CFCD@fb.com> (raw)
In-Reply-To: <20190624235720.167067-1-allanzhang@google.com>
> On Jun 24, 2019, at 4:57 PM, allanzhang <allanzhang@google.com> wrote:
>
> Software event output is only enabled by a few prog types right now (TC,
> LWT out, XDP, sockops). Many other skb based prog types need
> bpf_skb_event_output to produce software event.
>
> Added socket_filter, cg_skb, sk_skb prog types to generate sw event.
>
> *** BLURB HERE ***
^^^^^^ this should be removed.
Please include bpf-next in the subject prefix.
Please also include changes from v1 to v2 and v2 to v3 in the cover
letter, like:
changes v1 => v2:
1. ...
2. ...
Thanks,
Song
>
> allanzhang (2):
> bpf: Allow bpf_skb_event_output for a few prog types
> bpf: Add selftests for bpf_perf_event_output
>
> net/core/filter.c | 6 ++
> tools/testing/selftests/bpf/test_verifier.c | 33 ++++++-
> .../selftests/bpf/verifier/event_output.c | 94 +++++++++++++++++++
> 3 files changed, 132 insertions(+), 1 deletion(-)
> create mode 100644 tools/testing/selftests/bpf/verifier/event_output.c
>
> --
> 2.22.0.410.gd8fdbe21b5-goog
>
prev parent reply other threads:[~2019-06-25 0:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 23:57 allanzhang
2019-06-24 23:57 ` [PATCH v3 1/2] bpf: Allow bpf_skb_event_output for a few " allanzhang
2019-06-24 23:57 ` [PATCH v3 2/2] bpf: Add selftests for bpf_perf_event_output allanzhang
2019-06-25 12:40 ` Daniel Borkmann
2019-06-25 0:00 ` Song Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C74526B1-7426-4F84-A5D3-DA444A17CFCD@fb.com \
--to=songliubraving@fb.com \
--cc=allanzhang@google.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=kafai@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®