Re: [RFC v1] dt-bindings: interconnect: add mt7988-cci compatible

[Frank Wunderlich <linux@fw-web.de>]

Hi

Thank you for review.

Am 30. Mai 2025 17:57:20 MESZ schrieb Conor Dooley <conor@kernel.org>:
>On Wed, May 28, 2025 at 03:52:49PM +0200, Frank Wunderlich wrote:
>> From: Frank Wunderlich <frank-w@public-files.de>
>> 
>> Add compatible for Mediatek MT7988 SoC with mediatek,mt8183-cci fallback
>> which is taken by driver.
>
>What's RFC about the patch?

We have merge window,but maybe this rule is
net(-next) only. And i was unsure if enum for
new compatible is right or if i should use 2
const.

>> 
>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>> ---
>>  .../bindings/interconnect/mediatek,cci.yaml          | 12 +++++++++---
>>  1 file changed, 9 insertions(+), 3 deletions(-)
>> 
>> diff --git a/Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml b/Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml
>> index 58611ba2a0f4..2c6785c588e9 100644
>> --- a/Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml
>> +++ b/Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml
>> @@ -17,9 +17,15 @@ description: |
>>  
>>  properties:
>>    compatible:
>> -    enum:
>> -      - mediatek,mt8183-cci
>> -      - mediatek,mt8186-cci
>> +    oneOf:
>> +      - items:
>
>This "- items:" is redundant.

Ok,i try without it.

>> +          - enum:
>> +              - mediatek,mt8183-cci
>> +              - mediatek,mt8186-cci
>> +      - items:
>> +          - enum:
>> +              - mediatek,mt7988-cci
>> +          - const: mediatek,mt8183-cci
>>  
>>    clocks:
>>      items:
>> -- 
>> 2.43.0
>> 


regards Frank