From: "Nguyen, Tom L" <tom.l.nguyen@intel.com>
To: "Zwane Mwaikambo" <zwane@linuxpower.ca>
Cc: "Greg Kroah-Hartmann" <greg@kroah.com>,
"Jeff Garzik" <jgarzik@pobox.com>,
"Nakajima, Jun" <jun.nakajima@intel.com>,
"Linux Kernel" <linux-kernel@vger.kernel.org>
Subject: RE: Update MSI Patches
Date: Mon, 18 Aug 2003 14:24:25 -0700 [thread overview]
Message-ID: <C7AB9DA4D0B1F344BF2489FA165E502401541719@orsmsx404.jf.intel.com> (raw)
On Mon, 18 Aug 2003, Zwane Mwaikambo wrote:
>> I make minor modification to the last patch to reduce some duplicate functions,
>> as shown as below. I think this perhaps looks better. What do you think?
> The patch looks fine.
>> +#ifdef CONFIG_PCI_USE_VECTOR
>> +static unsigned int startup_edge_ioapic_vector(unsigned int vector)
>> +{
>> + int irq = vector_to_irq(vector);
>> +
>> + return (startup_edge_ioapic_irq(irq));
>> +}
> Tiny nit, Linux coding style is;
> return startup_edge_ioapic_irq(irq);
> But you can queue that change for later.
Good! Thank you for your comments. I will roll your comment on Linux coding style
for later release.
Thanks,
Long
next reply other threads:[~2003-08-18 21:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-18 21:24 Nguyen, Tom L [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-08-18 17:28 long
2003-08-18 20:20 ` Zwane Mwaikambo
2003-08-15 20:48 Nguyen, Tom L
2003-08-16 5:01 ` Zwane Mwaikambo
2003-08-16 11:04 ` Zwane Mwaikambo
2003-08-14 19:14 long
2003-08-15 18:37 ` Zwane Mwaikambo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C7AB9DA4D0B1F344BF2489FA165E502401541719@orsmsx404.jf.intel.com \
--to=tom.l.nguyen@intel.com \
--cc=greg@kroah.com \
--cc=jgarzik@pobox.com \
--cc=jun.nakajima@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®