mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Nguyen, Tom L" <tom.l.nguyen@intel.com>
To: "Greg KH" <greg@kroah.com>
Cc: <linux-kernel@vger.kernel.org>,
	"Saxena, Sunil" <sunil.saxena@intel.com>,
	"Mallick, Asit K" <asit.k.mallick@intel.com>,
	"Nakajima, Jun" <jun.nakajima@intel.com>,
	"Carbonari, Steven" <steven.carbonari@intel.com>,
	"Sy, Dely L" <dely.l.sy@intel.com>
Subject: RE: RFC Proposal to enable MSI support in Linux kernel
Date: Wed, 14 May 2003 11:51:59 -0700	[thread overview]
Message-ID: <C7AB9DA4D0B1F344BF2489FA165E50241361E9@orsmsx404.jf.intel.com> (raw)

Hi Greg,

I just learned that withdrawing email once it sent out never work. I posted it yesterday and wonder why it did not post. I then recalled and resend it; as a result, I learned a hard way. Please read the following responses to your questions:

Q: Hm, wierd indenting style, can you just follow Documentation/CodingStyle
and use tabs? 
A: Thank for your suggestion. We will look into the indenting style.

Q: Anyway, what code is supposed to use this function?  A PCI Hotplug
controller driver?  If so, do you have any patches to the current
drivers that show how it is used?
A: We have an engineer to work on PCI Hotplug controller, which calls the API remove_hotplug_vectors. Her name is Dely Sy. She is in the progress of posting her code.

Q: Also, why pass a void *?  That's usually forbidden in the kernel, and
since you are instantly casting it to a struct pci_dev *, why not just
use that? 
A: This is a very good suggestion. We will make change accordingly.

Thanks,
Tom

-----Original Message-----
From: Greg KH [mailto:greg@kroah.com]
Sent: Wednesday, May 14, 2003 10:45 AM
To: Nguyen, Tom L
Cc: linux-kernel@vger.kernel.org; Saxena, Sunil; Mallick, Asit K;
Nakajima, Jun; Carbonari, Steven
Subject: Re: RFC Proposal to enable MSI support in Linux kernel


Even though you are trying to withdraw this message (which is pointless
for something sent to a mailing list), I had a few small questions with
regards to PCI Hotplug devices:

> +/**
> + * msi_hp_free_vectors: reclaim all MSI previous assigned to this device
> + * argument: device pointer of type struct pci_dev 
> + *
> + * description: used during hotplug removed, from which device is
> hot-removed;

Oops, your patch wrapped, please try another email client, or change the
configuration options of your current one.

> + * PCI subsystem reclaims associated MSI to unused state, which may be used
> 
> + * later on.
> + **/ 
> +void remove_hotplug_vectors(void* dev_id)
> +{
> +     struct msi_desc_t *entry;
> +     struct pci_dev *dev = (struct pci_dev *)dev_id;
> +     int type;
> +     void *mask_entry_addr;
> +      unsigned int flags;

Hm, wierd indenting style, can you just follow Documentation/CodingStyle
and use tabs?

Anyway, what code is supposed to use this function?  A PCI Hotplug
controller driver?  If so, do you have any patches to the current
drivers that show how it is used?

Also, why pass a void *?  That's usually forbidden in the kernel, and
since you are instantly casting it to a struct pci_dev *, why not just
use that?

thanks,

greg k-h

             reply	other threads:[~2003-05-14 18:40 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-05-14 18:51 Nguyen, Tom L [this message]
  -- strict thread matches above, loose matches on Subject: below --
2003-05-30 14:56 Nicolas Mailhot
2003-05-31  2:29 ` William Lee Irwin III
2003-05-31  7:13 ` Zwane Mwaikambo
2003-05-31  7:28   ` Zwane Mwaikambo
2003-05-30  2:14 Nakajima, Jun
2003-05-29 18:12 Nguyen, Tom L
2003-05-29 21:55 ` Zwane Mwaikambo
2003-05-20 19:03 Nguyen, Tom L
2003-05-19 21:46 Nguyen, Tom L
2003-05-19 21:22 Nguyen, Tom L
2003-05-20 10:36 ` Martin Schlemmer
2003-05-20 18:49 ` Zwane Mwaikambo
2003-05-28 22:22   ` Zwane Mwaikambo
2003-05-28 23:01     ` Jeff Garzik
2003-05-28 23:06       ` Zwane Mwaikambo
2003-05-28 23:45         ` Jeff Garzik
2003-05-28 23:50           ` Zwane Mwaikambo
2003-05-14 20:43 Nakajima, Jun
2003-05-14 19:57 Nakajima, Jun
2003-05-14 19:54 ` Zwane Mwaikambo
2003-05-14 15:41 Nguyen, Tom L
2003-05-14 15:22 Nguyen, Tom L
2003-05-14 17:44 ` Greg KH
2003-05-14 18:58 ` Zwane Mwaikambo
2003-05-14 19:06 ` Zwane Mwaikambo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C7AB9DA4D0B1F344BF2489FA165E50241361E9@orsmsx404.jf.intel.com \
    --to=tom.l.nguyen@intel.com \
    --cc=asit.k.mallick@intel.com \
    --cc=dely.l.sy@intel.com \
    --cc=greg@kroah.com \
    --cc=jun.nakajima@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=steven.carbonari@intel.com \
    --cc=sunil.saxena@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®