From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757731Ab0CPUXP (ORCPT ); Tue, 16 Mar 2010 16:23:15 -0400 Received: from avexch1.qlogic.com ([198.70.193.115]:22357 "EHLO avexch1.qlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755426Ab0CPUXO convert rfc822-to-8bit (ORCPT ); Tue, 16 Mar 2010 16:23:14 -0400 From: Giridhar Malavali To: Jiri Slaby , "James.Bottomley@suse.de" CC: LinuxSCSI , "linux-kernel@vger.kernel.org" , "jirislaby@gmail.com" Date: Tue, 16 Mar 2010 13:23:09 -0700 Subject: Re: [Suspected SPAM] [PATCH 3/3] SCSI: qla2xxx, fix lock imbalance Thread-Topic: [Suspected SPAM] [PATCH 3/3] SCSI: qla2xxx, fix lock imbalance Thread-Index: AcrFHLtFXB+rcbCdSF6SNQ8hGSKfbwAKcL6D Message-ID: In-Reply-To: <1268753039-17214-3-git-send-email-jslaby@suse.cz> Accept-Language: en-US Content-Language: en X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 X-OriginalArrivalTime: 16 Mar 2010 20:23:11.0669 (UTC) FILETIME=[7FD77650:01CAC546] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/16/10 8:23 AM, "Jiri Slaby" wrote: > Stanse found that one error path in qla24xx_bsg_timeout omits to > unlock ha->hardware_lock. Fix that. > > Signed-off-by: Jiri Slaby > Cc: Giridhar Malavali > Cc: James Bottomley > --- > drivers/scsi/qla2xxx/qla_attr.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/scsi/qla2xxx/qla_attr.c b/drivers/scsi/qla2xxx/qla_attr.c > index 90d1e06..a3591e5 100644 > --- a/drivers/scsi/qla2xxx/qla_attr.c > +++ b/drivers/scsi/qla2xxx/qla_attr.c > @@ -2388,6 +2388,7 @@ qla24xx_bsg_timeout(struct fc_bsg_job *bsg_job) > return 0; > > done: > + spin_unlock_irqrestore(&ha->hardware_lock, flags); > if (bsg_job->request->msgcode == FC_BSG_HST_CT) > kfree(sp->fcport); > kfree(sp->ctx); > -- > 1.7.0.1 > > Acked-by: Giridhar Malavali