From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751645AbdIEHgq (ORCPT <rfc822;w@1wt.eu>);
        Tue, 5 Sep 2017 03:36:46 -0400
Received: from LGEAMRELO12.lge.com ([156.147.23.52]:36920 "EHLO
        lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751149AbdIEHgj (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 5 Sep 2017 03:36:39 -0400
X-Original-SENDERIP: 156.147.1.127
X-Original-MAILFROM: byungchul.park@lge.com
X-Original-SENDERIP: 165.244.98.150
X-Original-MAILFROM: byungchul.park@lge.com
From: =?ks_c_5601-1987?B?udq6tMO2L7yxwNO/rLG4v/gvU1cgUGxhdGZvcm0ov6wpQU9UxsAo?=
         =?ks_c_5601-1987?B?Ynl1bmdjaHVsLnBhcmtAbGdlLmNvbSk=?= 
        <byungchul.park@lge.com>
To: Peter Zijlstra <peterz@infradead.org>
CC: "tj@kernel.org" <tj@kernel.org>,
        "johannes.berg@intel.com" <johannes.berg@intel.com>,
        "mingo@kernel.org" <mingo@kernel.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "oleg@redhat.com" <oleg@redhat.com>,
        "david@fromorbit.com" <david@fromorbit.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kernel-team@lge.com" <kernel-team@lge.com>
Date: Tue, 5 Sep 2017 16:36:18 +0900
Subject: RE: [PATCH 3/3] lockdep: Remove unnecessary acquisitions wrt
 workqueue flush
Thread-Topic: [PATCH 3/3] lockdep: Remove unnecessary acquisitions wrt
 workqueue flush
Thread-Index: AdMmGDxDAnRuSJWbQa2z+4010p1hGwAAHikQ
Message-ID: <C80AB6F618D91B4E8F391CB202C12DFD1ED20A9B30@LGEVEXMBHQSVC1.LGE.NET>
References: <1504578554-4137-1-git-send-email-byungchul.park@lge.com>
 <1504578554-4137-4-git-send-email-byungchul.park@lge.com>
 <20170905072551.fvtxrhuo662jiwif@hirez.programming.kicks-ass.net>
In-Reply-To: <20170905072551.fvtxrhuo662jiwif@hirez.programming.kicks-ass.net>
Accept-Language: en-US
Content-Language: ko-KR
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
acceptlanguage: en-US
Content-Type: text/plain; charset="ks_c_5601-1987"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id v857ar4P013121

> -----Original Message-----
> From: Peter Zijlstra [mailto:peterz@infradead.org]
> Sent: Tuesday, September 05, 2017 4:26 PM
> To: Byungchul Park
> Cc: tj@kernel.org; johannes.berg@intel.com; mingo@kernel.org;
> tglx@linutronix.de; oleg@redhat.com; david@fromorbit.com; linux-
> kernel@vger.kernel.org; kernel-team@lge.com
> Subject: Re: [PATCH 3/3] lockdep: Remove unnecessary acquisitions wrt
> workqueue flush
> 
> On Tue, Sep 05, 2017 at 11:29:14AM +0900, Byungchul Park wrote:
> 
> > Also, lock_map_acquire() in process_one_work() is too strong for that
> > purpose. lock_map_acquire_might() is enough. Replaced it.
> 
> NAK!! traditional annotations are superior to cross-release. They are not
> timing dependent.

You seem to mis-understand this. This also make them timing independent.
I also agree that we need timing independent report in workqueue code.
That's actually why I propose this patch.

I just tried to do it in a right way.