From: Troy Mitchell <troy.mitchell@linux.spacemit.com>
To: Mark Brown <broonie@kernel.org>,
Troy Mitchell <troy.mitchell@linux.spacemit.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Yixun Lan <dlan@gentoo.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,
linux-kernel@vger.kernel.org,
Jinmei Wei <weijinmei@linux.spacemit.com>
Subject: Re: [PATCH v2 2/2] ASoC: spacemit: add i2s support for K1 SoC
Date: Tue, 2 Sep 2025 09:39:40 +0800 [thread overview]
Message-ID: <C855339EB347C5D6+aLZK3D678QUDB8hA@LT-Guozexi> (raw)
In-Reply-To: <aLAbk_0emidBCJBn@finisterre.sirena.org.uk>
On Thu, Aug 28, 2025 at 11:04:19AM +0200, Mark Brown wrote:
> On Thu, Aug 28, 2025 at 11:37:33AM +0800, Troy Mitchell wrote:
>
> > + switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
> > + case SND_SOC_DAIFMT_DSP_A:
> > + case SND_SOC_DAIFMT_DSP_B:
> > + cpu_dai->driver->playback.channels_min = 1;
> > + cpu_dai->driver->playback.channels_max = 1;
>
> > + if ((fmt & SND_SOC_DAIFMT_FORMAT_MASK) == SND_SOC_DAIFMT_DSP_A)
> > + sspsp_val |= SSPSP_FSRT;
>
> It's weird and confusing that this isn't part of the above switch case.
Thanks! I'll change it.
>
> > +static void spacemit_i2s_remove(struct platform_device *pdev)
> > +{
> > + /* resources auto-freed by devm_ */
> > +}
>
> If this can be empty remove it.
Yes, I will remove it in the next version.
Best regards,
Troy
prev parent reply other threads:[~2025-09-02 1:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-28 3:37 [PATCH v2 0/2] ASoC: spacemit: add i2s support to " Troy Mitchell
2025-08-28 3:37 ` [PATCH v2 1/2] ASoC: dt-bindings: Add bindings for SpacemiT K1 Troy Mitchell
2025-08-29 17:16 ` Rob Herring
2025-09-02 1:36 ` Troy Mitchell
2025-08-28 3:37 ` [PATCH v2 2/2] ASoC: spacemit: add i2s support for K1 SoC Troy Mitchell
2025-08-28 9:04 ` Mark Brown
2025-09-02 1:39 ` Troy Mitchell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C855339EB347C5D6+aLZK3D678QUDB8hA@LT-Guozexi \
--to=troy.mitchell@linux.spacemit.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-sound@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=spacemit@lists.linux.dev \
--cc=tiwai@suse.com \
--cc=weijinmei@linux.spacemit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®