From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932153AbdESTIk (ORCPT ); Fri, 19 May 2017 15:08:40 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36180 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751208AbdESTIi (ORCPT ); Fri, 19 May 2017 15:08:38 -0400 Date: Fri, 19 May 2017 12:08:34 -0700 User-Agent: K-9 Mail for Android In-Reply-To: <41de7f92-8d98-3266-5d28-28ba48c5da38@pa-w.de> References: <41de7f92-8d98-3266-5d28-28ba48c5da38@pa-w.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Subject: Re: [4.12 regression] Thinkpad X250 Touchpad and Trackpoint not recognized anymore; commit e839ffa: "Input: synaptics - add support for Intertouch devices" To: Pascal Wichmann , Benjamin Tissoires CC: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org From: Dmitry Torokhov Message-ID: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v4JJ8lab031259 On May 19, 2017 11:46:16 AM PDT, Pascal Wichmann wrote: >Hello, > >using the latest 4.12-rc1 kernel, the trackpoint and touchpad of my >Thinkpad X250 are not recognized. > >This is caused by commit >e839ffa Input: synaptics - add support for Intertouch devices > > >The specific problem seems to be the detection of whether to use >synaptics_intertouch for the psmouse module or not. That parameter >is set to -1 by default, in which case synaptics_intertouch is >enabled on my device. > >When I explicitly set that parameter to 0, the trackpoint and touchpad >are recognized and work as expected. > >Removing my device from smbus_pnp_ids in 4.12 rc1 fixes the issue >without need to manually disable synaptics_intertouch in the psmouse >module: > >diff -ruN a/drivers/input/mouse/synaptics.c >b/drivers/input/mouse/synaptics.c >--- a/drivers/input/mouse/synaptics.c 2017-05-19 19:31:48.930734395 >+0200 >+++ b/drivers/input/mouse/synaptics.c 2017-05-19 19:32:00.490782484 >+0200 >@@ -170,7 +170,6 @@ > static const char * const smbus_pnp_ids[] = { > /* all of the topbuttonpad_pnp_ids are valid, we just add some extras >*/ > "LEN0048", /* X1 Carbon 3 */ >- "LEN0046", /* X250 */ > "LEN004a", /* W541 */ > "LEN200f", /* T450s */ > NULL > > >Is the ThinkPad X250 not supporting intertouch or is there another >problem causing the input devices not to work with it enabled? > Do you have i801_smbus driver enabled and loaded? Thanks. -- Dmitry