mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Dave Goodell (dgoodell)" <dgoodell@cisco.com>
To: "Hefty, Sean" <sean.hefty@intel.com>
Cc: Tom Talpey <tom@talpey.com>, Doug Ledford <dledford@redhat.com>,
	"Weiny, Ira" <ira.weiny@intel.com>,
	Michael Wang <yun.wang@profitbricks.com>,
	"Liran Liss" <liranl@mellanox.com>,
	Roland Dreier <roland@kernel.org>,
	Hal Rosenstock <hal@dev.mellanox.co.il>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Steve Wise <swise@opengridcomputing.com>,
	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
	Tom Tucker <tom@opengridcomputing.com>,
	Hoang-Nam Nguyen <hnguyen@de.ibm.com>,
	"raisch@de.ibm.com" <raisch@de.ibm.com>,
	infinipath <infinipath@intel.com>, Eli Cohen <eli@mellanox.com>,
	"Latif, Faisal" <faisal.latif@intel.com>,
	"Jack Morgenstein" <jackm@dev.mellanox.co.il>,
	Or Gerlitz <ogerlitz@mellanox.com>,
	Haggai Eran <haggaie@mellanox.com>
Subject: Re: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()
Date: Tue, 28 Apr 2015 19:50:48 +0000	[thread overview]
Message-ID: <C8AE8850-C411-4805-95C2-6884669D92CF@cisco.com> (raw)
In-Reply-To: <1828884A29C6694DAF28B7E6B8A82373A8FC819C@ORSMSX109.amr.corp.intel.com>

On Apr 28, 2015, at 1:14 AM, Hefty, Sean <sean.hefty@intel.com> wrote:

>>> Keep in mind that this enum was Liran's response to Michael's original
>>> patch.  In the enum in Michael's patch, there was both USNIC and
>>> USNIC_UDP.
>> 
>> Right! That's why I'm confused. Seems wrong to drop it, right?
> 
> I think the original USNIC protocol is layered directly over Ethernet.  The protocol basically stole an Ethertype (the one used for IBoE/RoCE) and implemented a proprietary protocol instead.  I have no idea how you resolve that, but I also don't think it's used anymore.  USNIC_UDP is just UDP.

Sean is correct. The legacy RDMA_TRANSPORT_USNIC code used a proprietary protocol over plain Ethernet frames.  The newer RDMA_TRANSPORT_USNIC_UDP code is just standard UDP/IP/Ethernet packets exposed to user space via the uverbs stack.  The current kernel module will support both formats, it just depends on which user space requests at create_qp time.  From the kernel point of view there is no common protocol between the two TRANSPORTs (other than sharing partially similar Ethernet frames at L2).

I posted last week to clarify some of this: http://marc.info/?l=linux-rdma&m=142972177830718&w=2

>> Well, if RoCEv2 uses the same protocol enum, that may introduce new
>> confusion, for example there will be some new CM handling for UDP encap,
>> source port selection, and of course vlan/tag assignment, etc. But if
>> there is support under way, and everyone is clear, then, ok.
> 
> RoCEv2/IBoUDP shares the same port space as UDP.  It has a similar issues as iWarp does sharing state with the main network stack.  I'm not aware of any proposal for resolving that.  Does it require using a separate IP address?  Does it use a port mapper function?  Does netdev care for UDP?  I'm not sure what USNIC does for this either, but a common solution between USNIC and IBoUDP seems reasonable.

Is the concern here about CM issues or the UDP ports used by the actual usNIC RQs?  CM is not used/supported for usNIC at this time.

-Dave


  reply	other threads:[~2015-04-28 19:50 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-24 12:23 [PATCH v6 00/26] IB/Verbs: IB Management Helpers Michael Wang
2015-04-24 12:23 ` [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport() Michael Wang
2015-04-24 14:29   ` Tom Talpey
2015-04-24 14:35     ` Michael Wang
2015-04-24 14:46       ` Tom Talpey
2015-04-24 16:00         ` Doug Ledford
2015-04-24 15:12   ` Liran Liss
2015-04-27  7:39     ` Michael Wang
2015-04-27 21:52       ` ira.weiny
2015-04-28  0:16         ` Tom Talpey
2015-04-28  0:36           ` Doug Ledford
2015-04-28  0:53             ` Tom Talpey
2015-04-28  1:24               ` Doug Ledford
2015-04-28  1:49                 ` Tom Talpey
2015-04-28  6:14                   ` Hefty, Sean
2015-04-28 19:50                     ` Dave Goodell (dgoodell) [this message]
2015-04-28 19:53                       ` Hefty, Sean
2015-04-28 20:17                         ` Dave Goodell (dgoodell)
2015-04-28 14:29                 ` Michael Wang
2015-04-28 18:56                 ` Jason Gunthorpe
2015-04-28 19:11                   ` Or Gerlitz
2015-04-28 20:02                     ` Doug Ledford
2015-04-28 20:03                   ` Doug Ledford
2015-04-24 12:23 ` [PATCH v6 02/26] IB/Verbs: Implement raw management helpers Michael Wang
2015-04-24 15:15   ` Liran Liss
2015-04-24 16:29     ` Jason Gunthorpe
2015-04-27  7:41       ` Michael Wang
2015-04-24 12:23 ` [PATCH v6 03/26] IB/Verbs: Reform IB-core mad/agent/user_mad Michael Wang
2015-04-24 12:23 ` [PATCH v6 04/26] IB/Verbs: Reform IB-core cm Michael Wang
2015-04-24 12:23 ` [PATCH v6 05/26] IB/Verbs: Reform IB-core sa_query Michael Wang
2015-04-24 12:23 ` [PATCH v6 06/26] IB/Verbs: Reform IB-core multicast Michael Wang
2015-04-24 12:23 ` [PATCH v6 07/26] IB/Verbs: Reform IB-ulp ipoib Michael Wang
2015-04-24 12:23 ` [PATCH v6 08/26] IB/Verbs: Reform IB-ulp xprtrdma Michael Wang
2015-04-24 12:23 ` [PATCH v6 09/26] IB/Verbs: Reform IB-core verbs Michael Wang
2015-04-24 12:23 ` [PATCH v6 10/26] IB/Verbs: Reform cm related part in IB-core cma/ucm Michael Wang
2015-04-24 12:23 ` [PATCH v6 11/26] IB/Verbs: Reform route related part in IB-core cma Michael Wang
2015-04-24 12:23 ` [PATCH v6 12/26] IB/Verbs: Reform mcast " Michael Wang
2015-04-24 12:23 ` [PATCH v6 13/26] IB/Verbs: Reserve legacy transport type in 'dev_addr' Michael Wang
2015-04-24 12:23 ` [PATCH v6 14/26] IB/Verbs: Reform cma_acquire_dev() Michael Wang
2015-04-24 12:23 ` [PATCH v6 15/26] IB/Verbs: Reform rest part in IB-core cma Michael Wang
2015-04-24 12:23 ` [PATCH v6 16/26] IB/Verbs: Use management helper cap_ib_mad() Michael Wang
2015-04-24 12:23 ` [PATCH v6 17/26] IB/Verbs: Use management helper cap_ib_smi() Michael Wang
2015-04-24 12:23 ` [PATCH v6 18/26] IB/Verbs: Use management helper cap_ib_cm() Michael Wang
2015-04-24 12:23 ` [PATCH v6 19/26] IB/Verbs: Use management helper cap_iw_cm() Michael Wang
2015-04-24 12:23 ` [PATCH v6 20/26] IB/Verbs: Use management helper cap_ib_sa() Michael Wang
2015-04-24 12:23 ` [PATCH v6 21/26] IB/Verbs: Use management helper cap_ib_mcast() Michael Wang
2015-04-24 12:23 ` [PATCH v6 22/26] IB/Verbs: Use management helper cap_read_multi_sge() Michael Wang
2015-04-24 12:23 ` [PATCH v6 23/26] IB/Verbs: Use management helper cap_af_ib() Michael Wang
2015-04-24 12:23 ` [PATCH v6 24/26] IB/Verbs: Use management helper cap_eth_ah() Michael Wang
2015-04-24 12:23 ` [PATCH v6 25/26] IB/Verbs: Clean up rdma_ib_or_iboe() Michael Wang
2015-04-24 12:23 ` [PATCH v6 26/26] IB/Verbs: Cleanup rdma_node_get_transport() Michael Wang
2015-04-24 13:13 ` [PATCH v6 00/26] IB/Verbs: IB Management Helpers Michael Wang
2015-04-27  7:19   ` Devesh Sharma
2015-04-27  7:44     ` Michael Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=C8AE8850-C411-4805-95C2-6884669D92CF@cisco.com \
    --to=dgoodell@cisco.com \
    --cc=dledford@redhat.com \
    --cc=eli@mellanox.com \
    --cc=faisal.latif@intel.com \
    --cc=haggaie@mellanox.com \
    --cc=hal@dev.mellanox.co.il \
    --cc=hnguyen@de.ibm.com \
    --cc=infinipath@intel.com \
    --cc=ira.weiny@intel.com \
    --cc=jackm@dev.mellanox.co.il \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=liranl@mellanox.com \
    --cc=ogerlitz@mellanox.com \
    --cc=raisch@de.ibm.com \
    --cc=roland@kernel.org \
    --cc=sean.hefty@intel.com \
    --cc=swise@opengridcomputing.com \
    --cc=tom@opengridcomputing.com \
    --cc=tom@talpey.com \
    --cc=yun.wang@profitbricks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®