From: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
To: <alan@lxorguk.ukuu.org.uk>
Cc: <linux-kernel@vger.kernel.org>,
"Bruno Cornec" <Bruno.Cornec@hp.com>,
"Nakajima, Jun" <jun.nakajima@intel.com>
Subject: [PATCH 2.4-ac] Proper APIC version identification
Date: Wed, 2 Jul 2003 16:57:34 -0700 [thread overview]
Message-ID: <C8C38546F90ABF408A5961FC01FDBF1902C7D0AC@fmsmsx405.fm.intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1409 bytes --]
Hi,
The boot issue with DL760 G2 issue with Hyper-Threading (16-way
logical) was root-caused to be coming from hardcoding of apic-version
during the acpi boot-up code. The attached patch fixes the issue, by
reading in the actual apic version. This apic-version is used later in
the boot process, to identify whether the processor supports xAPIC or
not. And that in turn was resulting in boot failure.
Please include in the ac-patchset.
Refer following lkml threads for detailed the problem description:
Subject: SUMMARY: DL760 G2 issue with Hyper-Threading:
Subject: PROBLEM: DL760 G2 issue on 2.4.21 with Hyper-Threading
Thanks,
-Venkatesh
--- linux-2.4.21-ac2/arch/i386/kernel/mpparse.c.org 2003-06-30
12:52:21.000000000 -0700
+++ linux-2.4.21-ac2/arch/i386/kernel/mpparse.c 2003-07-01
16:07:40.000000000 -0700
@@ -999,7 +999,14 @@
processor.mpc_type = MP_PROCESSOR;
processor.mpc_apicid = id;
- processor.mpc_apicver = 0x10; /* TBD: lapic version */
+
+ /*
+ * mp_register_lapic_address() which is called before the
+ * current function does the fixmap of FIX_APIC_BASE.
+ * Read in the correct APIC version from there
+ */
+ processor.mpc_apicver = apic_read(APIC_LVR);
+
processor.mpc_cpuflag = (enabled ? CPU_ENABLED : 0);
processor.mpc_cpuflag |= (boot_cpu ? CPU_BOOTPROCESSOR : 0);
processor.mpc_cpufeature = (boot_cpu_data.x86 << 8) |
[-- Attachment #2: acpi_apicversion.patch --]
[-- Type: application/octet-stream, Size: 721 bytes --]
--- linux-2.4.21-ac2/arch/i386/kernel/mpparse.c.org 2003-06-30 12:52:21.000000000 -0700
+++ linux-2.4.21-ac2/arch/i386/kernel/mpparse.c 2003-07-01 16:07:40.000000000 -0700
@@ -999,7 +999,14 @@
processor.mpc_type = MP_PROCESSOR;
processor.mpc_apicid = id;
- processor.mpc_apicver = 0x10; /* TBD: lapic version */
+
+ /*
+ * mp_register_lapic_address() which is called before the
+ * current function does the fixmap of FIX_APIC_BASE.
+ * Read in the correct APIC version from there
+ */
+ processor.mpc_apicver = apic_read(APIC_LVR);
+
processor.mpc_cpuflag = (enabled ? CPU_ENABLED : 0);
processor.mpc_cpuflag |= (boot_cpu ? CPU_BOOTPROCESSOR : 0);
processor.mpc_cpufeature = (boot_cpu_data.x86 << 8) |
reply other threads:[~2003-07-02 23:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C8C38546F90ABF408A5961FC01FDBF1902C7D0AC@fmsmsx405.fm.intel.com \
--to=venkatesh.pallipadi@intel.com \
--cc=Bruno.Cornec@hp.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jun.nakajima@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®