From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender6-op-o11.zoho.com (sender6-op-o11.zoho.com [165.173.180.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A7AFD52CCDF; Wed, 23 Sep 2026 14:00:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=165.173.180.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790172037; cv=pass; b=JNc081OIz6sjcn5mc/Jn5Ybt5EVx4FNC8AFoUEme51JTfFUUEVlwRmPFyIp3FSd+tXXt0WT6iX7uQnGVYp6QyrF5uBMvBLruprvyngtKhLcQPyLX3Z/kKi3iYY36x9wHO3aR4GIKtl+pIreGMjC33YKjYYJittO6P7hqlLBus7Q= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790172037; c=relaxed/simple; bh=6533UyEVQVvXizIdCznOAiy6uyccdRCYUbyNmbwZJMs=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=hin3ZDEmUfMvIIgDYqFLyNr4EJVaYxCtDA8wiCm8vL0WYqXel1W1W66Xi9Sh/lha3PXd/LJ/ANpZZPf6KszUaeUbbg0ACm0nWdIx4zltlryMdrrq1Y5ExCHhzspMDMBjFGVMCcrDIJl8ChWAi5mLOY9DOyXISCtlpBHi+9HvuG8= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b=fjIYZKEz; arc=pass smtp.client-ip=165.173.180.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=daniel.almeida@collabora.com header.b="fjIYZKEz" ARC-Seal: i=1; a=rsa-sha256; t=1790171965; cv=none; d=zohomail.com; s=zohoarc; b=jicYzAoprwpsIWN1U00F8UuLOdczK6zyosgQsUMxTcGqqofaM/VefKS9qvdQrsxWMCf5AZkZr8q32XtrxvhfhNLmZHp1ao9SI5AHGaK4ExjXcKJK+tDjeO/Fb9OxcfaRJ7WG4YExTzLqcZDR/Ca4A1KcOcqiO9tFkaKxAM9oUZ8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1790171965; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=L7epMfBwO2rJwwLcucODN167YbFCjHgq+KPch1hiG+E=; b=U3raRjcO6FiJ8s4sct/2rOaXtEQ1OwGsVPV2UGR0TsHGrfboVeAFLUD4w9dcVfeLpOrT7G7ChlDTpjpM53jLZq27vMKLoywIn4N/YME9tmzdnd+ihTLg5QkGu1qS/1N+gXO7c1kVJwsgc1xLASfLmu5M0fZgWn8hU0bIAAe84rA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=daniel.almeida@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1790171965; s=zohomail; d=collabora.com; i=daniel.almeida@collabora.com; h=Content-Type:Mime-Version:Subject:Subject:From:From:In-Reply-To:Date:Date:Cc:Cc:Content-Transfer-Encoding:Message-Id:Message-Id:To:To:Reply-To; bh=L7epMfBwO2rJwwLcucODN167YbFCjHgq+KPch1hiG+E=; b=fjIYZKEzmcfcdkZEfeXVr6h+2+NJw9FaHxC7kbQcYExCGJHZK0rPbOBJl5vriP1m 4rzcIccVn9O/ZqzG2XS29d9x0NE0QIS5rhdcZ81UjTTDCuXDTTRh/MFIqgpnLODgrPh q+jBR+IOtijQ1DjlES/Nm9Da1CotXBbDEdC8T1T4= Received: by smtp.zohomail.com with SMTPS id 1790171962617504.15189302321266; Wed, 23 Sep 2026 06:59:22 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3901.100.1.1.11\)) Subject: Re: [PATCH 1/9] drm/tyr: validate presence of CSF shared section From: Daniel Almeida In-Reply-To: <20260915-tyr-interfaces-v1-1-5d28f1f75aca@collabora.com> Date: Wed, 23 Sep 2026 10:59:02 -0300 Cc: Danilo Krummrich , Alice Ryhl , David Airlie , Simona Vetter , Miguel Ojeda , Boqun Feng , Gary Guo , =?utf-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Trevor Gross , Tamir Duberstein , Alexandre Courbot , =?utf-8?Q?Onur_=C3=96zkan?= , FUJITA Tomonori , Frederic Weisbecker , Lyude Paul , Thomas Gleixner , Anna-Maria Behnsen , John Stultz , Stephen Boyd , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, driver-core@lists.linux.dev, rust-for-linux@vger.kernel.org, kernel@collabora.com, Deborah Brouwer Content-Transfer-Encoding: quoted-printable Message-Id: References: <20260915-tyr-interfaces-v1-0-5d28f1f75aca@collabora.com> <20260915-tyr-interfaces-v1-1-5d28f1f75aca@collabora.com> To: Laura Nao X-Mailer: Apple Mail (2.3901.100.1.1.11) X-ZohoMailClient: External > On 15 Sep 2026, at 07:57, Laura Nao wrote: >=20 > From: Deborah Brouwer >=20 > The firmware binary must have a shared section for communicating with > the MCU. Check for this section after parsing and fail with -EINVAL if = it > is missing. >=20 > Signed-off-by: Deborah Brouwer > Signed-off-by: Laura Nao > --- > drivers/gpu/drm/tyr/fw/parser.rs | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) >=20 > diff --git a/drivers/gpu/drm/tyr/fw/parser.rs = b/drivers/gpu/drm/tyr/fw/parser.rs > index c4d0ad1d7899..8bddaa1f0aa2 100644 > --- a/drivers/gpu/drm/tyr/fw/parser.rs > +++ b/drivers/gpu/drm/tyr/fw/parser.rs > @@ -197,6 +197,20 @@ pub(super) fn parse(&mut self) -> = Result> { > return Err(EINVAL); > } >=20 > + // Validate that the firmware contains the required shared = memory section. > + let has_shared_section =3D parsed_sections > + .iter() > + .any(|section| section.va.start =3D=3D = super::CSF_MCU_SHARED_REGION_START); > + > + if !has_shared_section { > + dev_err!( > + self.cursor.dev, > + "No shared section found at 0x{:08x} in firmware\n", > + super::CSF_MCU_SHARED_REGION_START > + ); > + return Err(EINVAL); > + } > + > Ok(parsed_sections) > } >=20 >=20 > --=20 > 2.39.5 >=20 Reviewed-by: Daniel Almeida =