From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 136492609EE for ; Sun, 7 Dec 2025 12:24:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765110289; cv=none; b=uvYmj5B4FFVR85uTX9Xnrj6HAl5C+vXw+mCoXMcJq94B1rgFYF4AClns3KLHtAPfEIlVNNh/4vwIW88utiZ45vj6cKmvNo8PVnjJjpVPGHyEKLIojkjYJ1NoyC+i5NImfu/NPv/Na3jBu8rsOeHuWQ3RtKRESE7Gs11juo6WLRs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765110289; c=relaxed/simple; bh=77jv+KFNbqJ5gbQ0yMtkfIpBkMu3Ba/WQ5SaNdqlD8M=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=jU7S2ELrfHI4Aa5v4IRgaes79A9eXrpjXMzl9s55pf8187pOrdG2ifUnXQxzGuiWU4GZdw4BjsiON+xZq41LOEVSBg64rNDh7oy1kO0dSxqJd4POy3Q1VyKQnjjxl2DI5YCRqplp90edkjeQu2slg93S8Q3S3H5jvdwCyBuAqNU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LT1+hQAf; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LT1+hQAf" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-47778b23f64so22015665e9.0 for ; Sun, 07 Dec 2025 04:24:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765110286; x=1765715086; darn=vger.kernel.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=fl1kkKhpVPyl0p4GnJfcedu4IBpEFqXBvrIdqh+PkaI=; b=LT1+hQAfwlW2c1/a8FNWnMauIRpNTRgnK2orwZt33pqd7j50o/fDk3aWE7xJljq7Md ioKuJJk1R4KrbIAXlsh7Ak0oUyL58ZVfIPJpmlaWH/If2a7d5G2NgEujgE/g3aFcagry BaTe1E2Fe8m31afbOB0ic2Ku+DfAIOnau1gIPp9jf45aDMRAOT+/CLFN+q3wtdVzaIRk tpfmDEv3vhu3jFwkx5mQwogzTDaP+J50eT695UQ1PiFl5h+IfqB9fPrKN+iwXkLQ+7ql X1M26hFbNCkJKUgI4Kh5XnfU7kE9ZVQm7vNBZrwJJjhgxsK28c2rSFOLxp6ImRPNDlhP Ymqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765110286; x=1765715086; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=fl1kkKhpVPyl0p4GnJfcedu4IBpEFqXBvrIdqh+PkaI=; b=jIIb2fPJaeIuKqwCkMUsSPvVDEoLgY93DXhQ0tBTwab1GKPXjyK1mkenrHRTaxXR1p y8llpq1olDRzCwCmZ3Dt+Du31KdeTibb6HFc3E9LU1EHzDI/89f+32YTRJyQMXh7B9/Y 33Nm1j+BZLdT8T/Fn/JMULtzyT/ugbl13xEy26kZ4QDmdgAnRKAFd6DrOfSkE5QCCyr1 Df5dTPjRBImS00GddfGu6JqJJRRUz6/3JB1a41nnAaNBnZx2FCv6yeG6lodVoX7XmUts b2NdICkpzztoaE9lQFplPez2WmofT+IRepajvh5bTonrhQrTqa26+5MgFTS3Z86EXO3N pO3A== X-Gm-Message-State: AOJu0YyC4LZzqWq+NgS/doKFhfph5qVrdzs2q+E/mkXZjAO8Z0OS2tZg qi4cZzJcH4Z/OtxMw3fRDLqi9QiCBG6DcFtZFhwwlQUMwMgjo6IZVcyS X-Gm-Gg: ASbGncuuhm8MEu7H7RhVytxdynm0UBGlXjVlfENpoUN7M6JKVhoxOOmMIEyuxBQMcg6 WlbknfLhAq5WUg59aXZcSMDE7dyTzf3Ns0NyhfyBtCucvxaMi03G1CazpRBCz0nscOIkUPEGXF3 sNJb9TpERT6ai/C+cMBrG8P9auP7bM8xSNFHxvJYyckum2zV2JzI1vedxGmrirZgztEb8My4y8Y VO0Y4GltNmkQJNzFz8nvqLuv5RlpgUyhXaqwLJoN8qgvQXC9e0R0FEPexWJ6d0KlvQHO+dazDwZ K1kSc8tOQK/NBth2nnPS8DHMimSLHKRW1rmcOkFs0OaRbjzAhy0UTQzmNxMjgpa1zbpVcHM+qOe cbT9ZGngPeYBAZG8tUR+7z4b3oE0rvVBHI0NZetx4NQFZLu5xa+R4EyS9onvQFPioA2jM32zXRr Rym+JQ7kH0wUus2mn6sUA3mQkfhbX+gWOSugpdC8ZHAg== X-Google-Smtp-Source: AGHT+IFYNytRWOoRWAn3wuIAxlT2l9Sf9Gj3BBpCG6lKrrYKjNp1jrrzXLs8UNkcqC+phor02o5mjQ== X-Received: by 2002:a05:600c:19cf:b0:46e:4586:57e4 with SMTP id 5b1f17b1804b1-47939e3a6c6mr53136075e9.24.1765110286247; Sun, 07 Dec 2025 04:24:46 -0800 (PST) Received: from smtpclient.apple ([212.59.70.42]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47933aef61fsm148718095e9.7.2025.12.07.04.24.43 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 07 Dec 2025 04:24:44 -0800 (PST) Content-Type: text/plain; charset=utf-8 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.200.81.1.6\)) Subject: Re: [PATCH v1 4/4] mm/hugetlb: fix excessive IPI broadcasts when unsharing PMD tables using mmu_gather From: Nadav Amit In-Reply-To: <0914A8DB-447C-4E62-B151-62E5E4E99749@gmail.com> Date: Sun, 7 Dec 2025 14:24:32 +0200 Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Arnd Bergmann , Muchun Song , Oscar Salvador , "Liam R. Howlett" , Lorenzo Stoakes , Vlastimil Babka , Jann Horn , Pedro Falcato , Rik van Riel , Harry Yoo , Laurence Oberman , Prakash Sangappa , stable@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <20251205213558.2980480-1-david@kernel.org> <20251205213558.2980480-5-david@kernel.org> <0914A8DB-447C-4E62-B151-62E5E4E99749@gmail.com> To: "David Hildenbrand (Red Hat)" X-Mailer: Apple Mail (2.3864.200.81.1.6) > On 7 Dec 2025, at 14:15, Nadav Amit wrote: >=20 >=20 >> On 5 Dec 2025, at 23:35, David Hildenbrand (Red Hat) = wrote: >>=20 >> @@ -400,6 +411,7 @@ static inline void __tlb_reset_range(struct = mmu_gather *tlb) >>=20 >=20 > @@ -400,6 +411,7 @@ static inline void __tlb_reset_range(struct = mmu_gather *tlb) > tlb->cleared_pmds =3D 0; > tlb->cleared_puds =3D 0; > tlb->cleared_p4ds =3D 0; > + tlb->unshared_tables =3D 0; > /* > * Do not reset mmu_gather::vma_* fields here, we do not > * call into tlb_start_vma() again to set them if there is an >=20 > I understand you don=E2=80=99t want to initialize = fully_unshared_tables here, but > tlb_gather_mmu() needs to happen somewhere. So you probably want it to > take place in tlb_gather_mmu(), no? To clarify my messed up response: the code needs to initialize = fully_unshared_tables somewhere during tlb_gather_mmu() invocation.