From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751965AbdHCBGX (ORCPT ); Wed, 2 Aug 2017 21:06:23 -0400 Received: from mail-oi0-f41.google.com ([209.85.218.41]:36020 "EHLO mail-oi0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751188AbdHCBGV (ORCPT ); Wed, 2 Aug 2017 21:06:21 -0400 MIME-Version: 1.0 In-Reply-To: <20170803102810.37f7c6b0@canb.auug.org.au> References: <20170803063743.1d50a5d2@canb.auug.org.au> <20170802235740.GB27974@fury> <20170803102810.37f7c6b0@canb.auug.org.au> From: Linus Torvalds Date: Wed, 2 Aug 2017 18:06:20 -0700 X-Google-Sender-Auth: fHvmF27WG34mDO5VQyrrfI_n6YQ Message-ID: Subject: Re: linux-next: Signed-off-by missing for commit in the drivers-x86 tree To: Stephen Rothwell Cc: Darren Hart , Linux-Next Mailing List , Linux Kernel Mailing List , "Gustavo A. R. Silva" , Andy Shevchenko , Dan Carpenter Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 2, 2017 at 5:28 PM, Stephen Rothwell wrote: > > I would say that if you rebase someone's commit(s), then you are on the > "patch's delivery path" and so should add a Signed-off-by tag. Yeah, I agree. Rebasing really is pretty much the exact same thing as applying a patch. > "git rebase" does have a "--signoff" option. I think you end up signing off twice using that. I don't think it's smart enough to say "oh, you already did it once". But I didn't check. Sometimes git is a lot smarter than I remember it being, simply because I don't worry about it. Junio does a good job. And in general, you simply should never rebase commits that have already been publicized. And the fact that you didn't commit them in the first place definitely means that they've been public somewhere. So I would definitely suggest against the "git rebase --signoff" model, even if git were to do the "right thing". It's simply fundamentally the wrong thing to do. Either you already committed them (and hopefully signed off correctly the first time), or you didn't (and you shouldn't be rebasing). So in neither case is "git rebase --signoff" sensible. Linus