mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: kernel test robot <xiaolong.ye@intel.com>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	LKP <lkp@01.org>, Huang Ying <ying.huang@intel.com>,
	Aaron Lu <aaron.lu@intel.com>
Subject: Re: [lkp-robot] [Kbuild] 050e9baa9d: netperf.Throughput_total_tps -5.6% regression (FYI)
Date: Thu, 21 Jun 2018 17:15:09 +0900	[thread overview]
Message-ID: <CA+55aFxXCD8qLfHcnshLR2_Feb=RLkOFfCeqPF_sShy7rK2cAw@mail.gmail.com> (raw)
In-Reply-To: <20180621080624.GO11011@yexl-desktop>

On Thu, Jun 21, 2018 at 5:10 PM kernel test robot <xiaolong.ye@intel.com> wrote:
>
> FYI, we noticed a -5.6% regression of netperf.Throughput_total_tps due to commit 050e9b ("Kbuild: rename CC_STACKPROTECTOR[_STRONG] config variables")

That's perhaps a surprisingly large cost to stack protector, but you
did move from "no stack protector at all":

> $ grep STACKPROTECTOR config-4.17.0-11782-gbe779f0
> CONFIG_HAVE_CC_STACKPROTECTOR=y
> CONFIG_CC_HAS_STACKPROTECTOR_NONE=y
> # CONFIG_CC_STACKPROTECTOR is not set
> CONFIG_CC_HAS_SANE_STACKPROTECTOR=y

To having the *strong* stack protector enabled:

> $ grep STACKPROTECTOR config-4.17.0-11783-g050e9baa
> CONFIG_HAVE_CC_STACKPROTECTOR=y
> CONFIG_CC_HAS_STACKPROTECTOR_NONE=y
> CONFIG_STACKPROTECTOR=y
> CONFIG_STACKPROTECTOR_STRONG=y
> CONFIG_CC_HAS_SANE_STACKPROTECTOR=y

so you're testing the "no overhead" case to the "worst overhead" case.

                Linus

  reply	other threads:[~2018-06-21  8:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-21  8:06 kernel test robot
2018-06-21  8:15 ` Linus Torvalds [this message]
2018-06-21  8:25   ` Huang, Ying
2018-06-21  8:37     ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+55aFxXCD8qLfHcnshLR2_Feb=RLkOFfCeqPF_sShy7rK2cAw@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=aaron.lu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@01.org \
    --cc=xiaolong.ye@intel.com \
    --cc=yamada.masahiro@socionext.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®