From: Tony Luck <tony.luck@intel.com>
To: Matthew Garrett <mjg@redhat.com>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org, mikew@google.com
Subject: Re: [PATCH V2 6/9] efivars: String functions
Date: Tue, 2 Aug 2011 09:48:28 -0700 [thread overview]
Message-ID: <CA+8MBbJt52QxxOSJ1MHTd7Ru3Y60Bgui9PffOXcvsBed3b4_NQ@mail.gmail.com> (raw)
In-Reply-To: <1311281880-28041-7-git-send-email-mjg@redhat.com>
On Thu, Jul 21, 2011 at 1:57 PM, Matthew Garrett <mjg@redhat.com> wrote:
> +static unsigned long
> +utf16_strlen(efi_char16_t *s)
> +{
> + return utf16_strnlen(s, ~0UL);
> +}
> +
When building with CONFIG_PSTORE=n, I see a warning:
drivers/firmware/efivars.c:161: warning: ‘utf16_strlen’ defined but not used
I can just slap:
#ifdef CONFIG_PSTORE
...
#endif
around this function definition - but I wondered if there was a better way
to fix it?
-Tony
Also with CONFIG_PSTORE=n I see:
drivers/firmware/efivars.c:602: warning: initialization from
incompatible pointer type
but that one just needs the stub definition of "efi_pstore_write" to
match the real
definition with "part" being unsigned.
next prev parent reply other threads:[~2011-08-02 16:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-21 20:57 Add efi variables as a pstore backend Matthew Garrett
2011-07-21 20:57 ` [PATCH V2 1/9] pstore: Extend API Matthew Garrett
2011-07-21 20:57 ` [PATCH V2 2/9] pstore: Add extra context for writes and erases Matthew Garrett
2011-07-21 20:57 ` [PATCH V2 3/9] pstore: Make "part" unsigned Matthew Garrett
2011-07-21 20:57 ` [PATCH V2 4/9] pstore: Allow the user to explicitly choose a backend Matthew Garrett
2011-07-21 20:57 ` [PATCH V2 5/9] efi: Add support for using efivars as a pstore backend Matthew Garrett
2011-07-21 20:57 ` [PATCH V2 6/9] efivars: String functions Matthew Garrett
2011-08-02 16:48 ` Tony Luck [this message]
2011-07-21 20:57 ` [PATCH V2 7/9] efivars: introduce utf16_strncmp Matthew Garrett
2011-07-21 20:57 ` [PATCH V2 8/9] efivars: Use string functions in pstore_write Matthew Garrett
2011-07-21 20:58 ` [PATCH V2 9/9] efivars: Introduce PSTORE_EFI_ATTRIBUTES Matthew Garrett
2011-07-21 23:06 ` Add efi variables as a pstore backend Mike Waychison
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+8MBbJt52QxxOSJ1MHTd7Ru3Y60Bgui9PffOXcvsBed3b4_NQ@mail.gmail.com \
--to=tony.luck@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikew@google.com \
--cc=mjg@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®