From: Patrick Palka <patrick@parcs.ath.cx>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Rashika Kheria <rashika.kheria@gmail.com>,
Josh Triplett <josh@joshtriplett.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>
Subject: Re: [PATCH v2] drivers: cpufreq: Mark function as static in cpufreq.c
Date: Sun, 2 Mar 2014 22:42:29 -0500 [thread overview]
Message-ID: <CA+C-WL-pnQne-Cz8MuSFPpcHH33ARbRRm-R6VT9aEKzgNHZQQg@mail.gmail.com> (raw)
In-Reply-To: <CAKohpomqu22Pt5_wYV3u2uC36AgfmrkvxLtJCGakdodEQFE-jQ@mail.gmail.com>
On Thu, Feb 27, 2014 at 12:25 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> Hi Rashika,
>
> On 26 February 2014 22:08, Rashika Kheria <rashika.kheria@gmail.com> wrote:
>> Mark function as static in cpufreq.c because it is not
>> used outside this file.
>>
>> This eliminates the following warning in cpufreq.c:
>> drivers/cpufreq/cpufreq.c:355:9: warning: no previous prototype for 'show_boost' [-Wmissing-prototypes]
>
> Can you please elaborate how this warning is related to
> the non-static definition of this function?
-Wmissing-prototypes warns when a non-static function is defined
before a corresponding prototype (usually inside an included header
file) is declared. In such a case, it is impossible to reference the
non-static function from another file, and therefore the function
should be marked static (usually). Hope that makes sense!
next prev parent reply other threads:[~2014-03-03 3:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <linux-pm@vger.kernel.org20140226154625.GA10701@rashika>
2014-02-26 16:38 ` Rashika Kheria
2014-02-26 16:41 ` Josh Triplett
2014-02-26 16:45 ` Rashika Kheria
2014-02-26 17:08 ` Josh Triplett
2014-02-27 5:25 ` Viresh Kumar
2014-03-03 0:29 ` Viresh Kumar
2014-03-03 3:42 ` Patrick Palka [this message]
2014-03-03 7:20 ` Viresh Kumar
2014-02-26 16:52 ` Dirk Brandewie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+C-WL-pnQne-Cz8MuSFPpcHH33ARbRRm-R6VT9aEKzgNHZQQg@mail.gmail.com \
--to=patrick@parcs.ath.cx \
--cc=cpufreq@vger.kernel.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rashika.kheria@gmail.com \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®