From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90FB7C4724C for ; Mon, 4 May 2020 17:56:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 65204206D9 for ; Mon, 4 May 2020 17:56:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="ZGEyPwV0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730582AbgEDR4n (ORCPT ); Mon, 4 May 2020 13:56:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56402 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1729386AbgEDR4m (ORCPT ); Mon, 4 May 2020 13:56:42 -0400 Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com [IPv6:2a00:1450:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8CDECC061A0F for ; Mon, 4 May 2020 10:56:41 -0700 (PDT) Received: by mail-ej1-x641.google.com with SMTP id a2so14715662ejx.5 for ; Mon, 04 May 2020 10:56:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RjIlcnq4yiC6vV5MYzey8j0IMoFyjTKlaFO0D+bQg24=; b=ZGEyPwV03UkmAUrht9/IhvuD1CmRcikPe5XRtd0QZjb6wKtnzvCsvnSu+MS+y0s0Hk z1HUVem0q596xf/xLXiL+6/UR8QQTZBqjWw2gONtaZd2BXEBQqeqovU6O7bheFuu4GCi KxIpqERDZluuFq4GZjuuaEykRni7NJfk88Vc7yMqUe8CrGvk7Gu7xHcVdteGOmCv4dWL eMWILgwESOkvC8pLu2xalTHSzD21cw51yXWPNmaHBeGUvL+2MPeJhiEFr5uNGN1nII4a 1JKwBTVD1jV+acMUwVAMfjXEPViCk7JRXleFI2rrsmnOY65xKNg4+K1bIWNxoPYfW44f dOlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RjIlcnq4yiC6vV5MYzey8j0IMoFyjTKlaFO0D+bQg24=; b=b4QOSYeS72Tz6X95Jb8IG2s6a/d90yyCX5uuCr5xj4QUs4/QMhnYx7q4YoyI5FqUhy AhjJTz/UdyJxtVK0XgnBb7z4ihz2Rwxyxq/D10CyPEIzOtH62QdPqUrXN4cFfPthMy0a AlqvI/rGfLLIl+tyHWeZIIn01wYStrrG1gH2FvdE6sWDM/0E/+6k+JRFr9z/Y8YTpTI1 k0t4KhcaBZXrm7Q1toSSd85dpZr3XDd6CxFxp9bKNGw87dC+cKcP18LtaXedyBLBfdBy VnHF38C2D8gEofPgo4z+L8IBXDgMP4JpoBJdsR+xf9+9+O63euTjN26/9R5WkhxtZvrm 5UMA== X-Gm-Message-State: AGi0PuZG9j5JxtLZ0k/MS4jTBFajeJ/Vcekh13SiaEgHC3RGGcm2Izlv qpRS4xlnC4NN3oSZJMkZSmuNhxTVf3D0ci/+TNRthQ== X-Google-Smtp-Source: APiQypJulmPEpxcWX1jyXL8BWDiI54NDVxDpnmYWCjC6BTiL2RZDj0Ms+5KHcenqxHDwS47TFsCwyara8rfJrVk9c7U= X-Received: by 2002:a17:906:49c7:: with SMTP id w7mr16307878ejv.29.1588615000212; Mon, 04 May 2020 10:56:40 -0700 (PDT) MIME-Version: 1.0 References: <20200502143555.543636-1-pasha.tatashin@soleen.com> <20200502143555.543636-2-pasha.tatashin@soleen.com> <20200504131500.5f6c8860@gandalf.local.home> In-Reply-To: <20200504131500.5f6c8860@gandalf.local.home> From: Pavel Tatashin Date: Mon, 4 May 2020 13:56:04 -0400 Message-ID: Subject: Re: [PATCH v1 1/3] printk: honor the max_reason field in kmsg_dumper To: Steven Rostedt Cc: James Morris , Sasha Levin , LKML , Petr Mladek , Sergey Senozhatsky , Kees Cook , anton@enomsg.org, ccross@android.com, Tony Luck , robh+dt@kernel.org, devicetree@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Hmm, I didn't realize that enums were allowed to have duplicates. That can > usually screw up logic. I would recommend making that a define afterward. > > #define KMSG_DUMP_MAX KMSG_DUMP_POWEROFF > > As is done in other locations of the kernel. > Hi Steve, Sure, I will change it to define. Thank you, Pasha