From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69A7E303A3B for ; Fri, 14 Nov 2025 22:07:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763158043; cv=none; b=Z8upZkvfc0MVUe3LI0WxZAW6pTLEiXz1/nfA7Mz/eqVM95elv47CpfbeuwkhQ+cLodENIkiNb+RKRh1n5fy6YeYYzFjF2I2T6WXbDXN9grn40B/7QtG43NoQ3tApQ1jsA0avdBUO2chOanWHAaW7PlSYcyFVX8il0qH05Tczpg8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763158043; c=relaxed/simple; bh=ddANZo0ZPYRHnROaKWqLzxSgcJuhqO6MNC1PWkOw3rU=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=VdVofqRt1ukvY/gtGy5oi2j4KfUxbrCO6qoVPGvIKbHluoYBJO91Pw6lUPgPgcpc/R3/9n5v0vyVsdH9+6iu6RUE1rimDPkqpsElRDp6jKedtSTGTcZJxZoFzYfAga56BSnB/MJh+2qBAYCGL1CtJeo457znJUjYwnvXAlPBZLw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com; spf=pass smtp.mailfrom=soleen.com; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b=i8aC5c4A; arc=none smtp.client-ip=209.85.208.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=soleen.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="i8aC5c4A" Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-64180bd67b7so3489698a12.0 for ; Fri, 14 Nov 2025 14:07:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1763158040; x=1763762840; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NsPGYF2w3uxO5rL5MOHM8fulZ8/BOxWbrIXWlML1778=; b=i8aC5c4AnhcbCqvbUFn16/IoCicucv6Hles/g1ZBIyo1C1YW2Y905L7Z8DpcVkYap7 73ARD2jh8oSKy/fTMXeYORneVacrXPWJKfBhky5O3qJgDmL92lLtyrwwfGqi5L9BKbLo EjvWi4ATxoMQJ25wmR9iA2ZsBS1/G/767u/Ku7TW3IdQVVy5BLObnGxQ6GcS9hzXHWlo iYhFlXUrsxKFUFUdvrFeZH4Gny3sSCwJg+mhe16f301MMB49OiGSCgV/eedBvE6jbvSZ jkiNOyMf6MH8Izixjk2C0gjDk0ac1SK186ND5V1JSBdUGbdlajhamd6TXjQ9AtJmV+fJ x/LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763158040; x=1763762840; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=NsPGYF2w3uxO5rL5MOHM8fulZ8/BOxWbrIXWlML1778=; b=bx/rb+eCqPu2mYTNDvs7odlp/ykpEZ70Jx5biISq1gYWgRJpnI6eGESbhbSZWRo9F4 U4b13HHE3PkxQPnSXcUsprsBHoFdOZv7cHaZzQ870Xb4gRSlfZMpwTNOPy9gw95vDU1B mn+0cSam+vs5dpJPD/If7LsvkCsL1RpMyRz3ZubRKClfYShB7bVuyT5YaPJxFg66hbbU /7tOtcn3kOwY1H873KzJfE50SGPanfq9SDeLficncJ5qssftwz6iaGMuoSIV9iDzBPhd MaZ9GnMndZPcb9cfGr9J/e1J/yEjZLF/V6MGb+8KQjtP1P7EV+SNckXP2kK1sHYr2DRs Zzhg== X-Forwarded-Encrypted: i=1; AJvYcCV17nkBDADfZL3x/DW0JpUavmn13N6Gii1khZ8iF0o6cVe8BmKcodCOAbPIgUaRiml57CuSNxKuPv1QiQE=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7GMxaDlAmPux3cUy/9QguGSlIcD9XcEVcKOGVA2js1yo0D2Vr MKmtE3KQ7NGF3EU2ZmeW5RBv3TCbgZcxRfEXjAelZWz74jQIjTRQMp9CVFhu8GqsoWW4SedBfM1 vFBeiXOFofOOUY8Jbd0zkVml+aWqdQMt/kBNcmfZghQ== X-Gm-Gg: ASbGncvoFmt0fzxNqFVQV/uaGyvxvusRrgyUrTj/zmddvkygfr4XG2qfpfCvbffuWmy 3WxjxsYLEJbevtDWGG5iAqUgrc+z/qv0Sh79mdXaEjCRfj8uKjcCnn+rQqfBC/zLsqhW1jBb8IU 8F8qXW6hVTipSM6PNrgvunt+ksiIYFJoUqFDqOKlEefeLJSLUVInF3CIvmzWh1O0lmzyCnwqFAm OPDE5C8hE/JLfbOAG2DIBeWBleSlE+sjac3phGl4d/OiQL8hnqGMQM1rN8yaMCi+PaX X-Google-Smtp-Source: AGHT+IGFFZxrMCPmeJDXNHicMreqnciEQvXQFLNeLQFPskn+jhYADDIQoofuIRZMtOTmH83ub483KykN+dONJWKkP+U= X-Received: by 2002:a05:6402:2710:b0:640:c454:e9 with SMTP id 4fb4d7f45d1cf-64350e1120fmr4061156a12.4.1763158039593; Fri, 14 Nov 2025 14:07:19 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20251114190002.3311679-1-pasha.tatashin@soleen.com> <20251114134434.5375d085a6bdc1671351f243@linux-foundation.org> In-Reply-To: From: Pasha Tatashin Date: Fri, 14 Nov 2025 17:06:42 -0500 X-Gm-Features: AWmQ_bmztZ2aQAhXiPYW2w94nYRhCiX3lNmPSLyIjD-mYwCHE5AQJdQs-jg1R5U Message-ID: Subject: Re: [PATCH v2 00/13] kho: simplify state machine and enable dynamic updates To: Andrew Morton Cc: bhe@redhat.com, rppt@kernel.org, jasonmiu@google.com, arnd@arndb.de, coxu@redhat.com, dave@vasilevsky.ca, ebiggers@google.com, graf@amazon.com, kees@kernel.org, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Nov 14, 2025 at 5:00=E2=80=AFPM Pasha Tatashin wrote: > > On Fri, Nov 14, 2025 at 4:44=E2=80=AFPM Andrew Morton wrote: > > > > On Fri, 14 Nov 2025 13:59:49 -0500 Pasha Tatashin wrote: > > > > > Andrew: This series applies against mm-nonmm-unstable, but should > > > go right before LUOv5, i.e. on top of: > > > "liveupdate: kho: use %pe format specifier for error pointer printing= " > > > > > > Changelog v2: > > > - Addressed comments from Mike and Pratyush > > > - Added Review-bys. > > > > > > It also replaces the following patches, that once applied should be > > > dropped from mm-nonmm-unstable: > > > "liveupdate: kho: when live update add KHO image during kexec load" > > > "liveupdate: Kconfig: make debugfs optional" > > > "kho: enable KHO by default" > > > > > > This patch series refactors the Kexec Handover subsystem to transitio= n > > > from a rigid, state-locked model to a dynamic, re-entrant architectur= e. > > > It also introduces usability improvements. > > > > OK. Also, with this series, kho_unpreserve_folio() returns void, and LUOv5 requires two small fixes where this function is used: 1. fixup for mm: "memfd_luo: allow preserving memfd" diff --git a/mm/memfd_luo.c b/mm/memfd_luo.c index e366de627264..ba435590d2cf 100644 --- a/mm/memfd_luo.c +++ b/mm/memfd_luo.c @@ -138,7 +138,7 @@ static struct memfd_luo_folio_ser *memfd_luo_preserve_folios(struct file *file, err_unpreserve: i--; for (; i >=3D 0; i--) - WARN_ON_ONCE(kho_unpreserve_folio(folios[i])); + kho_unpreserve_folio(folios[i]); vfree(pfolios); err_unpin: unpin_folios(folios, nr_folios); @@ -170,7 +170,7 @@ static void memfd_luo_unpreserve_folios(void *fdt, struct memfd_luo_folio_ser *p folio =3D pfn_folio(PRESERVED_FOLIO_PFN(pfolio->foliodesc))= ; - WARN_ON_ONCE(kho_unpreserve_folio(folio)); + kho_unpreserve_folio(folio); unpin_folio(folio); } 2. Fixup for liveupdate: luo_core: integrate with KHO: diff --git a/kernel/liveupdate/luo_core.c b/kernel/liveupdate/luo_core.c index 29a094ee225c..f0bc3ee0a10b 100644 --- a/kernel/liveupdate/luo_core.c +++ b/kernel/liveupdate/luo_core.c @@ -305,7 +305,7 @@ void luo_free_unpreserve(void *mem, size_t size) return; folio =3D virt_to_folio(mem); - WARN_ON_ONCE(kho_unpreserve_folio(folio)); + kho_unpreserve_folio(folio); folio_put(folio); } > > > > Where are we with the series "Live Update Orchestrator, v5"? > > I am working on LUOv6, it is going to be an incremental update with > much smaller delta compared to v4->v5, addressing all the comments > collected so far. I plan to send it out this weekend. > > Thank you, > Pasha > > > I'm seeing a couple of review comments which I plan to circle back on: > > > > https://lkml.kernel.org/r/aROZi043lxtegqWE@kernel.org > > https://lkml.kernel.org/r/mafs0ms4tajcs.fsf@kernel.org > > and a comment from yourself against > > liveupdate-luo_core-integrate-with-kho.patch which indicates that you > > plan to update that patch?