From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764235AbcINToz (ORCPT ); Wed, 14 Sep 2016 15:44:55 -0400 Received: from mail-yb0-f195.google.com ([209.85.213.195]:35411 "EHLO mail-yb0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762745AbcINTox (ORCPT ); Wed, 14 Sep 2016 15:44:53 -0400 MIME-Version: 1.0 In-Reply-To: <1471505884-33996-2-git-send-email-B56489@freescale.com> References: <1471505884-33996-1-git-send-email-B56489@freescale.com> <1471505884-33996-2-git-send-email-B56489@freescale.com> From: Han Xu Date: Wed, 14 Sep 2016 14:44:52 -0500 Message-ID: Subject: Re: [PATCH v3 2/9] mtd: fsl-quadspi: Rename SEQID_QUAD_READ to SEQID_READ To: Yunhui Cui Cc: David Woodhouse , Brian Norris , "han.xu@freescale.com" , jagannadh.teki@gmail.com, Yunhui Cui , "linux-mtd@lists.infradead.org" , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Yao Yuan Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 18, 2016 at 2:37 AM, Yunhui Cui wrote: > There are some read modes for flash, such as NORMAL, FAST, > QUAD, DDR QUAD. These modes will use the identical lut table base > So rename SEQID_QUAD_READ to SEQID_READ. > > Signed-off-by: Yunhui Cui > Signed-off-by: Yunhui Cui > --- > drivers/mtd/spi-nor/fsl-quadspi.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c > index 5ad6402..21c77e8 100644 > --- a/drivers/mtd/spi-nor/fsl-quadspi.c > +++ b/drivers/mtd/spi-nor/fsl-quadspi.c > @@ -193,7 +193,7 @@ > #define QUADSPI_LUT_NUM 64 > > /* SEQID -- we can have 16 seqids at most. */ > -#define SEQID_QUAD_READ 0 > +#define SEQID_READ 0 > #define SEQID_WREN 1 > #define SEQID_WRDI 2 > #define SEQID_RDSR 3 > @@ -386,8 +386,8 @@ static void fsl_qspi_init_lut(struct fsl_qspi *q) > for (i = 0; i < QUADSPI_LUT_NUM; i++) > qspi_writel(q, 0, base + QUADSPI_LUT_BASE + i * 4); > > - /* Quad Read */ > - lut_base = SEQID_QUAD_READ * 4; > + /* Read */ > + lut_base = SEQID_READ * 4; > > qspi_writel(q, LUT0(CMD, PAD1, read_op) | LUT1(ADDR, PAD1, addrlen), > base + QUADSPI_LUT(lut_base)); > @@ -468,7 +468,7 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd) > { > switch (cmd) { > case SPINOR_OP_READ_1_1_4: > - return SEQID_QUAD_READ; > + return SEQID_READ; > case SPINOR_OP_WREN: > return SEQID_WREN; > case SPINOR_OP_WRDI: > -- > 2.1.0.27.g96db324 > > Acked-by: Han xu > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/ -- Sincerely, Han XU