mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Naresh Kamboju <naresh.kamboju@linaro.org>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Mark Brown <broonie@kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	 Linux ARM <linux-arm-kernel@lists.infradead.org>,
	 "open list:KERNEL SELFTEST FRAMEWORK"
	<linux-kselftest@vger.kernel.org>,
	lkft-triage@lists.linaro.org,
	 Linux Regressions <regressions@lists.linux.dev>,
	Catalin Marinas <catalin.marinas@arm.com>,
	 Will Deacon <will@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	 Dan Carpenter <dan.carpenter@linaro.org>,
	Anders Roxell <anders.roxell@linaro.org>,
	 Ben Copeland <benjamin.copeland@linaro.org>,
	Shuah Khan <shuah@kernel.org>
Subject: Re: next-20250909: selftests/arm64/gcs/basic-gcs.c:390:30: error: use of undeclared identifier 'HWCAP_GCS'
Date: Tue, 16 Sep 2025 00:44:42 +0530	[thread overview]
Message-ID: <CA+G9fYsnPBYoeVMzQJMCPA1JGhcJXr53Y-_uOMKdB_3D7ZGQNQ@mail.gmail.com> (raw)
In-Reply-To: <5fe12804-2538-42c5-b5c7-66d36ff947d9@t-8ch.de>

On Mon, 15 Sept 2025 at 14:53, Thomas Weißschuh <linux@weissschuh.net> wrote:
>
> On 2025-09-12 12:14:00+0100, Mark Brown wrote:
> > On Fri, Sep 12, 2025 at 01:07:58PM +0200, Thomas Weißschuh wrote:
> >
> > > The Makefile does *not* use -nostdinc, so the nolibc program probably finds the toolchain's glibc asm/hwcap.h.
> > > There also doesn't seem to be a static arm64 hwcap header in tools/include in the first place.
> > > I am still wondering how this works for the other tests.
> >
> > make headers_install puts a copy in usr/include, probably we just need
> > to include that in the include path.
>
> Naresh, could you test the patch below?
> The other custom $(CC) rules in the gcs directory are also not
> respecting $(CFLAGS), but I'll leave these for now.

I have applied this patch on top of Linux next-20250912 tag and
tested and reported build regressions got fixed.

Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>

> diff --git a/tools/testing/selftests/arm64/gcs/Makefile b/tools/testing/selftests/arm64/gcs/Makefile
> index d2f3497a9..1fbbf0ca1 100644
> --- a/tools/testing/selftests/arm64/gcs/Makefile
> +++ b/tools/testing/selftests/arm64/gcs/Makefile
> @@ -14,11 +14,11 @@ LDLIBS+=-lpthread
>  include ../../lib.mk
>
>  $(OUTPUT)/basic-gcs: basic-gcs.c
> -       $(CC) -g -fno-asynchronous-unwind-tables -fno-ident -s -Os -nostdlib \
> -               -static -include ../../../../include/nolibc/nolibc.h \
> +       $(CC) $(CFLAGS) -fno-asynchronous-unwind-tables -fno-ident -s -nostdlib -nostdinc \
> +               -static -I../../../../include/nolibc -include ../../../../include/nolibc/nolibc.h \
>                 -I../../../../../usr/include \
>                 -std=gnu99 -I../.. -g \
> -               -ffreestanding -Wall $^ -o $@ -lgcc
> +               -ffreestanding $^ -o $@ -lgcc
>
>  $(OUTPUT)/gcs-stress-thread: gcs-stress-thread.S
>         $(CC) -nostdlib $^ -o $@
>

- Naresh

      reply	other threads:[~2025-09-15 19:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-11 19:18 Naresh Kamboju
2025-09-11 21:01 ` Mark Brown
2025-09-12  6:30 ` Thomas Weißschuh
2025-09-12 10:23   ` Naresh Kamboju
2025-09-12 10:49   ` Mark Brown
2025-09-12 10:57     ` Thomas Weißschuh
2025-09-12 11:07       ` Thomas Weißschuh
2025-09-12 11:14         ` Mark Brown
2025-09-15  9:23           ` Thomas Weißschuh
2025-09-15 19:14             ` Naresh Kamboju [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+G9fYsnPBYoeVMzQJMCPA1JGhcJXr53Y-_uOMKdB_3D7ZGQNQ@mail.gmail.com \
    --to=naresh.kamboju@linaro.org \
    --cc=anders.roxell@linaro.org \
    --cc=arnd@arndb.de \
    --cc=benjamin.copeland@linaro.org \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=dan.carpenter@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=lkft-triage@lists.linaro.org \
    --cc=regressions@lists.linux.dev \
    --cc=shuah@kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®