From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50D2CC63777 for ; Mon, 30 Nov 2020 18:28:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F2CA920705 for ; Mon, 30 Nov 2020 18:28:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=sartura-hr.20150623.gappssmtp.com header.i=@sartura-hr.20150623.gappssmtp.com header.b="djXM6E8v" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728067AbgK3S2F (ORCPT ); Mon, 30 Nov 2020 13:28:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727009AbgK3S2E (ORCPT ); Mon, 30 Nov 2020 13:28:04 -0500 Received: from mail-oi1-x243.google.com (mail-oi1-x243.google.com [IPv6:2607:f8b0:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0B63C0617A6 for ; Mon, 30 Nov 2020 10:27:11 -0800 (PST) Received: by mail-oi1-x243.google.com with SMTP id t143so15185465oif.10 for ; Mon, 30 Nov 2020 10:27:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sartura-hr.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=pc6C/q8AO1EvQvE391qCwST8+WRMXp+q0hfDj9wNYAw=; b=djXM6E8vdJaLrQtz0so3aaOqlydAeD8rRYhWJfmTmhf1XBgs39cIuhQTEmzc3VBuoH Nmq+VDIQa+hxb11/329HPkwVBCa0ubSsxMW7E/h45obUbRhhfdqszxm1hyrWbVFhyiCK kiolMlQi2R1ZTCQqV/347xASuau78mYZjV8KoTqY4NOVS0aKYQcElJhbdB33aEtZPHqO PE1m3gR51q3Qbs30oQCId7xFiOYNY0AYCECMQzc87u3XHZzstkkijJbuZC6lOq52jsNK jo/fqxYWNNSEJGJh2ZDolRxdLEUlgOgQ7H2KTsmHIOFwjjft9H4sqtAzB7J2w/MfRFuv XuLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=pc6C/q8AO1EvQvE391qCwST8+WRMXp+q0hfDj9wNYAw=; b=IDPTDEG9eJylyVIxhvwNZ2dE17iEu+uvWEeKlGzUiVzI0M0LAfJZsab/HaFsGsfw7q 0bK7Z2/cR9FNcpNyU2TgyqU/kbquWNd1Omvrn23Wx/cC+aB563ptiGTe6aoqBEEDwYKK qaorvKEJqxgbQhoZedqlXj3mg/mRbWKGAF/wC1T17x7cgBnHhdJAGZk54nU+8EL9cdYo 9BqqjOY0tOCzZ7rHWwFDG5roVBUKCnVPRZ7c7eoYxW5Szh81Yhzv78ssGHp+rb/I6OQi re0NwHPGh8k2ag4Vdw9sNjTvohvTxfCQImoUu0rYuBnobSQjJToJhpzZZvsKtQ9J6ztz YSBg== X-Gm-Message-State: AOAM531MElBgL5Kqz2QgsDd00c4e4pFmFU8Hge9wZVpZOGmK5psDNPwB UKY3jfb5nbDEq+4lWig6hcxM1uT4YOUwcAQXSas3IA== X-Google-Smtp-Source: ABdhPJxaZrDB7qg+0edaZm1dy0P1aJ9TqaCP5fAWh99oVMGlrNZvWHbehxvVuo+GQ95PSAtiPILtYN6c6kVWqc7JtGo= X-Received: by 2002:aca:a896:: with SMTP id r144mr117427oie.154.1606760831021; Mon, 30 Nov 2020 10:27:11 -0800 (PST) MIME-Version: 1.0 References: <20201031121115.542752-1-robert.marko@sartura.hr> <23aea80f-265b-8a23-e8ea-f46639dd4129@codeaurora.org> <5b7def39-8c23-d30f-e2d3-bc38beee8919@roeck-us.net> In-Reply-To: From: Robert Marko Date: Mon, 30 Nov 2020 19:27:00 +0100 Message-ID: Subject: Re: [PATCH v4] watchdog: qcom_wdt: set WDOG_HW_RUNNING bit when appropriate To: Kathiravan T Cc: Guenter Roeck , Andy Gross , Bjorn Andersson , wim@linux-watchdog.org, linux-arm-msm , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, Luka Perkov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 2, 2020 at 6:19 AM Kathiravan T wrote= : > > > On 11/2/2020 10:33 AM, Guenter Roeck wrote: > > On 11/1/20 7:58 PM, Kathiravan T wrote: > >> On 10/31/2020 7:38 PM, Guenter Roeck wrote: > >>> On 10/31/20 5:11 AM, Robert Marko wrote: > >>>> If the watchdog hardware is enabled/running during boot, e.g. > >>>> due to a boot loader configuring it, we must tell the > >>>> watchdog framework about this fact so that it can ping the > >>>> watchdog until userspace opens the device and takes over > >>>> control. > >>>> > >>>> Do so using the WDOG_HW_RUNNING flag that exists for exactly > >>>> that use-case. > >>>> > >>>> Signed-off-by: Robert Marko > >>> Reviewed-by: Guenter Roeck > >> Thanks for addressing the comments and now the patch looks good to me.= One more suggestion, can we make the initcall level of the driver to subsy= s_initcall_sync so that the driver gets registered immediately after the wa= tchdog_core is registered and watchdog_core starts pinging the WDT? > >> > > That would mean to replace module_platform_driver(), which would be a w= hole > > different discussion, is not widely needed, and would potentially inter= fere > > with the subsys_initcall_sync() in the watchdog core. This will require > > specific evidence that a problem is seen in the field, and that it is t= ruly > > needed. Plus, it would have to be a different patch (which you could su= bmit > > yourself, with evidence). Let's stick with one logical change per patch= , > > please. > > > > Guenter > Yeah, of course I don't want to squash the initcall level change with > this one. Just made a suggestion to consider it. Anyway I will try to > collect some data and post the patch by own on that suggestion. Thanks > Guenter. > > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member= of Code Aurora Forum, hosted by The Linux Foundation > Any chance this could be picked for 5.11? I have some boards depending on it for normal boot. Regards, Robert