From: Diego Viola <diego.viola@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: festevam@gmail.com, cooldavid@cooldavid.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
richard.weinberger@gmail.com, pavel@ucw.cz, rjw@rjwysocki.net
Subject: Re: [PATCH] net: jme: fix suspend/resume on JMC260
Date: Tue, 23 Feb 2016 02:11:43 -0300 [thread overview]
Message-ID: <CA+ToGPFYVb_swmD_-+TRMO4Pc5bP2gFKnBx1JSgC1Jb_S4Pb6g@mail.gmail.com> (raw)
In-Reply-To: <20160222.234234.1952119173455287427.davem@davemloft.net>
On Tue, Feb 23, 2016 at 1:42 AM, David Miller <davem@davemloft.net> wrote:
> From: Diego Viola <diego.viola@gmail.com>
> Date: Mon, 22 Feb 2016 22:58:48 -0300
>
>> On Mon, Feb 22, 2016 at 10:46 PM, Fabio Estevam <festevam@gmail.com> wrote:
>>> On Mon, Feb 22, 2016 at 9:32 PM, Diego Viola <diego.viola@gmail.com> wrote:
>>>> Signed-off-by: Diego Viola <diego.viola@gmail.com>
>>>
>>> You should write a commit log.
>>
>> I thought about including the link to my bug report:
>> https://bugzilla.kernel.org/show_bug.cgi?id=112351
>>
>> What else would you suggest I add to the commit message?
>
> The commit message is where you describe the change you are making.
>
> This includes exactly what you are fixing, how you are doing it, and why
> you are doing it that way.
>
> Empty commit log messages are %99.99999 of the time completely
> inappropriate.
David,
I understand and appreciate your advice, thanks.
However, please consider that I'm not a kernel developer, so I don't
understand much or anything about how this driver works internally,
this is why I came here to report about problem in the first place.
All I can tell you for certain is that this change makes my
suspend/resume work and it doesn't hang anymore while resuming from
suspend.
I apologize for the empty commit message and for not being able to
explain things deeper, but Pavel Machek is the person who suggested I
make this change in the code, so maybe he can provide some help?
Diego
next prev parent reply other threads:[~2016-02-23 5:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 0:32 Diego Viola
2016-02-23 1:46 ` Fabio Estevam
2016-02-23 1:58 ` Diego Viola
2016-02-23 2:35 ` Diego Viola
2016-02-23 4:42 ` David Miller
2016-02-23 5:11 ` Diego Viola [this message]
2016-02-23 5:36 ` Diego Viola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+ToGPFYVb_swmD_-+TRMO4Pc5bP2gFKnBx1JSgC1Jb_S4Pb6g@mail.gmail.com \
--to=diego.viola@gmail.com \
--cc=cooldavid@cooldavid.org \
--cc=davem@davemloft.net \
--cc=festevam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=richard.weinberger@gmail.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®