From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08007347FDE for ; Sat, 28 Mar 2026 15:23:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.208.170 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774711407; cv=pass; b=d0sWw4WaDmQ60ZmexG5KROowzMW9D1CXkbNOPn8G54QY8znJpFvNUy5ONw19jziAi3DsjyJP7g+vnPfLDM7TTd+Xg+rctbL+6JBXDGVduh3UgWqEkd6VGUQmHfAiBmdhTS4P81Kx21l0GejnlQ7i8Ga90oibgPNfYrGm3+G17sY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774711407; c=relaxed/simple; bh=y6n/CqLfd38hQW6svuKj6rGCU5+wiH4QrowOutXhZbA=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=RCMtzrZcyi5AB5PJ3lm10DdDRVW/wq3MefJyQbF2nUnBvFqRbwDS7xaRd8e5t7UDuXEsar4vdERRAYqw0eb8ztjFfANW2c9Ajj1v8cP5Fo6fun0PSHjyCwmZliW34YHTI7JthB5Zgc8b0EbN/pwhMu+af30rcppg3BIceMekjoY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rCfgBZFo; arc=pass smtp.client-ip=209.85.208.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rCfgBZFo" Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-38a32d36396so27591621fa.0 for ; Sat, 28 Mar 2026 08:23:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1774711404; cv=none; d=google.com; s=arc-20240605; b=TBKl2OXUKxJySYs3G8tLi+ya1xIvYsDZoL6f2tAP6sVJjFYUoqwgMpqBvPCGxxtFiF Jh5JMaIo520ynOh6w0xZpTBZmuUoRmY8IF44G1YhJFiy68AMpwETXWfVbDFBrx01k+oU 6q6XNVGWC8otMGd0Y97ykLEC+1mFl1J/UBdTm3Zq5HnCDiwvYqN+YDMLFcsTD11UnJ5G AO/KQRHdUpZE4N9MlCThLcZ2crhuG1a+twa4laThZBHPHAvGWgjfQHygexG+9cqxFw96 RBK8KMC8pL7xfH4izBTwvrFsbCvPoaJmy2YOvbaXYcECmBqsOpqMIrWDdxwyU9Dfkz6e 7BeQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=haMXa5Y39fYyaZPwYN+n8TJLxpZQGLuvRxS6HRz+Zto=; fh=e02cTun08NU92ZQpymWKZahdz5/D9UO6dBf+dIN6I8Q=; b=XRoAMaTpHzZnPlN9I/qUqEyDLVhS11RFz04IaHrzy0sHX9qPEFvN6FoIxDPb5V51Ch hmfP90vlMacbyh+mBlyYW9ihM4W+FfJnxUDl+phtBYefq1vxWvuAwOjdT4KuT+HwuwQr 7+A7n0SsG4XCWlkUsPvslqtMezgezvgOGv1MpAnXhqEIKLGEyEjVfDKAarsH9GHaNtrC gxlIRxpC1+Uq28fb4uh28sUVDBSNKZNiWkg4UBEJ4gPG9vlFbSLrDU6Xk8wITmMLDxh0 rpqzQ/4LnlbkZBI9uUADdENED7QgUqAHdL8Fj08Xw5hZVXjyQc9d/xNnVe2N1Qbdif/t bzjA==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1774711404; x=1775316204; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=haMXa5Y39fYyaZPwYN+n8TJLxpZQGLuvRxS6HRz+Zto=; b=rCfgBZFofJVmdOl+NVFl5qiSR9OL5c3BYeJiIrNz1UeiE/4KGSHYpUi1NhsB12iRGv g9QcHzjazqOd+PLUsRqsLCk8KzI7r3pvtzbe/tflsvcyYyf5rJaO+yJzcu5qeWJIex3E tZiDPlPW26raEEbFOu4gHIjdksPQzn2ILLUD6VjtBA/niCmD2N20gpMJb8/8owhZFkaN iyhusvJ5+Zkqgrfr0WjXcLcpQuRlaEjAr9HI4vQv7NdvNsrfFT3CboZKjweaYcJ4pNx1 O2j2IWvqlek3r83kPg1t77x2Ja40sti5G+2zj0MXNguyvlnhs01pIbHMsHAI2TF5uGLc ERQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774711404; x=1775316204; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=haMXa5Y39fYyaZPwYN+n8TJLxpZQGLuvRxS6HRz+Zto=; b=jZNANOdlx+QvuCZhVtGDo8KSQ9IRCiDBP1YVlG4hl6fkvajgdWSG271bjBWJKIzTuu OFEES7aEz2dkLM6jaHWZkTYTKmzrngqDYgIVUl02UvP5Q/LF7+uE/OINITkKyUMLsTNd KbwFHAjjGaMzyR4mb1s0vOnDvO7uJJZmccyt7Lp1sU6SfMjs/5Rolhz97y4kgolXbcJL yWBbYnnmtNJjwA3YR8VHQP0VsT7LX97tBpA0AB0TGI9Lt0fDKlGYSuiZm7b0W/hijSfx /1B1h19mdt+LLeQoIIOsrkw2kwgmwPWfhAXtxefHMhotBS6P9R+yb97y00MocByosBI2 lUJw== X-Forwarded-Encrypted: i=1; AJvYcCX1vGUXHeJouPggQ81FfLLRHp1PJBtzRrjqewQLzjJKKHYEfg8JcJAclyk9fJ1JgGdjjALt8PKgZTlOS4c=@vger.kernel.org X-Gm-Message-State: AOJu0YzVlBtjsDSYRNwFskWy//TnyMB5bKrnaWBh7VBxoDyQJNrN6klw PJEIdekOrTem++sSnB3EngAre92fIGIXpqrqR7SNHEby2EYVFA/j8Fk/MAbyj6gXPNkk0TDDrZu DE6Kbox4pyJ0FzhyoJ2pxFY5YyYPrgwc9PQuUHfU= X-Gm-Gg: ATEYQzw6f+Nk6+dRE40HowIr5IidPbxrSTqQ0kTzgaADt7CYRXb670zEpU5q0YSv4oa of1O38SnJIyHJKtL8+sXh90hDWla/ZHMLPgg2GaCB/k9hJFCjrGjOPQ8FadAQnrZO4TqXJAPWFx uSm21EU7jMt8TVFG9Qv/gPtamXhqrku7BPmmEwMnrEBoEUGzDIFfjwzpkp1Bi8+Y7QWSamNPXNW vDSF6SCYnetxUIuR40bya79rGkcgnmkBkfLEIQ3ucI1jH3vQe5Kn6uxcGerfSZEmVgri2+E9jpO zoSHQ4EDNIfjz2ywHBco3yPM7iKTHJZ6b7ed9+LspfpHF0IfkDnohR6tLld8Ukd4nc1DQusovSR /ulsZ X-Received: by 2002:a5d:5f84:0:b0:43c:edaa:f5e7 with SMTP id ffacd0b85a97d-43cedaaf6b1mr4522070f8f.14.1774702587577; Sat, 28 Mar 2026 05:56:27 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260327-b4-cru-rework-v1-0-3b7d0430f538@ideasonboard.com> In-Reply-To: From: "Lad, Prabhakar" Date: Sat, 28 Mar 2026 12:56:01 +0000 X-Gm-Features: AQROBzDQxXJq9DcMQqTPEu_ZQIpk00QlISExPIMUG9fDeLEmqKbhf2mBTMgDkrQ Message-ID: Subject: Re: [PATCH 00/14] media: rzg2l-cru: Rework slot programming for V2H/G3E To: Jacopo Mondi Cc: Mauro Carvalho Chehab , Laurent Pinchart , Biju Das , Hans Verkuil , Sakari Ailus , Tommaso Merciai , Daniel Scally , =?UTF-8?B?QmFybmFiw6FzIFDFkWN6ZQ==?= , Lad Prabhakar , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Jacopo Mondi , Daniel Scally Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Jacopo, On Sat, Mar 28, 2026 at 11:55=E2=80=AFAM Jacopo Mondi wrote: > > Hi Prabhakar > > On Fri, Mar 27, 2026 at 05:25:30PM +0000, Lad, Prabhakar wrote: > > Hi Jacopo, > > > > Thank you for the patches. > > > > On Fri, Mar 27, 2026 at 5:19=E2=80=AFPM Jacopo Mondi > > wrote: > > > > > > This patch series starts by collecting a patch sent from Dan in the p= ast > > > which improves the HW slot programming on V2H(P) to avoid losing fram= es > > > under heavy system load conditions. > > > > > > Tommaso also sent a series a few months ago for the CRU from which I > > > collected the first two patches. > > > > > > Around it, I've reworked a bit the locking in the driver which is a b= it > > > coarse and causes lost of frames under heavy system load conditions. > > > > > > Along with these, bit of drive-by cometic changes here and there to > > > modernize the driver code. > > > > > > I've tested on V2H(P) but I've also modified the G2L IRQ handler, so = if > > > anyone could test on G2L and G3E it would be great! > > > > > > Signed-off-by: Jacopo Mondi > > > --- > > > Daniel Scally (1): > > > media: rzg2l-cru: Rework rzg2l_cru_fill_hw_slot() > > > > > > Jacopo Mondi (11): > > > media: rzg2l-cru: Modernize spin_lock usage with cleanup.h > > > media: rzg2l-cru: Use proper guard() in irq handler > > > media: rzg2l-cru: Remove locking from start/stop routines > > > media: rzg2l-cru: Do not use irqsave when not needed > > > media: rzg2l-cru: Remove wrong locking comment > > > media: rz2gl-cru: Introduce a spinlock for hw operations > > > media: rzg2l-cru: Split hw locking from buffers > > > media: rzg2l-cru: Manually track active slot number > > You beat me to it, I had a similar patch internally. > > Oh that's great, I wasn't sure how this was going to be received! > > > > > > media: rz2gl-cru: Return pending buffers in order > > > media: rzg2l-cru: Remove the 'state' variable > > > media: rzg2l-cru: Simplify irq return value handling > > > > > > Tommaso Merciai (2): > > > media: rzg2l-cru: Skip ICnMC configuration when ICnSVC is used > > > media: rzg2l-cru: Use only frame end interrupts > > > > > > .../platform/renesas/rzg2l-cru/rzg2l-cru-regs.h | 2 + > > > .../media/platform/renesas/rzg2l-cru/rzg2l-cru.h | 28 +- > > > .../media/platform/renesas/rzg2l-cru/rzg2l-video.c | 328 ++++++++---= ---------- > > > 3 files changed, 140 insertions(+), 218 deletions(-) > > > > I'll test these patches with ISP enabled next week. > > My testing platform is v2h with the ISP, if you have a G2L could you > maybe give it a spin there as I don't have any board with that SoC ? > Sure I will. Cheers, Prabhakar