From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8ABBB47ECD3 for ; Tue, 14 Jul 2026 15:42:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.221.52 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784043739; cv=pass; b=sx1WEkseLrJanQx1WoPVhvYvwYHeO/VrkjFZtpGUAyC1uiSGpd225it0lHqo4hmRtT42MO9hD8d0SPS/dne/bTP+JNlL4CBbsaLqnvbZfSEEtqKWyfupJiZ1aLsq8n+Sbvcwe+JR8kOe9I19fcEkpYv0WlO8jyY//DF4l4GEfgk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784043739; c=relaxed/simple; bh=sWqGyIl3Sy36dtoEqyN8K9IVF8mS5l6W67D4MCNUCJs=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=C3bsz5Gl2hL1vEyU8+AJrRryi16wmvTmjebwWYgzlJqchc7kfLlXg4Y1GvUwFoNhP7awUvinVXzSPZYSqvFAej3He5arFK1FXFfVa6S3O9je2lH2hClh3ZuAPiLecf+GCBPSTRRAQnkpVo50C+wcTyH2XQbs+61CKUBNR7J0HMk= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IoBF+bPu; arc=pass smtp.client-ip=209.85.221.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IoBF+bPu" Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-47de0093c42so940831f8f.3 for ; Tue, 14 Jul 2026 08:42:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1784043736; cv=none; d=google.com; s=arc-20260327; b=SR78CY1PtqQr1WggZOq3BEe6TLlr1tbX2qtqDJFMh2RDsaE8uEzYHf8dRHlVJ49i3I YPATDXi1YYfFcphi6x4xDL0HXKAEjIp68g4D4Bh+zoRxIcIpp9AaAyodAUzjIjR04HKZ w2tmGRMyAifUx9WcTQd8AlFSCEHhjgljcPgotYoa7wBMkRwzLsS8C6j/e/KnFAhXEpYu fzMiireo8Dd9wHGq/Hps5sb7SR+2vKoBFgvPhLl28Ti9We1yfIbH+AcszPnVp1vl0x61 mjYJgcCTbffPpFo0+1wZ0NrPEFiCH63hpBREybK3o5x9JkAiwh+gkl0WLy4JBDfjtqZU WLdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20260327; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=bFMwMWLTvMmruDXHajLVVzBdjpUaW16nai1w7KarYv0=; fh=r692H4gujidNYYHa8PUB9Xxj1fg+qyHF2+x45rcFv+k=; b=HXULNWiEGTKHphdP7KiNlcilcVKCnzqlAK1vZTgoCtWpzuD1z3l43mVYM1VTVCSDxK iodRp6h3bO6bTG/+8YDdJxzYPpsjJuypR9h35ay/9rGxh0x7CyRzg/iTlK6uN9+g5cCb UMDu30amOZ/zGnZPcx8XdJdbbRoxmGhF5cr62m1g7F/aCkQhjlLsesmo4UbM0dAKp9XQ EWsm5zTJ90idgDjylu8pp3icau0vCkb5YaJGKTHC+MroKyakfDGFhqfxZRlfJeH+W7ox zL+rxxvLjqNzG/2MvfffQ0JOiCs1QUeN4kJbJrCdnMOidF1oTOdGJaRBPNFXZjVm5Z9P fcIg==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784043736; x=1784648536; darn=vger.kernel.org; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:from:to:cc:subject :date:message-id:reply-to:content-type; bh=bFMwMWLTvMmruDXHajLVVzBdjpUaW16nai1w7KarYv0=; b=IoBF+bPua6+u9KqI4AgZGFAoautr7lOViMlTn/lj3EKnMIvkczf8wve8jB/4xq7hTd k6g3YLbSpCKtUo7VbcXidr+1bcyO93JJpT2pHudYAIGYHB+sVgzoF0+3hlbsx9WjSR3L xPn2H4NL0XjnJyafQXzCovZTE0LZ8mHlB6YKhF5Lw2KtDwYYmuVjvroUZ0prtQpmDN87 eV5nH0qO1sUOCmrf1YEYDtI1Apm3kwOBatkDWEnWgd5xdUPrzRLUXd9Hr0ravlpxBAdb XNmohH8t+XvX7rDOpO2Jf68ER4yVpzb4qSQHjexXDb3CG+4bCwOxGcv6GFKKCwunyMkr l96g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784043736; x=1784648536; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=bFMwMWLTvMmruDXHajLVVzBdjpUaW16nai1w7KarYv0=; b=p10mbP+O+VztHeIa6xmgIc5kW73lfXACloXYzQozTSqABJ6KVtNew80s1lKEgC+JgP zgmNRyeH39TLaJbCnUyTLT+PIxWpMI1lklQlzMhOFJCsBCQMwf8ddeXxfl2TCzvGrYBF PEf+tecb+R94hy9guFiU6h1t3RvUbJcPb47yELi41UrSqctxT3QSfDv0M+OlS94XUg4G QOWqmPJ6pSWA1IcHwbQjZgW0w+LLyTEERJ0k4D0iCA1GMYohxF4vfDzJlc2cm50WpS4D 1pTXYfCvocYFvunXzbVU+A7FFFWl8uO1ZSlBb6wi4TzNL2z1Bv/C3EJKU9QVpsZJlptg peLw== X-Forwarded-Encrypted: i=1; AHgh+RrSPH8R2kj9wpx9zdjWj7BA+pvf0zVj30sVROLj7l1OzgZXN8meS7xM/QUTi1Z9XaSyMmyy23JQiuYhlaA=@vger.kernel.org X-Gm-Message-State: AOJu0Yxjc7CMwX+4zsNrzRhhcqKCZ3Lz95ymLHiAiOiVdkdgeqO500o/ oswlRlRuuoPv9FmUoahM/AGPr3nn5TAyUesPqzgQi184fAZUY0YXxkI7ieZAODpzlX6JcxtQFmX ee7La+bQcAmAGHs5LakOIGqB8cWKK3+Y= X-Gm-Gg: AfdE7cmxU2N8kwcaGnYEktv9KXR1EK29OKmmq9bgdYC3eRzd4NoP155RKxuxgu4jlHl URZOoQk1T51FwXk/AtXn1+9rIf9zsgR7OHwMJQBIy1P8VMGS5gLjqQVl+qi8vq524H/unrRPJ6F Vnu1xm6DKXyILqklBFZEfWy4aW/+fv1AzQVUchrKLf4LQ4ntOaCZe3ltsdpH6GZZQ5NjzNGk3bQ eFyEcV9h+/4FmzQ/xEKN41208pwjiFM++I4LHLp5YSFHYYbeyZNYUY7irHPM4pyuoB4rl+wzxJz O/Zf796QAc0TaY6tgYbjyxQ4imo8z/nlRuyBl6jFs4A88tymENSeMYWALSA= X-Received: by 2002:a05:6000:2601:b0:473:1ccc:15be with SMTP id ffacd0b85a97d-47f2dcf8b2bmr16217773f8f.39.1784043735618; Tue, 14 Jul 2026 08:42:15 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260702160457.1884345-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20260702160457.1884345-3-prabhakar.mahadev-lad.rj@bp.renesas.com> <46cfa874bd2ce4b6189606ae391e24833c802391.camel@pengutronix.de> In-Reply-To: <46cfa874bd2ce4b6189606ae391e24833c802391.camel@pengutronix.de> From: "Lad, Prabhakar" Date: Tue, 14 Jul 2026 16:41:49 +0100 X-Gm-Features: AUfX_myzFRk5zyRcC-DRg9lzaLxRzPGGbIhkzzOcp4mfT2S7yAzLBGupnIfXxos Message-ID: Subject: Re: [PATCH 2/3] watchdog: rzv2h: Convert WDTDCR handling to regmap To: Philipp Zabel Cc: Wim Van Sebroeck , Guenter Roeck , Geert Uytterhoeven , linux-watchdog@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Prabhakar , Biju Das , Fabrizio Castro , Lad Prabhakar Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Philipp, Thank you for the review. On Fri, Jul 3, 2026 at 8:35=E2=80=AFAM Philipp Zabel wrote: > > On Do, 2026-07-02 at 17:04 +0100, Prabhakar wrote: > > From: Lad Prabhakar > > > > Convert the WDTDCR register access from raw readl/writel variants over = to > > the regmap framework using devm_regmap_init_mmio(). > > > > This conversion serves as a preparatory refactoring step. It allows the > > driver to subsequently support syscon-based system controllers natively > > by passing along alternative regmap handles without forcing messy > > architectural branching at runtime. > > > > Signed-off-by: Lad Prabhakar > > --- > > drivers/watchdog/rzv2h_wdt.c | 83 +++++++++++++++++++++++++----------- > > 1 file changed, 57 insertions(+), 26 deletions(-) > > > > diff --git a/drivers/watchdog/rzv2h_wdt.c b/drivers/watchdog/rzv2h_wdt.= c > > index e9545b8f5fd0..d0b38450cc32 100644 > > --- a/drivers/watchdog/rzv2h_wdt.c > > +++ b/drivers/watchdog/rzv2h_wdt.c > > @@ -12,6 +12,7 @@ > > #include > > #include > > #include > > +#include > > #include > > #include > > #include > > @@ -67,7 +68,7 @@ struct rzv2h_of_data { > > > > struct rzv2h_wdt_priv { > > void __iomem *base; > > - void __iomem *wdtdcr; > > + struct regmap *wdtdcr_regmap; > > struct clk *pclk; > > struct clk *oscclk; > > struct reset_control *rstc; > > @@ -89,26 +90,20 @@ static int rzv2h_wdt_ping(struct watchdog_device *w= dev) > > return 0; > > } > > > > -static void rzt2h_wdt_wdtdcr_count_ctrl(struct rzv2h_wdt_priv *priv, b= ool start) > > +static int rzt2h_wdt_wdtdcr_count_ctrl(struct rzv2h_wdt_priv *priv, bo= ol start) > > { > > - u32 reg =3D readl(priv->wdtdcr + WDTDCR); > > - > > - if (start) > > - reg &=3D ~WDTDCR_WDTSTOPCTRL; > > - else > > - reg |=3D WDTDCR_WDTSTOPCTRL; > > - > > - writel(reg, priv->wdtdcr + WDTDCR); > > + return regmap_update_bits(priv->wdtdcr_regmap, WDTDCR, WDTDCR_WDT= STOPCTRL, > > + start ? 0 : WDTDCR_WDTSTOPCTRL); > > } > > I would drop this helper function and just call regmap_set/clear_bits() > directly in rzt2h_wdt_wdtdcr_count_stop/start(). > Ok, I will update as suggested and send a v2. Cheers, Prabhakar