From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753030Ab1HPVkg (ORCPT ); Tue, 16 Aug 2011 17:40:36 -0400 Received: from mail-qy0-f174.google.com ([209.85.216.174]:43354 "EHLO mail-qy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751465Ab1HPVkf (ORCPT ); Tue, 16 Aug 2011 17:40:35 -0400 MIME-Version: 1.0 In-Reply-To: References: <1313454275-5604-1-git-send-email-me@akshayjoshi.com> <1313454275-5604-4-git-send-email-me@akshayjoshi.com> From: =?ISO-8859-1?Q?G=E1bor_Stefanik?= Date: Tue, 16 Aug 2011 23:40:15 +0200 Message-ID: Subject: Re: [PATCH 4/9] Staging: Winbond: Convert C99 style comments in Winbond. To: Pekka Enberg Cc: Akshay Joshi , Pavel Machek , Greg Kroah-Hartman , Karthigan Srinivasan , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id p7GLemnv031344 2011/8/16 Gbor Stefanik : > 2011/8/16 Pekka Enberg : >> 2011/8/16 Gbor Stefanik : >>>> - >>>> -//==================================== >>>> -// Internal variable for module >>>> -//==================================== >>>> +/*============================================================================ >>>> +/* wb35rx.h -- >>>> +/*============================================================================ >>> >>> I'm pretty sure this is not an accepted kernel comment style. >> >> What's the problem? I think it's OK for this particular patch. >> > > The comments are not even valid C. The only reason why they do not > break is that they are immediately followed by another, > correctly-formatted (but separate) comment. BTW, my suggested style here is the following: /*============================================================================ * wb35rx.h -- *============================================================================*/ > > -- > Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-) > -- Vista: [V]iruses, [I]ntruders, [S]pyware, [T]rojans and [A]dware. :-) {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I