From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12864C433DB for ; Fri, 5 Feb 2021 18:55:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC8FF64F19 for ; Fri, 5 Feb 2021 18:55:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233278AbhBERNA (ORCPT ); Fri, 5 Feb 2021 12:13:00 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233430AbhBERLj (ORCPT ); Fri, 5 Feb 2021 12:11:39 -0500 Received: from mail-il1-x129.google.com (mail-il1-x129.google.com [IPv6:2607:f8b0:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 52DBDC06174A; Fri, 5 Feb 2021 10:53:21 -0800 (PST) Received: by mail-il1-x129.google.com with SMTP id m20so6730827ilj.13; Fri, 05 Feb 2021 10:53:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:reply-to:from:date:message-id :subject:to:cc; bh=ZDIhkwmamVtz0wuMPIIpYtUF8wR1X+XAeF/EiCAzfb8=; b=VWWCT9Q5AKrcDL5PVBeLA8gG/xqcVTQbg5QzXDTahbWfTpWkeb2QHNT4hjywWJ1QTU X1Ct6mxMKOkbnEFwl0nA3X0RubeIqT8B/zb9Jj1k8u+FGVTEac2laMjLTRtBSpnkGHVS M+KT01HYUeFKa2QJAPtJ4B7KxK+4BEUBgamMVlrBhoKHYK3P4sGNwgEHW+Gvjw0Mpdne luDE5lnHqqyRXZLIKsKj9mDAEb0jM2570to26/cVowdYz3P3xFb8yfSMVIRjcjKBcyrJ TQB487pi7/ThTZykfhRsN0yH9txadAsApA5CXhG5bAV2eA2O16qYJmLjmE+rGLdpXxzH kFIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:reply-to :from:date:message-id:subject:to:cc; bh=ZDIhkwmamVtz0wuMPIIpYtUF8wR1X+XAeF/EiCAzfb8=; b=H5I/k2hnqoW08tWiVycUl6N3G3qF+ppQWkrt2L1+Fnp90q+Q8C2AjqouhZGOtp65NX /rQJID6BbyBYZnprHYSAMuLt9K01XnG0XkihY+Nyb3Ujhp5nMdNY3ADvdOqcfHcOQ6tH bs8c2RO7uOAmv4pBlIBXQCnJzl21XXH4s5jF8t4NRrupbH0/lMagKhcYklTVOQE1rKAU xhghka62XN4RH+vcS+cZTxtk8yp3KmDDAcKFPkxCJlhDk4BLKpw1bwwBb7qS4mwNYcSa MEDdfVwmEe2nptOlkZobH6kF8T2kDUABz5ty4FvoqK9j3gHcSfCM4vfVqHNoX5lnsHfE E+Rw== X-Gm-Message-State: AOAM531mebubzYtTj6wL53P3lGBRVCLTQZ+3KHsJzdu4Phv36iyE9tUL cj44MZfsU5oYb+dbjMvgo2CgJH8y7NSEpEHP3x0= X-Google-Smtp-Source: ABdhPJw3lcimDlouJYFMLcNxZxDiz2srh8w+hWL0k7GfGg0ihB/2s0YltSEkff4FoHXayjAiTuO8qu8H5S8ClKhisgg= X-Received: by 2002:a92:58ce:: with SMTP id z75mr5264348ilf.209.1612551200735; Fri, 05 Feb 2021 10:53:20 -0800 (PST) MIME-Version: 1.0 References: <20210204220741.GA920417@kernel.org> <20210205152823.GD920417@kernel.org> In-Reply-To: Reply-To: sedat.dilek@gmail.com From: Sedat Dilek Date: Fri, 5 Feb 2021 19:53:09 +0100 Message-ID: Subject: Re: ERROR: INT DW_ATE_unsigned_1 Error emitting BTF type To: Arnaldo Carvalho de Melo Cc: dwarves@vger.kernel.org, Linux Kernel Mailing List , bpf@vger.kernel.org, Jiri Olsa , Jan Engelhardt , Domenico Andreoli , Matthias Schwarzott , Andrii Nakryiko , Yonghong Song , Mark Wieelard , Paul Moore , Ondrej Mosnacek , =?UTF-8?Q?Daniel_P=2E_Berrang=C3=A9?= , Tom Stellard Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 5, 2021 at 6:48 PM Sedat Dilek wrote: > > On Fri, Feb 5, 2021 at 4:28 PM Arnaldo Carvalho de Melo > wrote: > > > > Em Fri, Feb 05, 2021 at 04:23:59PM +0100, Sedat Dilek escreveu: > > > On Fri, Feb 5, 2021 at 3:41 PM Sedat Dilek wrote: > > > > > > > > On Fri, Feb 5, 2021 at 3:37 PM Sedat Dilek wrote: > > > > > > > > > > Hi, > > > > > > > > > > when building with pahole v1.20 and binutils v2.35.2 plus Clang > > > > > v12.0.0-rc1 and DWARF-v5 I see: > > > > > ... > > > > > + info BTF .btf.vmlinux.bin.o > > > > > + [ != silent_ ] > > > > > + printf %-7s %s\n BTF .btf.vmlinux.bin.o > > > > > BTF .btf.vmlinux.bin.o > > > > > + LLVM_OBJCOPY=/opt/binutils/bin/objcopy /opt/pahole/bin/pahole -J > > > > > .tmp_vmlinux.btf > > > > > [115] INT DW_ATE_unsigned_1 Error emitting BTF type > > > > > Encountered error while encoding BTF. > > > > > > > > Grepping the pahole sources: > > > > > > > > $ git grep DW_ATE > > > > dwarf_loader.c: bt->is_bool = encoding == DW_ATE_boolean; > > > > dwarf_loader.c: bt->is_signed = encoding == DW_ATE_signed; > > > > > > > > Missing DW_ATE_unsigned encoding? > > > > > > > > > > Checked the LLVM sources: > > > > > > clang/lib/CodeGen/CGDebugInfo.cpp: Encoding = > > > llvm::dwarf::DW_ATE_unsigned_char; > > > clang/lib/CodeGen/CGDebugInfo.cpp: Encoding = llvm::dwarf::DW_ATE_unsigned; > > > clang/lib/CodeGen/CGDebugInfo.cpp: Encoding = > > > llvm::dwarf::DW_ATE_unsigned_fixed; > > > clang/lib/CodeGen/CGDebugInfo.cpp: > > > ? llvm::dwarf::DW_ATE_unsigned > > > ... > > > lld/test/wasm/debuginfo.test:CHECK-NEXT: DW_AT_encoding > > > (DW_ATE_unsigned) > > > > > > So, I will switch from GNU ld.bfd v2.35.2 to LLD-12. > > > > Thanks for the research, probably your conclusion is correct, can you go > > the next step and add that part and check if the end result is the > > expected one? > > > > Still building... > > Can you give me a hand on what has to be changed in dwarves/pahole? > > I guess switching from ld.bfd to ld.lld will show the same ERROR. > This builds successfully - untested: $ git diff diff --git a/btf_loader.c b/btf_loader.c index ec286f413f36..a39edd3362db 100644 --- a/btf_loader.c +++ b/btf_loader.c @@ -107,6 +107,7 @@ static struct base_type *base_type__new(strings_t name, uint32_t attrs, bt->bit_size = size; bt->is_signed = attrs & BTF_INT_SIGNED; bt->is_bool = attrs & BTF_INT_BOOL; + bt->is_unsigned = attrs & BTF_INT_UNSIGNED; bt->name_has_encoding = false; bt->float_type = float_type; } diff --git a/ctf.h b/ctf.h index 25b79892bde3..9e47c3c74677 100644 --- a/ctf.h +++ b/ctf.h @@ -100,6 +100,7 @@ struct ctf_full_type { #define CTF_TYPE_INT_CHAR 0x2 #define CTF_TYPE_INT_BOOL 0x4 #define CTF_TYPE_INT_VARARGS 0x8 +#define CTF_TYPE_INT_UNSIGNED 0x16 #define CTF_TYPE_FP_ATTRS(VAL) ((VAL) >> 24) #define CTF_TYPE_FP_OFFSET(VAL) (((VAL) >> 16) & 0xff) diff --git a/dwarf_loader.c b/dwarf_loader.c index b73d7867e1e6..79d40f183c24 100644 --- a/dwarf_loader.c +++ b/dwarf_loader.c @@ -473,6 +473,7 @@ static struct base_type *base_type__new(Dwarf_Die *die, struct cu *cu) bt->is_bool = encoding == DW_ATE_boolean; bt->is_signed = encoding == DW_ATE_signed; bt->is_varargs = false; + bt->is_unsigned = encoding == DW_ATE_unsigned; bt->name_has_encoding = true; } diff --git a/dwarves.h b/dwarves.h index 98caf1abc54d..edf32d2e6f80 100644 --- a/dwarves.h +++ b/dwarves.h @@ -1261,6 +1261,7 @@ struct base_type { uint8_t is_signed:1; uint8_t is_bool:1; uint8_t is_varargs:1; + uint8_t is_unsigned:1; uint8_t float_type:4; }; diff --git a/lib/bpf b/lib/bpf --- a/lib/bpf +++ b/lib/bpf @@ -1 +1 @@ -Subproject commit 5af3d86b5a2c5fecdc3ab83822d083edd32b4396 +Subproject commit 5af3d86b5a2c5fecdc3ab83822d083edd32b4396-dirty diff --git a/libbtf.c b/libbtf.c index 9f7628304495..a0661a7bbed9 100644 --- a/libbtf.c +++ b/libbtf.c @@ -247,6 +247,8 @@ static const char * btf_elf__int_encoding_str(uint8_t encoding) return "CHAR"; else if (encoding == BTF_INT_BOOL) return "BOOL"; + else if (encoding == BTF_INT_UNSIGNED) + return "UNSIGNED"; else return "UNKN"; } @@ -379,6 +381,8 @@ int32_t btf_elf__add_base_type(struct btf_elf *btfe, const struct base_type *bt, encoding = BTF_INT_SIGNED; } else if (bt->is_bool) { encoding = BTF_INT_BOOL; + } else if (bt->is_unsigned) { + encoding = BTF_INT_UNSIGNED; } else if (bt->float_type) { fprintf(stderr, "float_type is not supported\n"); return -1; Additionally - I cannot see it with `git diff`: [ lib/bpf/include/uapi/linux/btf.h ] /* Attributes stored in the BTF_INT_ENCODING */ #define BTF_INT_SIGNED (1 << 0) #define BTF_INT_CHAR (1 << 1) #define BTF_INT_BOOL (1 << 2) #define BTF_INT_UNSIGNED (1 << 3) Comments? - Sedat -