Re: [PATCH] regulator: tps6507x - add missing platform_set_drvdata in tps6507x_pmic_probe

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

On 9 Aug 2010, at 04:27, Axel Lin <axel.lin@gmail.com> wrote:

> We should call platform_set_drvdata() before calling platform_get_drvdata().
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/regulator/tps6507x-regulator.c |    2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/regulator/tps6507x-regulator.c b/drivers/regulator/tps6507x-regulator.c
> index 8152d65..fbe21f7 100644
> --- a/drivers/regulator/tps6507x-regulator.c
> +++ b/drivers/regulator/tps6507x-regulator.c
> @@ -614,6 +614,7 @@ int tps6507x_pmic_probe(struct platform_device *pdev)
>  	}
> 
>  	tps6507x_dev->pmic = tps;
> +	platform_set_drvdata(pdev, tps6507x_dev);
> 
>  	return 0;
> 
> @@ -640,6 +641,7 @@ static int __devexit tps6507x_pmic_remove(struct platform_device *pdev)
>  	for (i = 0; i < TPS6507X_NUM_REGULATOR; i++)
>  		regulator_unregister(tps->rdev[i]);
> 
> +	platform_set_drvdata(pdev, NULL);
>  	kfree(tps);

This is not needed - we're unbinding the driver so should no longer be looking at the driver data.

> 
>  	return 0;
> -- 
> 1.5.4.3
> 
> 
>