From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 739902690F9 for ; Thu, 12 Mar 2026 06:54:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.214.170 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773298483; cv=pass; b=YGneD2QvBoUpUbNj00KmPFf9Nd05vCG/zTL6uLRa9sHUJukJntexuHxaO46EHxUmAzYqslL81id4WjM1EYmkXOF527aUMRvjh/hRJcAfjEl/XvusJmwgocfvBQj74fukyqiD252CdDLs5YmDH/+uf00ns9B3DMe03R/2/5nYUoo= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773298483; c=relaxed/simple; bh=Be+DWSJxXaWd2h3oqz8Y4RWZIPdhRhtU2hbnzD1aDuc=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=r6+PhXlOwpyyd/4qqw+i0QKHAZdfMNVNqERxd1kmbBhr+e7sNaKc3nQOZivs0EJrufDtLAGphx6gSBo7xv6yb9Mv/9rZrdPxLmKz7/tLScoYEgaI3BTMzRkYX6wuCVfglRrh0lkwHS+/Yx5M7+CLDL5FB1QgdeSa8JjYMrM6ay0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BB1a3dta; arc=pass smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BB1a3dta" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2aec4a71ef9so553725ad.3 for ; Wed, 11 Mar 2026 23:54:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1773298482; cv=none; d=google.com; s=arc-20240605; b=KAEVBwfNwf78IUimAgycGDGQVYjmS4N+FapuA0Lfpf3s2tlwA52K5pmLB3q3x7gWzT bPSC6GsW2zlH8GE//KSTpCTzaXu4pSDEmt8yh9Ro2OsZ+6ZCIK+2d0tyKZ4DYc2Ct91/ 91feKEogc63yYkz1tw1atqEjAVy/47tHgYrnnyoG3qg0U5jsaM2uSjnEAdYu5E4jwJEK iNtTzYSvNS23n/wEVUAZOuRm4TPowMzIlozJkNGSAWvPH4vU7hqO4QJELQ09X8IwSi6t M5QnDxW4Ii+RUxg79VAT7YnU5SeHzXH60jl54iwG8Fp8lIwMTtYgfwcOytSCTIYEUbgA y+/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=wR3lTNQ8vtyMXtspr3IFVrmuZOG8EcAD0Ru8ues67mI=; fh=GV6Et6Q/A4uZA/kXv1b6EaiZXxT8di04PeuAZH4mt90=; b=hy4KS9bjpTG2eGdWe2t0gTM2HjX+/uYjvStaqR4vYDQF3uyJYjl0JhF4VPz+J6EEPS fn3ddir9hMHgkJBiEKtu8QDPkGekj+EPC2sVcP+AGqEogiAwq6zMfdlEgfGViAhpaMDR wFY+Y7IN8U9ReU4IpwvFFUry53GOUAIY3qSdDtHCf73KsZgXsWfcl902aEBpKHNRLEFh GYDOI+7YWK0prCIKqOslomYz5+viPKhAS6r4LxuXOffwqZ/mPBu2s41md96RzH9+qp0D Dl2t72ubh8AakWPhAhIohDEgK4xn/fLvgPkRvTgnOiww4WjmWfNnLLRKLewAbUipwoOn jQNA==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1773298482; x=1773903282; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=wR3lTNQ8vtyMXtspr3IFVrmuZOG8EcAD0Ru8ues67mI=; b=BB1a3dtaBbvfX0PHWEbSLxj5Z8nWXtko2AtUBeuAsejvadhyUDRihm4S+L9JrWGPUF uEfAdTqmz8gd+Hv1+2kafTH+dmMvaRcfPoNXalnzX7GieT/ivk894+/n3A8TKPB01qyS oQyyodw4ctIifUtAZe31n2PxislbTwvms/ZoZcsoZJ85ZqN3q1xH6yoYldy3Z6Tv68iF PQ/V/8FJgJDZCBM5M0/x5seF4W4hqsWoXq5ENYYud7Sc4aaGKV0EciOHQcuITYq/R8iW lRXGn8QjRDuovjThyK0IFgonc6RySoPd/LA4QATe5d+apxo1hYrfL70jxz2SK0BBCeUY robw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773298482; x=1773903282; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=wR3lTNQ8vtyMXtspr3IFVrmuZOG8EcAD0Ru8ues67mI=; b=UBbZDjdEoaUMA9U33AkSSyMdA3yB/26m8GS0KDw3vTD4/pd2kK2eY2NrxC4eHkGR3K UAnisv2uhzXnNNObCLXv16X4wBc0Rpg84RTsf0wEISUmLh0FAJmK6wjzn8XZ0K9g2D+K Am8jEyQbibv9jo32EUCEZSVxdOJNg+TV7RSOG5rLfo9V2OWmoozNIxP2CCjL8NzqDe7H PBgXAhRd1+GMC8KaUM3yYnoPnl4EeIWERF5sYjbd09TzQLuuUcrI/X7LEwLsHLHkXeO0 BefGOZoIgqT2FZgvY55t4hNXIV8pZRFTMjaSmAbMTbhIhUNDNBvMSh5lCVQlhjHIll1h 5AWQ== X-Forwarded-Encrypted: i=1; AJvYcCWu92KrRjoNdBNg8sQ8z4fYxQ2jkQgHhQ7T+2mHJEEZ/09KtrunF1H0sycreX/aalWiRPBMCPXx2dyuPF8=@vger.kernel.org X-Gm-Message-State: AOJu0YyrxPhKh4jvgphXo1PxZfdWQRxpcSA3cRqu9rzIkTIAGT02Y4sX NbHFoO+OQGDOlAQHBZ1kFZDaV539kS67Da5OMdXUD9FU7PNGRLbu0IXewcIaOE39L5Jqcsbv0W1 JwFCM+J+eVyLV6VxGdQ/sGvaz5DUSGDQ= X-Gm-Gg: ATEYQzwwRIZXnd5xtFMJA3Iz6mwACIJoGqVGN0JLW7BHUmUCMdBY19F6QXc+23uPMy6 QkCYZcguB9+U499ImYUPNep9GyeipbbMUh30AykXsdDY96eYwcLBJfJFs2wq0rqz0FyzDAR1ZH0 UYUfE6yqhNhnvLSA3hEdDdrL+T5XWE12hNcONOGyrdYCB8Tn9WedjXAJq3NSjo6VSVV9Gw2nJZT F+477srX+rXajm/gkfSWz1YFYyUhtARXQuwqn5DkQGaiRHIqkTvx5yBDb4JrdEuIyowaurxW4rP 7QrtESM= X-Received: by 2002:a17:902:d50a:b0:2ae:5426:da49 with SMTP id d9443c01a7336-2aeae88defcmr55291865ad.34.1773298481850; Wed, 11 Mar 2026 23:54:41 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260312034912.4007057-1-shengjiu.wang@nxp.com> <20260312034912.4007057-2-shengjiu.wang@nxp.com> In-Reply-To: From: Shengjiu Wang Date: Thu, 12 Mar 2026 14:54:24 +0800 X-Gm-Features: AaiRm51CB2PtkWtwvXXWHfX6nfM3hu2hh6z8jZbSHIx7_tLXIh1Snw9k9jw4XlQ Message-ID: Subject: Re: [PATCH 1/4] arm64: dts: imx952: Add audio device nodes To: Daniel Baluta Cc: Shengjiu Wang , robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, Frank.Li@nxp.com, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Mar 12, 2026 at 2:40=E2=80=AFPM Daniel Baluta wrote: > > On 3/12/26 05:49, Shengjiu Wang wrote: > > Add audio device nodes, include SAI, MICFIL, ASRC, Audio Mixer. > > > > Signed-off-by: Shengjiu Wang > > --- > > arch/arm64/boot/dts/freescale/imx952.dtsi | 199 ++++++++++++++++++++++ > > 1 file changed, 199 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx952.dtsi b/arch/arm64/boo= t/dts/freescale/imx952.dtsi > > index 0f86b5626cdd..5787c12e788f 100644 > > --- a/arch/arm64/boot/dts/freescale/imx952.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx952.dtsi > > @@ -823,6 +823,156 @@ usdhc3: mmc@42c40000 { > > }; > > }; > > > > + aips5: bus@43000000 { > > + compatible =3D "fsl,aips-bus", "simple-bus"; > > + reg =3D <0 0x43000000 0 0x800000>; > > + #address-cells =3D <1>; > > + #size-cells =3D <1>; > > + ranges =3D <0x43000000 0x0 0x43000000 0x800000>; > > + > > + asrc1: asrc@43000000 { > > + compatible =3D "fsl,imx952-asrc"; > > + reg =3D <0x43000000 0x10000>; > > + interrupts =3D ; > > + clocks =3D <&scmi_clk IMX952_CLK_BUSWAKEU= P>, > > + <&scmi_clk IMX952_CLK_BUSWAKEUP>= , > > + <&scmi_clk IMX952_CLK_ASRC1>, > > + <&scmi_clk IMX952_CLK_ASRC2>, > > + <&clk_dummy>, > > + <&clk_dummy>, > > + <&clk_dummy>, > > + <&clk_dummy>, > > + <&clk_dummy>, > > + <&clk_dummy>, > > + <&clk_dummy>, > > + <&clk_dummy>, > > + <&clk_dummy>, > > + <&clk_dummy>, > > + <&clk_dummy>, > > + <&clk_dummy>, > > + <&clk_dummy>, > > + <&clk_dummy>, > > + <&clk_dummy>; > > + clock-names =3D "mem", "ipg", > > + "asrck_0", "asrck_1", "asrc= k_2", "asrck_3", > > + "asrck_4", "asrck_5", "asrc= k_6", "asrck_7", > > + "asrck_8", "asrck_9", "asrc= k_a", "asrck_b", > > + "asrck_c", "asrck_d", "asrc= k_e", "asrck_f", > > + "spba"; > > + dmas =3D <&edma2 97 0 0>, <&edma2 98 0 0>= , <&edma2 99 0 0>, > > + <&edma2 100 0 1>, <&edma2 101 0 1>= , <&edma2 102 0 1>; > > For consistency we should use symbolic macros for directions like you did= below. > Use FSL_EDMA_RX for rx direction and also introduce FSL_EDMA_TX for tx di= rection. Yes, should use FSL_EDMA_RX. But introduce FSL_EDMA_TX, it should be zero, FSL_EDMA_TX =3D 0. is it necessary to add it in include/dt-bindings/dma/fsl-edma.h? Best regards Shengjiu Wang > > > > + dma-names =3D "rxa", "rxb", "rxc", > > + "txa", "txb", "txc"; > > + #sound-dai-cells =3D <0>; > > + fsl,asrc-rate =3D <8000>; > > + fsl,asrc-width =3D <16>; > > + status =3D "disabled"; > > + }; > > > [...] > > > + sai3: sai@433e0000 { > > + compatible =3D "fsl,imx952-sai", "fsl,imx= 95-sai"; > > + reg =3D <0x433e0000 0x10000>; > > + interrupts =3D ; > > + clocks =3D <&scmi_clk IMX952_CLK_BUSWAKEU= P>, <&clk_dummy>, > > + <&scmi_clk IMX952_CLK_SAI3>, <&c= lk_dummy>, > > + <&clk_dummy>; > > + clock-names =3D "bus", "mclk0", "mclk1", = "mclk2", "mclk3"; > > + dmas =3D <&edma2 61 0 FSL_EDMA_RX>, <&edm= a2 60 0 0>; > As I said we should introduce FSL_EDMA_TX and this will read as: > > dmas =3D <&edma2 61 0 FSL_EDMA_RX>, <&edma2 60 0 FSL_EDMA_TX>; > > Otherwise, looks good to me. > > > >