From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD4D437475A for ; Thu, 29 Jan 2026 09:37:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.215.182 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769679468; cv=pass; b=BhdjfPYDIcOKIhvKNkPldDo+boY+rRC2FD88dW4xz+oKhzMgrY1uLVSAXBn9cn0n8L1DEQd2JqNM7H97k41K2UwaE7fio/AT/jCR0RC3WcS8ESYU+x431rsUzB8V6RPVfBYNsj8P45ElVFQaZ7MUkrELoxCpRAHuZ3usRqnRIaM= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769679468; c=relaxed/simple; bh=zcM05kpdQ+n6MUDgSMAvFhhgb3WvkgEVy1gJ+6lV2Lk=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=MSHpHaLlTCWLlnF31wXmPXlmy189lw9baBx7P5y9rvKDX8lJBDtn3S3Ed0OUAwGjD7HSl8YcBt2+AD/4ekMXqa1nnJlQogDcmps9TR/pWgzSqI5diDPuef1fuk7k8kqEVcJTLDRgG4nXOeUqeZG5IS6dKBZtkI2HbnX4AWINwtA= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IupRH+bC; arc=pass smtp.client-ip=209.85.215.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IupRH+bC" Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-c06cb8004e8so308781a12.0 for ; Thu, 29 Jan 2026 01:37:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1769679467; cv=none; d=google.com; s=arc-20240605; b=Hhg5wIuvP4bVb00HJTwiZmvLZRi9wGBGjYqr7y2BBkPInZ16veHCBSllJb+EaoqVb+ guY0BrFSc2scU/UBC1DfAGkn6wU47Kzey9tjZlf7/zJWTulkLQo/VEuvQ2mnXs3zb9UW B/fSpAiTCOhe0MabzECFUXA3rMpmxsLY3bdVlXE1JyEX0NUWc6/ECs5jVGQ6iqISYqs3 oHIDd+CTvh2gHPINm8rcGg/nOIujEwUFfmbMHzgJ/BeZqWuklXwJJg+evrzHxMf5FG34 1O+bP96XJHE/Abf+xTRAIY0XRhOeQqzUzHyxlGG3fdA37Nu2QSV5VennMoMaV1lSpiiD uK3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=4lU8GWlv78rS676V94HHH4zs90Fwj2GtCQjzXirgDFE=; fh=dmuypj6QVUBA9DpRlMQnHZQoCJEfzI0sZuN/86GW/cA=; b=Yqef7HP2f43sqYKutrM3+Q8WhXfIaD4X8/KmwrAJ9t74Fzucgb4peBwDIIu8q2fgb0 J3Xpp1lsrlYDMDBppQqSZpJvRZz/unJutfcRgjlG0TcfYUrh5m3kpWPEKARUcjSiuhiw sIbIBl/UlldkUbIvR5MkENWrOh5LG5IQIpGI3L6+KpH1nJSxIg0ttp0zkgyQH8RHOB7J of6hrk7DL/+e0peqqKW09KN+pSxpocKFPllKKXfHIJZNdsSaco8Or4m/SxyltNW/4vRA jXj7S0K8PFRYxldZ3qJZ5Y4Z6sGWfVeyGjbxDbHiqOeDCtRYy3e7RIO13mxRCHMwP146 T1bA==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769679467; x=1770284267; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4lU8GWlv78rS676V94HHH4zs90Fwj2GtCQjzXirgDFE=; b=IupRH+bC7ADXceaiuWcRMEqTYyuuwhAxQTdXZfoClNcyIngWwnlSGH2eW9R3dJQMLt uQODnWTkt70DBRonwuIBb/MFzzyvD1uB16tc3+Nx62ewnMX0WJrQ2rFDHQKrwaOhp4EU BeJ64piEsAKb3icYfW0n4PT89JJKN5cf4RCqyk1tN2V7GnetIXofufD1U+D4EHDLJ70C xKz6qeWdVTxARg2uFUWVh/lVzMUZK5oSSOKvjCoufsEagm30kjvQK7GAp9gR+a+qbeud WnAE8y1uZbKzMOFTvFwQiw/cMds4vpozYFE4TkkF9SkA2aV8kB7wnSFMY3HIYOVbBGyo w39g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769679467; x=1770284267; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4lU8GWlv78rS676V94HHH4zs90Fwj2GtCQjzXirgDFE=; b=RJnOMivc0/+dxf/2KXwFhXTxcM3szmQk1qRKLv5pAdPAZG3nLAUOmLL7b78BWtDL75 SJ3pObuvNAAAyItJrvhjWEV/PKQgq+kuftg1JpaF8FzZV6KM104PefzGvVNLv0gsOytZ 19a2TvaXFZ6nsWvxJAAtHLpN1/b4uZppvitlG7I2sN2HjjLhFGUOciPn4nuziEydl1QE h7Cxri2bkYOb4DzxTFzL/jPSzpjbGNhGRkdxulWU6ocWZopjhEmLHTf92BT/WAx/K/ee tQbAQxuk0a6N64M2bUWjYEp4cbLv1HpZIi355FxAmTkK/mnf1z9WpzwquVsbGDCWgwm2 hUAw== X-Forwarded-Encrypted: i=1; AJvYcCX7ZA6jW0V5toEcROFy2Rks7oC1BVhiuTbS4RBjmL+4EgRIyNYUN0VdndR9N43RfKi9+QjhcgG5SjPrebY=@vger.kernel.org X-Gm-Message-State: AOJu0YwBj27QHHaWmZ/HQNJZaDAhD+sqQdebWv/ev6lFfmq3LGVLYbXW PDAWtIW0/ZmGRRoIAHiDUa+BRSn1AU4gHcBUVHUgfuG1GLyNQJcaehPaYx54paZUblVLW1XCptC HIDL+YQeJnYFMUrQtk8+6rPMedrY3+08= X-Gm-Gg: AZuq6aLum9DnRrQqV+KU0LmLYoV0DGRhKKoRjvUPamNSCucK4j5VSx/oK6razbc49OB CW5dMdCKWIIVgW47QVk1/19FgmYojjOS4GM5uIcTWWMxGK2z/02Cz/1BZ3IVG9aReRea0giZOem QXFAMw1vNnCdj7VRqUOVlM+5YhLcPrMGJx5Crc8ol2Xb8uBeDGo8lnyD646+NCLp3+qISLBn4t8 /3FJZWVXaIv2nsW40y9dXeTZ0BL6/YA9Ms8vaWvLztJ9stQAFqZQc2MsUzRRDsOjtaPGiY= X-Received: by 2002:a17:90b:1f8b:b0:352:c9c9:75b8 with SMTP id 98e67ed59e1d1-353feda27ddmr6746159a91.36.1769679466914; Thu, 29 Jan 2026 01:37:46 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260128071853.2602784-1-shengjiu.wang@nxp.com> <20260128071853.2602784-4-shengjiu.wang@nxp.com> <7e34b098-bdab-448e-a34a-02bdc643f700@oss.nxp.com> In-Reply-To: <7e34b098-bdab-448e-a34a-02bdc643f700@oss.nxp.com> From: Shengjiu Wang Date: Thu, 29 Jan 2026 17:37:35 +0800 X-Gm-Features: AZwV_QjhsaT3WGqHFWhY63rZWE_xfRO_5posf7-8hnrbY9543Mu3MY60Z30GXKk Message-ID: Subject: Re: [PATCH 3/3] ASoC: fsl_asrc_dma: allocate memory from dma device To: Daniel Baluta Cc: Shengjiu Wang , lgirdwood@gmail.com, broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Xiubo.Lee@gmail.com, nicoleotsuka@gmail.com, perex@perex.cz, tiwai@suse.com, linuxppc-dev@lists.ozlabs.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Jan 29, 2026 at 5:22=E2=80=AFPM Daniel Baluta wrote: > > On 1/28/26 09:18, Shengjiu Wang wrote: > > As the dma device may support dma-coherent property on the i.MX952, > > allocate memory from dma device to make asrc driver to be compatible wi= th > > such a case. > > > This commit message refers to imx952 but the change in the code apply to = all supported platforms > > So in not really clear what is the intention of it. The dma-coherent property is used to indicate a device is capable of coherent DMA operations. Which is applied to the EDMA device on i.MX952, in order to support such EDMA device, the memory is need to allocated from DMA device, The code change is compatible for non dma-coherent and dma-coherent dma dev= ices. > > Also, it is not clear why do you allocate a pair only to free it at the e= nd of the function. As the comment in the code says, it is to get the dma device handler for memory allocation . After that, it is freed. best regards Shengjiu wang > >