From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC30F5A788 for ; Mon, 3 Jun 2024 08:50:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717404605; cv=none; b=aCJKSkZk6+HR4ACT99oP1axy8DeNqpeBph8woX76P4m9lRvTPD19YGu6Oa2vxy7FPuPwOkSMpHuj+EFgYmYHQWbH55CDltcZcYnko7SwwhUmvTUu1U+OXkdJgw5Ow34AOf+XursU1qdUNDEm6PuqVagsE0kOxyQ9F3ChqoRWLn4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717404605; c=relaxed/simple; bh=dfoQFsA6SLL4wcUbcBXpinLax5A25U36hCg32xNjGxI=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=dnMdaGjlSwRRA1SWvJYEDX0X/VAX2Fzef158WbPnQHK3RaJeMUSeUPb3voNutj6tpvboaCTYNVhegFbbVHGLbJW7rilJqDmTExQitnyblN4b/kPnJDfOsa43yMq2AkKXLzkUQ+jLun1zLS4tzMW+QUpxWZv5yv3MHa1y3thzh88= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=RvLIL4y4; arc=none smtp.client-ip=209.85.219.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="RvLIL4y4" Received: by mail-yb1-f179.google.com with SMTP id 3f1490d57ef6-df78b040314so4217583276.0 for ; Mon, 03 Jun 2024 01:50:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1717404603; x=1718009403; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=TH62Yup3G9u8vLN8Ga3Ij8RqgPg+rX8ETtG6ob+WsZQ=; b=RvLIL4y4zBQ5prmsgP2CaA6A+uwEUtXRNc58oP1U+YicLPhc2aI5/s3KiTGSQwF7KK K5O/j5W6WDHKqyIQ9/84Rtgw8u0kCA8Z+ZQLgby5vkyme2OgNsFTK/99CTfYet79LxyL oJGv/fWzI2m1KmH8RQsneW0ppPQpAhr4Ov6D9BDE2b10cqty/2AhAq2sujraBY2tdxIs L3ycutcpTMv8BcLgdy5Y8NP01OcylZ6eJfRIktv7Th1+Ny5gCZ4yf6AJerVisOt9bIQN 2H4wdgM1xlXB3wG6n+4A4XNu+VQ8stqT/ZfcqTIf8hqb4OCMmQVvU8L2EdMV36TDzcg/ tQCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717404603; x=1718009403; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TH62Yup3G9u8vLN8Ga3Ij8RqgPg+rX8ETtG6ob+WsZQ=; b=lOQng70KCZGBEZ9jOH6+RLkFl5TL28aJML+g+z8h5LDHCs2qeBnIDxKh01UycGH8Ov QVPTyqfNqiXhpL4ueWb1BS9Pvo8IprPqIsySaOhJX2xBUXcvjTuY62QUtbKred0oZ0Uz QWANvg8b1o2e2PRBg25Kj169fv1WbIX3/KLaLCC/P3jNFPvC/xizf0dMvO32Qik8LuhZ 82rXLKblul2TFjSf22US/EYwFnU/0I5/VqUnKO2zjG3jULC9z9qKqz8vWahpLA8FoYf3 oNPk3qm1okxKc+33u2pg6cXdlOmlhKo7b7kjw+Jf0eIxNX+UZLT7eNr5tYC30zPxCkhu Xwvg== X-Forwarded-Encrypted: i=1; AJvYcCUaVqmgIjQcNfgN4QKIH9CV+PONx6KZMDEypS4utgDUFGLPxt55cx7kdC4d7MbXGCox4GaDSX7gYisL0nh55VvBb4YDQ1fkJi2StyMx X-Gm-Message-State: AOJu0Yy6TX/5C0Qx0blJRGI9yFflS9l46e4plKL3lJzOGScx9wFi7Gs2 z5dIJ/R2wYFvYuB+VZAU3UQOHIpiVzS7ZuZi0VSvMexdRVyIbevH6v2JO6VO5VYVqY8LBj8+ZIT 1lpqcwK6ZkKRtWCiSQhgfCn4qzTJz0AVcPa2QpZKIPU4nsnQ/ X-Google-Smtp-Source: AGHT+IF8k6LvzxBQXvPeOtqCn1OCAasXTKSxbvnfog6OJ7lM/2LaGW7ZCPHxo6bcXahe6A5T83BMVLsZ3/yavZ95yUg= X-Received: by 2002:a25:ab45:0:b0:de8:a770:4812 with SMTP id 3f1490d57ef6-dfa73db2ab8mr7409755276.40.1717404602753; Mon, 03 Jun 2024 01:50:02 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240527-x1e80100-dts-pmic-glink-v1-0-7ea5c8eb4d2b@linaro.org> <20240527-x1e80100-dts-pmic-glink-v1-2-7ea5c8eb4d2b@linaro.org> In-Reply-To: From: Dmitry Baryshkov Date: Mon, 3 Jun 2024 11:49:51 +0300 Message-ID: Subject: Re: [PATCH 2/3] arm64: dts: qcom: x1e80100-crd: Add pmic-glink node with all 3 connectors To: Johan Hovold Cc: Abel Vesa , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" On Mon, 3 Jun 2024 at 11:48, Johan Hovold wrote: > > On Mon, May 27, 2024 at 11:07:28AM +0300, Abel Vesa wrote: > > Add the pmic-glink node and describe all 3 USB Type-C connectors. Do this > > for USB only, for now. The DP port will come at a later stage since it > > uses a retimer. > > > > Signed-off-by: Abel Vesa > > --- > > arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 143 ++++++++++++++++++++++++++++++ > > 1 file changed, 143 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts > > index c5c2895b37c7..2fcc994cbb89 100644 > > --- a/arch/arm64/boot/dts/qcom/x1e80100-crd.dts > > +++ b/arch/arm64/boot/dts/qcom/x1e80100-crd.dts > > @@ -49,6 +49,101 @@ chosen { > > stdout-path = "serial0:115200n8"; > > }; > > > > + pmic-glink { > > + compatible = "qcom,x1e80100-pmic-glink", > > + "qcom,sm8550-pmic-glink", > > + "qcom,pmic-glink"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + orientation-gpios = <&tlmm 121 GPIO_ACTIVE_HIGH>, > > + <&tlmm 123 GPIO_ACTIVE_HIGH>, > > + <&tlmm 125 GPIO_ACTIVE_HIGH>; > > With this series applied, I'm getting the following error on boot of the > CRD: > > ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: PPM init failed, stop trying > > Known issue? Do you need to enable some quirk in the UCSI driver? Not that I know. The message is caused by the UCSI not responding to the PPM_RESET command. A trace from pmic-glink would be helpful. -- With best wishes Dmitry