From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 706DB1D0E20 for ; Thu, 12 Dec 2024 23:10:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734045002; cv=none; b=h7DvL/hzZ7mKIFjxqyWs8jEOE/XiTW6CXp0spgUZL6DtYU/IvVDgwUmZg1KvXSMD+PmhhKvO//VC3EQUQUYr+Xd8u9CZXUmLO3Sm4F0whK5gY0iET4pCKo9wcJvF4wnFzMAhAfNaComK/OFJgcr20ldBOZkGBY6WjBMxcMmqSNE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734045002; c=relaxed/simple; bh=WHVE0/t1otvsxQeNRlbwwsP9omODFpmla3k00JB+nT0=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=BGUpCmj7QvrFZyauj08o7MGFKZ687gXgDk7alPFPH1IZrZPXVltKuqIeIyQ0fy790w20zyAEt36t2grMU5SHLrB5boUkx+KsKUNSwp5YGheaek0u1QQtQDHx2uzjqeVa9mkZqUclT91QyCOPuaGUGqwdWygOzhSmaBDaIVAsM2Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=m/VVGfmh; arc=none smtp.client-ip=209.85.128.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="m/VVGfmh" Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-6ef81222be7so11849467b3.3 for ; Thu, 12 Dec 2024 15:10:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1734044999; x=1734649799; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=WaleLzibxZUfAGDbUadGTT7PEq5jpDmCmSJXElnaBv8=; b=m/VVGfmhIJDoxB+byci2wyeyJSA6mwStWbnPX4FqTOAD3hiBi0MJiG9btIhcJBtNbd Q9imCHxluZZZsZNipxmLNpSKiB8e3M+baLaOz2bIBCZwmHsbteP14VV63ccHppsmRCDu jP3nN+2ZbykuCkfQRL+FChFg/Vt0sdn8XWhl0HwqgFlDhE/8z1JxFyl9uzfGkSXfctl0 715oLYOeqLCZcbQulBrcmSQpl5ukD+hn2fu0hYNeF/CEaBBuc1QjDYNZh3S9bPDcU/tN vRIjgffxKq6Nv0yb/YwgSVnuW4qnveLHJlUXMlGpSPmgRQVOCmumiQhFDM947CVu7y46 wkpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734044999; x=1734649799; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WaleLzibxZUfAGDbUadGTT7PEq5jpDmCmSJXElnaBv8=; b=LI67vggNX3miY14xMKHDKrJLbowQRLCbeyh0QLSPYy8ebIfE6vW6JnQY/JyNr2w9Gk hbcR14zLjSgOoIDk9cFH9ldVxYJVOpEIHHAm1Y9OsPiV9IqNkvikuNVlAZj2nCbEY5sU ILMnBKqJa0L3TPTk0UER2rG+z8ffAFbq6YCiytj/18oKLmkten/U4rxRPjjhjmzMLQbP hDQwcNP9CI0vhtnQ0JFqdpGk82kII8vz8MuHfuY3Ekeq8wrvSp3b4JgO3mQpEQXOZAg9 KnF2cleGez5qi8HNSqw9ICRtc9No9t8rE8wcNGPwfB+XA52DQwIt4m2WC7FvPEx+Y7im 4ZRA== X-Forwarded-Encrypted: i=1; AJvYcCUtMFSYQaspBAuO4a0gG5tIUG5WDeFio42bK4y06TkWSrpWjbmyo+LAT8AeVETJX+cTfzT7feuNsoFeq5k=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0mbTXakHvQsnCmoXRcSuRw2Ez5QZukBByr5Ak76CUv674eWCB tikYDNzsJuavZdeNo2qjhD8CyZQ7jKvWEwX8O1/OtNx6e0oqXEV+JWbFsSlDDPGHg2m3FOTcm4Y M1trUhnUG4j28F5vmPetE+kcc0axElv74AvK3vg== X-Gm-Gg: ASbGncupWhJotL2hEegWMZt/bt+5renaPgoGklM4R/1LXLN5NVAmOv4cdvvM1BG0Nfw G3XMBk2KYLAVvg5qZ69eRWzYdw7m30vpfKpNPIg== X-Google-Smtp-Source: AGHT+IF/V/ux6X1mO6hXRsOgpRG5i2WaZY0ezUfxfN+Hfmp4+xxlK9dJwbtdQzgy6yG4fyhaFVSrL2l4czjoSGhEs5I= X-Received: by 2002:a05:690c:6510:b0:6ef:6c57:ddae with SMTP id 00721157ae682-6f279b960admr5713247b3.34.1734044999382; Thu, 12 Dec 2024 15:09:59 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20241212-fd-dp-audio-fixup-v3-0-0b1c65e7dba3@linaro.org> <20241212-fd-dp-audio-fixup-v3-1-0b1c65e7dba3@linaro.org> <01f84965-8a11-4d6d-99a6-b0e37240d4cb@quicinc.com> <49d330b8-86fe-40a6-864b-cbb28dc2f555@quicinc.com> In-Reply-To: From: Dmitry Baryshkov Date: Fri, 13 Dec 2024 01:09:51 +0200 Message-ID: Subject: Re: [PATCH v3 01/14] drm/msm/dp: set safe_to_exit_level before printing it To: Abhinav Kumar Cc: Rob Clark , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Paloma Arellano , Douglas Anderson , Stephen Boyd , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel test robot Content-Type: text/plain; charset="UTF-8" On Thu, 12 Dec 2024 at 20:53, Abhinav Kumar wrote: > > > > On 12/12/2024 10:31 AM, Abhinav Kumar wrote: > > > > > > On 12/12/2024 12:58 AM, Dmitry Baryshkov wrote: > >> On Wed, Dec 11, 2024 at 05:14:18PM -0800, Abhinav Kumar wrote: > >>> > >>> > >>> On 12/11/2024 3:41 PM, Dmitry Baryshkov wrote: > >>>> Rather than printing random garbage from stack and pretending that > >>>> it is > >>>> the default safe_to_exit_level, set the variable beforehand. > >>>> > >>>> Fixes: d13e36d7d222 ("drm/msm/dp: add audio support for Display Port > >>>> on MSM") > >>>> Reported-by: kernel test robot > >>>> Closes: > >>>> https://lore.kernel.org/oe-kbuild-all/202411081748.0PPL9MIj-lkp@intel.com/ > >>>> Reviewed-by: Stephen Boyd > >>>> Reviewed-by: Abhinav Kumar > >>>> Signed-off-by: Dmitry Baryshkov > >>>> --- > >>>> drivers/gpu/drm/msm/dp/dp_audio.c | 2 +- > >>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>> > >>>> diff --git a/drivers/gpu/drm/msm/dp/dp_audio.c > >>>> b/drivers/gpu/drm/msm/dp/dp_audio.c > >>>> index > >>>> 74e01a5dd4195d5e0e04250663886f1116f25711..5cbb11986460d1e4ed1890bdf66d0913e013083c 100644 > >>>> --- a/drivers/gpu/drm/msm/dp/dp_audio.c > >>>> +++ b/drivers/gpu/drm/msm/dp/dp_audio.c > >>>> @@ -329,10 +329,10 @@ static void > >>>> msm_dp_audio_safe_to_exit_level(struct msm_dp_audio_private *audio) > >>>> safe_to_exit_level = 5; > >>>> break; > >>>> default: > >>>> + safe_to_exit_level = 14; > >>>> drm_dbg_dp(audio->drm_dev, > >>>> "setting the default safe_to_exit_level = %u\n", > >>>> safe_to_exit_level); > >>>> - safe_to_exit_level = 14; > >>>> break; > >>>> } > >>>> > >>> > >>> This was already picked up in -fixes, so no need to include > >> > >> I have been rebasing on linux-next. Please make sure that your -fixes > >> branch is a part of linux-next. > >> > > > > Its merged to msm-fixes not just my fixes branch. I am pretty sure > > msm-fixes is part of linux-next. > > > Actually, I noticed just now that msm-fixes is not part of linux-next. > So pls ignore my comment. drm-fixes is part of linux-next. We should be > sending out our PR pretty soon. So you will be able to drop this after that. Ack. Let's get it to linux-next then. -- With best wishes Dmitry