From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yw1-f169.google.com (mail-yw1-f169.google.com [209.85.128.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D3C411E231E for ; Mon, 21 Oct 2024 09:06:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729501615; cv=none; b=pXBF9ct7a4zmdekKuSN3ylDLy0hk/v7IMVq2czoDoqbPz19dEDz1ucYFpygW7ClTscYgnEQGsZIxvfjNMEwytAPS98FsXiN3UXc34e0uaipQ4oYjTOgGsczZ4tz87oXr3KdnoglFb5cVJI7l2OYv4i4PGMr6vXI1os1CMjTo46A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729501615; c=relaxed/simple; bh=nLN3F4nrPxdIk1EHSJ4sxKummFNcWIjt34YMFX7VnhQ=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=F3niAi8AegdYDu1oQ9zQ/dLQNrDNv9kykGjXgN2xx3bCxE5Q9DFPFXdkaoE2tlWBlqTXpEutUILlt4hiHKK0nGAmSB0KBBxuf3AIzO/7U75YGL7S0Nu9uMypOgRgG2nS2juHstPC4PhqZZVdca2i8PWK/OKdxPgr4jLtr3M0a2M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=VWrjJtNH; arc=none smtp.client-ip=209.85.128.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="VWrjJtNH" Received: by mail-yw1-f169.google.com with SMTP id 00721157ae682-6e5ef7527deso10584927b3.0 for ; Mon, 21 Oct 2024 02:06:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729501613; x=1730106413; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jA3p085WBVZjxthmW00sO8DEVEBHgAHr/aWoPpnBk54=; b=VWrjJtNHmFBfnjx7xudtG+U0Chl6o80Ec84WdttLHaQSiVfCJBsU0Qr8yzynjESVNf sh+ueXmSYjVZmV6xT6GjxVpvjQyHJlVvxtuerwT/OMO7Un7AcM7+uOle9NKBq9ngRigv Z04NLt+YWR6z9wxmhwFOIlbXWGuI3mYwpW2uMNyxv1pz6kleUIhWHcKHzlOV1LqyAqtB rJwngSOkReITmfJ6rZQ/+na0xGmfgSZjrNhkb1KbDXhzS8u+IxYZnqn/UWBF/ifmMajE 0Oqu+s5/7QQhtSbs15VvWTu0HIruBN19PftvaEaN7RNjB2f1BKT+I/liFVgjNpbdM54i OfYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729501613; x=1730106413; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jA3p085WBVZjxthmW00sO8DEVEBHgAHr/aWoPpnBk54=; b=tJWcRihh5TIyJyc/qSXtJra3NyvtvILzXLlC0hcuYXAFgLjFBzwvKygTt8WS5HB7BL oFNVhYReLdBvoSs89IcfzHeUtEtyglm5DYp+8ckt6tmuQIrpIVJwI7XcXNKKk1qoLJRn BCy6G4bNIU3k3aYbQ96HNYIm+iP3FzVzlTCZUeSE8KkJbVKz+OH1LsY68g6LWIyO+U1t 5orKkK/o6fLqS9ArKwfKgeXIF1v3XhGmgDEK5+GCjaF70oFP2DS5+HRyU1crHAW8LLde 5y8pKJwjMSabiybHHw1u0v3CMj5v0VKiq6r0DXdTsxZbrQToiMV2P6DAapykYHYs9vCy SVFQ== X-Forwarded-Encrypted: i=1; AJvYcCVlamI4nEv/7oqthHEYJTqUFG7rG5q7M0okg4UnCLyqMo0BR4hxbixfAieDaIiPqxD/tLPwv51LxEqA0Gk=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3gEBAGx6Nk1089XIYaupKLsjORXKb7u2TpFQRtHOgIEe3jFg1 oWOrdXvMINdynXJuSB1KjLy1IOlcfyqXq/+ne9euzHgFG+LQzUpn85v+4JUBGR1iCU6L4w6DGs8 FdP5M5prGflJZK0azoLuAry2ylILmwPbA59cqCQ== X-Google-Smtp-Source: AGHT+IEaP9MJaux+Mvm9jAqxzMdqSn1f+GPVXkxv1I5i5R13Oo9mtvtrHTONlbQt6H8kuW3J8xABR0qDJyPjxkF3F48= X-Received: by 2002:a05:690c:610a:b0:6e3:36fd:d985 with SMTP id 00721157ae682-6e5bfc8926emr109528627b3.23.1729501612759; Mon, 21 Oct 2024 02:06:52 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20241019-bridge-yuv420-v1-0-d74efac9e4e6@linaro.org> <20241019-bridge-yuv420-v1-3-d74efac9e4e6@linaro.org> <28fb5aed-0387-4c16-96fb-c2c23ae315b0@linaro.org> In-Reply-To: <28fb5aed-0387-4c16-96fb-c2c23ae315b0@linaro.org> From: Dmitry Baryshkov Date: Mon, 21 Oct 2024 12:06:46 +0300 Message-ID: Subject: Re: [PATCH 3/6] drm/bridge: display-connector: allow YCbCr 420 for HDMI and DP To: neil.armstrong@linaro.org Cc: Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org Content-Type: text/plain; charset="UTF-8" On Mon, 21 Oct 2024 at 10:29, Neil Armstrong wrote: > > On 18/10/2024 23:49, Dmitry Baryshkov wrote: > > Allow YCbCr 420 output for HDMI and DisplayPort connectors. Other > > bridges in the chain still might limit YCbCr 420 support on the > > corresponding connector. > > > > Signed-off-by: Dmitry Baryshkov > > --- > > drivers/gpu/drm/bridge/display-connector.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/gpu/drm/bridge/display-connector.c b/drivers/gpu/drm/bridge/display-connector.c > > index ab8e00baf3f1..aab9ce7be94c 100644 > > --- a/drivers/gpu/drm/bridge/display-connector.c > > +++ b/drivers/gpu/drm/bridge/display-connector.c > > @@ -270,6 +270,10 @@ static int display_connector_probe(struct platform_device *pdev) > > /* All the supported connector types support interlaced modes. */ > > conn->bridge.interlace_allowed = true; > > > > + if (type == DRM_MODE_CONNECTOR_HDMIA || > > + type == DRM_MODE_CONNECTOR_DisplayPort) > > + conn->bridge.ycbcr_420_allowed = true; > > + > > /* Get the optional connector label. */ > > of_property_read_string(pdev->dev.of_node, "label", &label); > > > > > > I think we should make sure all HDMI bridges can filter out 420 before > landing this, no ? No, it's the other way around: if one of the bridges in a chain doesn't set 420_allowed, then 420_allowed won't be set for the connector, disallowing YCbCr 420 modes. Before this patchset the bridge / platform drivers had to manually set the flag on the created connector (see dw-hdmi + meson-encoder-hdmi or msm/dp). -- With best wishes Dmitry