From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C90CCC11F66 for ; Fri, 9 Jul 2021 11:46:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ADC33613BA for ; Fri, 9 Jul 2021 11:46:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231185AbhGILtg (ORCPT ); Fri, 9 Jul 2021 07:49:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230471AbhGILtf (ORCPT ); Fri, 9 Jul 2021 07:49:35 -0400 Received: from mail-qt1-x835.google.com (mail-qt1-x835.google.com [IPv6:2607:f8b0:4864:20::835]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBBF7C0613E5 for ; Fri, 9 Jul 2021 04:46:50 -0700 (PDT) Received: by mail-qt1-x835.google.com with SMTP id g12so7372782qtb.2 for ; Fri, 09 Jul 2021 04:46:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ONSgbSybDS3aq6XRVOEGbplrYREJdvsgJ8FcbeYsWZQ=; b=X1DMeut+wlmbqF5RrAzcCPZPJFuU49aQnYR241lLwaVbyP8bU8ILEeVloVcyws0Z43 DnBmrijkudd2Foqjg1XzAnqd7AldKERLw874LIjj1kT5Hazd0DnnRnsyGk73zjpv67AT 5wtkQgtCubBtWV8RbEcZw5f4rQjTyboeq3eCr0vECIidbkqusnOOmqnYej6o6q7krJ3Y eo7bv1t5oeVVDG20YjinIonwJA18y/ym9brtXgcaLp4IaK3pFF/2HrgmfwsBmIyseThm WOQU5cZT+4tZWrkx1IAzqE8X4sJfDC8/T/RzifHmArNLvId0LqJH/hhGVF96rNoe5z9g gL6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ONSgbSybDS3aq6XRVOEGbplrYREJdvsgJ8FcbeYsWZQ=; b=jQ/WPuM53/q6zpnUtq5w8T7Bdzyt3QDuPvNMYj7enn1Kt079LcPxXO5rShGxb4oqBf rtAYDIDNkC3WMAGY7EDZvBJhBad+i4Ozd/OOaEVzQoXHHbqyOaxlPr1vpr9cym1fGZqH ID+V/sYUBL7UhSIRmc5ziAuRo985H5kW/rLYxAzDz/0QGHRqxdN6r96IsrmYnsfml0sr Ze57s075yp31Hhjf2RpnKtBb2+zEkJcK0+2RtvR0ZJGgwyc0U2V7/ORbRrBmqEsQFvqy ntrG3OXZvVCsUukc4OmdIjQHlbGKayoVCp705UTaUPWkZOWCVUp2FpdYLm0oaPK8PcN6 05Xg== X-Gm-Message-State: AOAM533F0lEXFTNETHMKXQ+LXbPTDwAz1xm+j2M0dwILUK174G8+087q 3kVdxJTL5HvZb3UwsRhub9pppYCXuc0K4O1Zf4Cl3A== X-Google-Smtp-Source: ABdhPJxEmzRWpMruBIId+kQ7gKz2U0whpes7FmT5IdlbX0im5aKGJf4rT18bQiHy9N/1kwulsFpkdTs5e29KGfTZ/Z8= X-Received: by 2002:ac8:59ca:: with SMTP id f10mr16013910qtf.298.1625831210069; Fri, 09 Jul 2021 04:46:50 -0700 (PDT) MIME-Version: 1.0 References: <20210709043136.533205-1-dmitry.baryshkov@linaro.org> <20210709043136.533205-5-dmitry.baryshkov@linaro.org> In-Reply-To: From: Dmitry Baryshkov Date: Fri, 9 Jul 2021 14:46:39 +0300 Message-ID: Subject: Re: [RESEND PATCH v2 4/7] clk: qcom: gdsc: enable optional power domain support To: Ulf Hansson Cc: Andy Gross , Bjorn Andersson , Rob Herring , Stephen Boyd , Taniya Das , Jonathan Marek , Michael Turquette , linux-arm-msm , DTML , linux-clk , "Bryan O'Donoghue" , Mark Brown , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 9 Jul 2021 at 12:33, Ulf Hansson wrote: > > On Fri, 9 Jul 2021 at 06:32, Dmitry Baryshkov > wrote: > > > > On sm8250 dispcc and videocc registers are powered up by the MMCX power > > domain. Currently we used a regulator to enable this domain on demand, > > however this has some consequences, as genpd code is not reentrant. > > > > Teach Qualcomm clock controller code about setting up power domains and > > using them for gdsc control. > > > > Signed-off-by: Dmitry Baryshkov > > [...] > > > diff --git a/drivers/clk/qcom/gdsc.c b/drivers/clk/qcom/gdsc.c > > index 51ed640e527b..9401d01533c8 100644 > > --- a/drivers/clk/qcom/gdsc.c > > +++ b/drivers/clk/qcom/gdsc.c > > @@ -427,6 +427,7 @@ int gdsc_register(struct gdsc_desc *desc, > > continue; > > scs[i]->regmap = regmap; > > scs[i]->rcdev = rcdev; > > + scs[i]->pd.dev.parent = desc->dev; > > ret = gdsc_init(scs[i]); > > if (ret) > > return ret; > > @@ -439,6 +440,8 @@ int gdsc_register(struct gdsc_desc *desc, > > continue; > > if (scs[i]->parent) > > pm_genpd_add_subdomain(scs[i]->parent, &scs[i]->pd); > > + else if (!IS_ERR_OR_NULL(dev->pm_domain)) > > So dev_pm_domain_attach() (which calls genpd_dev_pm_attach() is being > called for gdsc platform device from the platform bus', to try to > attach the device to its corresponding PM domain. > > Looking a bit closer to genpd_dev_pm_attach(), I realize that we > shouldn't really try to attach a device to its PM domain, when its OF > node (dev->of_node) contains a "#power-domain-cells" specifier. This > is because it indicates that the device belongs to a genpd provider > itself. In this case, a "power-domains" specifier tells that it has a > parent domain. > > I will post a patch that fixes this asap. I think there is nothing to fix here. The dispcc/videocc drivers provide clocks in addition to the gdsc power domain. And provided clocks would definitely benefit from having the dispcc device being attached to the power domain which governs clock registers (MMCX in our case). Thus I think it is perfectly valid to have: rpmhpd device: - provides MMCX domain. dispcc device: - is attached to the MMCX domain, - provides MDSS_GDSC - provides clocks > > > + pm_genpd_add_subdomain(pd_to_genpd(dev->pm_domain), &scs[i]->pd); > > } > > > > return of_genpd_add_provider_onecell(dev->of_node, data); > > @@ -457,6 +460,8 @@ void gdsc_unregister(struct gdsc_desc *desc) > > continue; > > if (scs[i]->parent) > > pm_genpd_remove_subdomain(scs[i]->parent, &scs[i]->pd); > > + else if (!IS_ERR_OR_NULL(dev->pm_domain)) > > Ditto. > > > + pm_genpd_remove_subdomain(pd_to_genpd(dev->pm_domain), &scs[i]->pd); > > } > > of_genpd_del_provider(dev->of_node); > > } > > -- > > 2.30.2 > > > > Kind regards > Uffe -- With best wishes Dmitry