mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ricardo Robaina <rrobaina@redhat.com>
To: Paul Moore <paul@paul-moore.com>
Cc: Florian Westphal <fw@strlen.de>,
	audit@vger.kernel.org, linux-kernel@vger.kernel.org,
	 netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	eparis@redhat.com,  pablo@netfilter.org, kadlec@netfilter.org,
	ej@inai.de
Subject: Re: [PATCH v3] audit: include source and destination ports to NETFILTER_PKT
Date: Mon, 13 Oct 2025 16:11:20 -0300	[thread overview]
Message-ID: <CAABTaaBO2KBujB=bqvyumO2xW=JCxKP0hc87myqcLF3pbxSorA@mail.gmail.com> (raw)
In-Reply-To: <CAHC9VhR-EXz-w6QeX7NfyyO7B3KUXTnz-Jjhd=xbD9UpXnqr+w@mail.gmail.com>

On Mon, Oct 13, 2025 at 3:51 PM Paul Moore <paul@paul-moore.com> wrote:
>
> On Mon, Oct 13, 2025 at 2:48 PM Paul Moore <paul@paul-moore.com> wrote:
> > On Fri, Oct 3, 2025 at 11:43 AM Ricardo Robaina <rrobaina@redhat.com> wrote:
> > > On Sat, Sep 27, 2025 at 7:45 AM Florian Westphal <fw@strlen.de> wrote:
> > > > Ricardo Robaina <rrobaina@redhat.com> wrote:
> >
> > ...
> >
> > > > Maybe Paul would be open to adding something like audit_log_packet() to
> > > > kernel/audit.c and then have xt_AUDIT.c and nft_log.c just call the
> > > > common helper.
> > >
> > > It sounds like a good idea to me. What do you think, Paul?
> >
> > Seems like a good idea to me too.
>
> A quick follow-up to this ... when you are doing the work Ricardo,
> please do this as a two patch patchset; the first patch should
> introduce a new common function called by both audit_tg() and
> nft_log_eval_audit(), and the second patch should add new port
> information to the audit record.
>
> --
> paul-moore.com
>

Thanks for the tip, Paul! I'll work on it next week.


  reply	other threads:[~2025-10-13 19:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-26 19:30 Ricardo Robaina
2025-09-27 10:44 ` Florian Westphal
2025-10-03 15:43   ` Ricardo Robaina
2025-10-13 18:48     ` Paul Moore
2025-10-13 18:51       ` Paul Moore
2025-10-13 19:11         ` Ricardo Robaina [this message]
2025-10-13 20:26           ` Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAABTaaBO2KBujB=bqvyumO2xW=JCxKP0hc87myqcLF3pbxSorA@mail.gmail.com' \
    --to=rrobaina@redhat.com \
    --cc=audit@vger.kernel.org \
    --cc=coreteam@netfilter.org \
    --cc=ej@inai.de \
    --cc=eparis@redhat.com \
    --cc=fw@strlen.de \
    --cc=kadlec@netfilter.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    --cc=paul@paul-moore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®