From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF451C43215 for ; Thu, 14 Nov 2019 08:47:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AFEF32070E for ; Thu, 14 Nov 2019 08:47:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="F6GUlB6i" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726270AbfKNIrT (ORCPT ); Thu, 14 Nov 2019 03:47:19 -0500 Received: from mail-ed1-f66.google.com ([209.85.208.66]:34059 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725977AbfKNIrS (ORCPT ); Thu, 14 Nov 2019 03:47:18 -0500 Received: by mail-ed1-f66.google.com with SMTP id b72so4328448edf.1 for ; Thu, 14 Nov 2019 00:47:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uFeS+uA4c3JpCfgrQSP5W4UkQmv75ra/a0iuWSrGw8w=; b=F6GUlB6iw2SB4SJnps1K+f1038Vraj5TlbOPJ3viIHEBnViOrPo1rXMIYnA/hYWUXq UuV5QaciRJDPLRS9hzYNmdJewiXmJB0pTCHoGsxIZWSbfcznBC9Wp4Aaq1RBIa94v6Oj iGhktZEqYhWMO1kdpDeTFv33ORLDA+36hWg1c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uFeS+uA4c3JpCfgrQSP5W4UkQmv75ra/a0iuWSrGw8w=; b=tarvagiMz2UjenlzLaS1/wjFOjYKWILY9YyOt0L6Q7JlWzhAn3mW75NOCy4dx5pXS+ /oIMT1VoZpAtjS0BZFdoLpC7ZgewLwv2Dik1nQ7a5ZQwx2UreIz+BZ1eec1bSNOuIegP HE59KRuW4AEQh5iS3/wF1FO3TKh6cDz/NxmtSVhR3pPTBJMUd7JqAajAuAs40SHHgWz4 vCbeYo/zCeU3+igfBz0cgAdxl2yuK5ZuKa9n9qbp2x+lafLHS7KxWzJpPaNYLo4CjBDz M2NqZwgkuR73h5bffIhZuFvnBCPTSAqtqw2qJQlukZ/zohJ5xpvNmghSAa3fUxorJult k4PQ== X-Gm-Message-State: APjAAAWlKmhdAjy9wBusPVegC+fn/JE4k3MPj7fRYqKiKxhxpoX0RUd8 acAUXT85gj9d4G2kM9yKQ6Kv02CbndzVxw== X-Google-Smtp-Source: APXvYqzU/W9M/G3/gCorKzbvmu0ppmIJ4rK4jREqPOdk0A6uJNn9CPmJlnKrofZQjfk8HxVMQpDBtA== X-Received: by 2002:a05:6402:1a50:: with SMTP id bf16mr8546754edb.116.1573721234312; Thu, 14 Nov 2019 00:47:14 -0800 (PST) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com. [209.85.128.49]) by smtp.gmail.com with ESMTPSA id d11sm77650edr.37.2019.11.14.00.47.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Nov 2019 00:47:13 -0800 (PST) Received: by mail-wm1-f49.google.com with SMTP id l17so4736922wmh.0 for ; Thu, 14 Nov 2019 00:47:12 -0800 (PST) X-Received: by 2002:a7b:cbd9:: with SMTP id n25mr7174991wmi.64.1573721232315; Thu, 14 Nov 2019 00:47:12 -0800 (PST) MIME-Version: 1.0 References: <20191114051242.14651-1-helen.koike@collabora.com> <20191114051242.14651-3-helen.koike@collabora.com> <09d4f683-d03d-46c9-e9d2-b8cceb72446e@xs4all.nl> In-Reply-To: <09d4f683-d03d-46c9-e9d2-b8cceb72446e@xs4all.nl> From: Tomasz Figa Date: Thu, 14 Nov 2019 17:47:00 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v11 02/11] media: staging: rkisp1: add document for rkisp1 meta buffer format To: Hans Verkuil Cc: Helen Koike , "open list:ARM/Rockchip SoC..." , Mark Rutland , linux-devicetree , Eddie Cai , Mauro Carvalho Chehab , =?UTF-8?Q?Heiko_St=C3=BCbner?= , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , Greg KH , Jeffy , =?UTF-8?B?6ZKf5Lul5bSH?= , Linux Kernel Mailing List , Rob Herring , Hans Verkuil , Laurent Pinchart , Sakari Ailus , kernel@collabora.com, Ezequiel Garcia , Linux Media Mailing List , Jacob Chen , Shunqian Zheng , Jacob Chen , Jacob Chen Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 14, 2019 at 5:21 PM Hans Verkuil wrote: > > On 11/14/19 6:12 AM, Helen Koike wrote: > > From: Jacob Chen > > > > This commit add document for rkisp1 meta buffer format > > > > Signed-off-by: Jacob Chen > > [refactored for upstream] > > Signed-off-by: Helen Koike > > checkpatch gives me: > > WARNING: Missing Signed-off-by: line by nominal patch author 'Jacob Chen ' > > Looking at this series I see duplicate Signed-off-by entries for Jacob Chen and a total > of three different email addresses: > > jacob2.chen@rock-chips.com > jacob-chen@rock-chips.com > cc@rock-chips.com I remember there used to be two different people named Jacob Chen in the project. Also FWIW at least one of them (jacob2.chen@rock-chips.com) is not at Rockchip anymore. Looking in my inbox, I don't see anyone matching jacob-chen@rock-chips.com, so that could possibly be a mistyped jacob2.chen@rock-chips.com? Best regards, Tomasz > > It's confusing. > > Regards, > > Hans > > > > > --- > > > > Changes in v11: None > > Changes in v10: > > - unsquash > > > > Changes in v9: > > - squash > > - migrate to staging > > - remove meta-formats.rst update > > > > Changes in v8: > > - Add SPDX in the header > > - Remove emacs configs > > - Fix doc style > > > > Changes in v7: > > - s/correspond/corresponding > > - s/use/uses > > - s/docuemnt/document > > > > .../uapi/v4l/pixfmt-meta-rkisp1-params.rst | 23 +++++++++++++++++++ > > .../uapi/v4l/pixfmt-meta-rkisp1-stat.rst | 22 ++++++++++++++++++ > > 2 files changed, 45 insertions(+) > > create mode 100644 drivers/staging/media/rkisp1/Documentation/media/uapi/v4l/pixfmt-meta-rkisp1-params.rst > > create mode 100644 drivers/staging/media/rkisp1/Documentation/media/uapi/v4l/pixfmt-meta-rkisp1-stat.rst > > > > diff --git a/drivers/staging/media/rkisp1/Documentation/media/uapi/v4l/pixfmt-meta-rkisp1-params.rst b/drivers/staging/media/rkisp1/Documentation/media/uapi/v4l/pixfmt-meta-rkisp1-params.rst > > new file mode 100644 > > index 000000000000..103b5cb79b7c > > --- /dev/null > > +++ b/drivers/staging/media/rkisp1/Documentation/media/uapi/v4l/pixfmt-meta-rkisp1-params.rst > > @@ -0,0 +1,23 @@ > > +.. SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > + > > +.. _v4l2-meta-fmt-rkisp1-params: > > + > > +============================ > > +V4L2_META_FMT_RK_ISP1_PARAMS > > +============================ > > + > > +Rockchip ISP1 Parameters Data > > + > > +Description > > +=========== > > + > > +This format describes input parameters for the Rockchip ISP1. > > + > > +It uses c-struct :c:type:`rkisp1_isp_params_cfg`, which is defined in > > +the ``linux/rkisp1-config.h`` header file. > > + > > +The parameters consist of multiple modules. > > +The module won't be updated if the corresponding bit was not set in module_*_update. > > + > > +.. kernel-doc:: include/uapi/linux/rkisp1-config.h > > + :functions: rkisp1_isp_params_cfg > > diff --git a/drivers/staging/media/rkisp1/Documentation/media/uapi/v4l/pixfmt-meta-rkisp1-stat.rst b/drivers/staging/media/rkisp1/Documentation/media/uapi/v4l/pixfmt-meta-rkisp1-stat.rst > > new file mode 100644 > > index 000000000000..4ad303f96421 > > --- /dev/null > > +++ b/drivers/staging/media/rkisp1/Documentation/media/uapi/v4l/pixfmt-meta-rkisp1-stat.rst > > @@ -0,0 +1,22 @@ > > +.. SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > + > > +.. _v4l2-meta-fmt-rkisp1-stat: > > + > > +============================= > > +V4L2_META_FMT_RK_ISP1_STAT_3A > > +============================= > > + > > + > > +Rockchip ISP1 Statistics Data > > + > > +Description > > +=========== > > + > > +This format describes image color statistics information generated by the Rockchip > > +ISP1. > > + > > +It uses c-struct :c:type:`rkisp1_stat_buffer`, which is defined in > > +the ``linux/rkisp1-config.h`` header file. > > + > > +.. kernel-doc:: include/uapi/linux/rkisp1-config.h > > + :functions: rkisp1_stat_buffer > > >