From: Jan Stancek <jstancek@redhat.com>
To: Donald Hunter <donald.hunter@gmail.com>
Cc: stfomichev@gmail.com, kuba@kernel.org, jdamato@fastly.com,
pabeni@redhat.com, davem@davemloft.net, edumazet@google.com,
horms@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/4] tools: ynl: add initial pyproject.toml for packaging
Date: Mon, 6 Jan 2025 12:57:20 +0100 [thread overview]
Message-ID: <CAASaF6yj_E1CTi8SjUa_nBxBiWS0cH+hPCPDYoRFu8wE-eefNw@mail.gmail.com> (raw)
In-Reply-To: <m2ed2791me.fsf@gmail.com>
On Mon, Dec 16, 2024 at 3:10 PM Donald Hunter <donald.hunter@gmail.com> wrote:
>
> Jan Stancek <jstancek@redhat.com> writes:
>
> > Signed-off-by: Jan Stancek <jstancek@redhat.com>
>
> nit: missing patch description
>
> > ---
> > tools/net/ynl/pyproject.toml | 26 ++++++++++++++++++++++++++
> > 1 file changed, 26 insertions(+)
> > create mode 100644 tools/net/ynl/pyproject.toml
> >
> > diff --git a/tools/net/ynl/pyproject.toml b/tools/net/ynl/pyproject.toml
> > new file mode 100644
> > index 000000000000..677ea8f4c185
> > --- /dev/null
> > +++ b/tools/net/ynl/pyproject.toml
> > @@ -0,0 +1,26 @@
> > +[build-system]
> > +requires = ["setuptools>=61.0"]
> > +build-backend = "setuptools.build_meta"
> > +
> > +[project]
> > +name = "pyynl"
> > +authors = [
> > + {name = "Donald Hunter", email = "donald.hunter@gmail.com"},
> > + {name = "Jakub Kicinski", email = "kuba@kernel.org"},
> > +]
> > +description = "yaml netlink (ynl)"
> > +version = "0.0.1"
> > +requires-python = ">=3.9"
> > +dependencies = [
> > + "pyyaml==6.*",
> > + "jsonschema==4.*"
> > +]
> > +
> > +[tool.setuptools.packages.find]
> > +include = ["pyynl", "pyynl.lib"]
> > +
> > +[project.scripts]
> > +ynl = "pyynl.cli:main"
> > +ynl-ethtool = "pyynl.ethtool:main"
> > +ynl-gen-c = "pyynl.ynl_gen_c:main"
> > +ynl-gen-rst = "pyynl.ynl_gen_rst:main"
>
> I'm not sure if we want to install ynl-gen-c or ynl-gen-rst since they
> are for in-tree use.
>
> Thoughts?
I haven't seen any downside and thought it might be useful for somebody,
but I'm happy to drop it.
next prev parent reply other threads:[~2025-01-06 11:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-16 10:41 [PATCH v3 0/4] tools: ynl: add install target Jan Stancek
2024-12-16 10:41 ` [PATCH v3 1/4] tools: ynl: move python code to separate sub-directory Jan Stancek
2024-12-16 13:45 ` Donald Hunter
2024-12-16 10:41 ` [PATCH v3 2/4] tools: ynl: add initial pyproject.toml for packaging Jan Stancek
2024-12-16 13:52 ` Donald Hunter
2025-01-06 11:57 ` Jan Stancek [this message]
2024-12-16 10:41 ` [PATCH v3 3/4] tools: ynl: add install target for generated content Jan Stancek
2024-12-16 14:01 ` Donald Hunter
2025-01-06 11:35 ` Jan Stancek
2024-12-16 10:41 ` [PATCH v3 4/4] tools: ynl: add main install target Jan Stancek
2024-12-16 14:09 ` Donald Hunter
2024-12-16 22:58 ` Joe Damato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAASaF6yj_E1CTi8SjUa_nBxBiWS0cH+hPCPDYoRFu8wE-eefNw@mail.gmail.com \
--to=jstancek@redhat.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stfomichev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®