From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96B093C4176 for ; Tue, 21 Jul 2026 09:27:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784626026; cv=none; b=ERPpmqD2dP4zDz/E9nLu411447YjQ8l8S0AJzLYBJiIHkKy9++eiYB+aq4CpuefyZNq/VBjUYbeHC13bmmBQ1NV9iEm+QUh3W+TiBpQ2JZxKi5PTZPb1PzbKY/iGbpCKGSZmRUog0z3W59LiuYDP0Oc7srLOtAtYmCFG6TlqJFc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784626026; c=relaxed/simple; bh=X3rtVlfwuBHfi8QKaUyI4F5pKBS41VEExBlCMwJv40c=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=LECmPBu4rw8MzOUJQwYa8lV4SOUoXHgYX3dOcK4GE29SIKhOWFzkxHLdarMn+MbVMWkOUZenx6llf9LKbU0r98nAFrvFzlVxNnZK81hKruIse1ucSTbWGGThYm1yJht6r12keHvzyax8mtrtV1Opz7kBHlFBqv927pcVPHB0+pU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=debian.org; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.210.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=debian.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ot1-f52.google.com with SMTP id 46e09a7af769-7eb34c17b96so7322150a34.2 for ; Tue, 21 Jul 2026 02:27:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784626024; x=1785230824; h=content-transfer-encoding:content-type:cc:to:subject:message-id :date:from:in-reply-to:references:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=RR5FCwNxjoPJGnHWZgDvk/8q8sjW5dLGxnRh7VR12B4=; b=Csf2Wya/W3B6m7tfjdkYLxZ6zGPyDBo6Kna88Gyr4P0Rs2urR+V3P9XR3rVR1GxTwC FWKH82tep+of/wKuoEX5vldVfC5P3IopmbBYJk+lYbPBVRTu96XE4iXhwgzHMlE7qayL jCJd/ZSckMAU9lBhmAqAC+RzUz3aIesVa9ra+8zIytu3m6L6hSg1f/vkV4ra/xk9Efjm E9qlOoJ7UQmlXLAIPsI0K1cgLCu9iNceQ6Gf+vBB2Q/SdAjiQHgylXlOjrVWc6QpxZvN qh1cgKHsNam4jx+1JhnhsGXbsvNS4qx4B59xL1bPBeWYLkTyJH5qFwl7h28j/INGZJNj 6IbA== X-Forwarded-Encrypted: i=1; AHgh+Rp8FA6YPD8qgp6YKqzMGNr5OZWg/B2lCvwk5uIN9Bfnvj5pVEDTxY7Tk7B4fIYfUQLEcK/1IctL41SjmMI=@vger.kernel.org X-Gm-Message-State: AOJu0Yx92TfE7WVCWAIi1iRgRA3KH2Fitmp2AzYBJLTpP0FMdw6d5C0V 47vITLZRMhk4F5sd5P7EI9D3lKWiE7kyBNxbOM9ZZYuCVUNfpnZn7h/4V8zRkB+THA== X-Gm-Gg: AfdE7cnCi8kuzVGM/WWL5E68+VLmqJbo9doQu47WYzmlbzPRlZKP+MuQCSlHr2m3+6O bTrWjyXaVmFru8n1K7LXvmmUgXuLhZSitQPrLt3f/geIlgiCqhJbOs4LTMb9g/G5i6egx6DC/95 x1+fBRjX1DpkJnX/s28Ih0D/xaz1DNL89JkonA95xjtfjLKPU01yikZHiQtZx3J3RLTmS0qvp2F dCI7oFNSXFXXTEIn02MB1JWpf8ZO87JWck19SYPFs6vC2EiO/S+k5LpSDjTckdd2IYdrbTiQ52k SGZXQmjwhWMti/U57X8UhAvVgzedLydEkwgYL1fN8yXlAQdT9VEWvwqLMS1nguWcwzQcgo56nGU dCe/e7uskXphLzIvSop/eUNDO5Wcr2PYq/LahWyM3Z5EtOy0WwNsoOLUd+34vbQDcTdLxvMlmeD u8RsMpiLJKc1vVRd36Cw9PZMMc4k8SBy2sB7c136XaSKgenztLNTOAPZHy2eE9vNIpnI0fbuEU X-Received: by 2002:a05:6820:1806:b0:6a1:50eb:2110 with SMTP id 006d021491bc7-6a536a9faddmr9058461eaf.69.1784626024210; Tue, 21 Jul 2026 02:27:04 -0700 (PDT) Received: from mail-oo1-f48.google.com (mail-oo1-f48.google.com. [209.85.161.48]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-6a51a258618sm10011235eaf.13.2026.07.21.02.27.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jul 2026 02:27:01 -0700 (PDT) Received: by mail-oo1-f48.google.com with SMTP id 006d021491bc7-6a397db52c1so6351985eaf.2 for ; Tue, 21 Jul 2026 02:27:00 -0700 (PDT) X-Forwarded-Encrypted: i=1; AHgh+RrwiQ/uReFzxCA7prU2YaMlRlU2lDKKGVG4vLXJTKvaS8G1Ez7L+OaHoS0Pbx6icpqPWpPTuXKcEf1hOuA=@vger.kernel.org X-Received: by 2002:a05:6820:2d03:b0:69d:f864:d35b with SMTP id 006d021491bc7-6a5366c9239mr9033615eaf.23.1784626020645; Tue, 21 Jul 2026 02:27:00 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260720162117.32304-1-fourdollars@debian.org> <20260720162117.32304-6-fourdollars@debian.org> In-Reply-To: From: "Shih-Yuan Lee (FourDollars)" Date: Tue, 21 Jul 2026 17:26:49 +0800 X-Gmail-Original-Message-ID: X-Gm-Features: AUfX_mzuuwPmHgyXw6Iyg2W8TacSMSalEGr-6q-lNvhwWPNzfRxZgwfUu10AhGs Message-ID: Subject: Re: [PATCH v16 5/7] spi: pxa2xx: disable DMA for Apple MacBook8,1 To: Lukas Wunner Cc: Mark Brown , Andy Shevchenko , Mika Westerberg , Daniel Mack , Haojian Zhuang , Robert Jarzmik , linux-arm-kernel@lists.infradead.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Jul 21, 2026 at 5:18=E2=80=AFPM Lukas Wunner wrot= e: > > On Tue, Jul 21, 2026 at 12:21:14AM +0800, Shih-Yuan Lee wrote: > > On MacBook8,1 (early 2015 12" MacBook), the LPSS SPI controller at > > 00:15.4 suffers from hardware DMA handshake failures and interrupt > > routing bugs, causing keyboard/touchpad transactions to fail when > > DMA is enabled. > [...] > > Link: https://bugzilla.kernel.org/show_bug.cgi?id=3D108331 > > In the bugzilla comments, Leif Liddy writes: > > "I needed to modify drivers/dma/dw/pci.c to assign the DMA controller > irq value to 21 (which is what is listed in the ACPI table) for it > to work. The DMA controller was being assigned an irq value of 20 > for some reason." > > It would seem better to fix up the incorrect interrupt number in a quirk, > rather than disabling DMA wholesale. This is a very good catch! I appreciate the comment. Based on the Bugzilla feedback regarding the incorrect interrupt assignment, it seems fixing the IRQ value via a quirk is indeed a better approach than disabling DMA wholesale. While I am not certain this will resolve the issue entirely, it looks very promising. I will investigate the IRQ mis-assignment problem further. Shih-Yuan