From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D861CC433F5 for ; Mon, 7 Mar 2022 12:19:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241886AbiCGMUc (ORCPT ); Mon, 7 Mar 2022 07:20:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233829AbiCGMU2 (ORCPT ); Mon, 7 Mar 2022 07:20:28 -0500 Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7309C4507D for ; Mon, 7 Mar 2022 04:19:34 -0800 (PST) Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id DC5D63F1C5 for ; Mon, 7 Mar 2022 12:19:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1646655572; bh=+KCTSBW6pFEjmloS4eWdJPVt5+ZQog9npEec5fTl3gE=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=VMsAkBuY+el2OBmh6ZD3EN2cHyK4IWmlJZaackVjbWYr+ssg0QCSLwzq/pglXjljW qPA41VF6kLLc/6MsPYhg5GY0jDbN+XlPouioY2nhwdm8KRpe+ayvHM3XiMl+2XXpEY snGoFroJgx/zyQZwRw6iejUaZExLoxDJyydDnKeD1lLvf7t5yPW5hxhRU3xlClr70/ lmJoSqisg8Pdu7awrDOXkkRhT4HRpEncyHMB3BJVkR/CvHTk69QQni63NHf51dwceQ F+hOuW03Uy5qRjrVzpvR+srSSREh8WlstSO0ExcmPhmjCHulvDlfuMeKZoMRaQViyV 2mhNNmizS+YKQ== Received: by mail-ot1-f70.google.com with SMTP id m12-20020a9d7acc000000b005b21f450ed2so5392385otn.20 for ; Mon, 07 Mar 2022 04:19:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+KCTSBW6pFEjmloS4eWdJPVt5+ZQog9npEec5fTl3gE=; b=7/XOsMFryb/Y8bVoDebcYpOR5j1S2lfTuowUzV4igtwM40FAfb1awl2QeXJrwHBebZ WXWr1lKFkK7JmBhzYadRUv0R2LIxCRnLZPAGZy8QleVtmVagRi16+8wT4ubnB9e+oaCI lv/H1PwPU90xEZrpBKvBXgWKEqdqaKFIH0Kht9bzBuJgHHUEUvzmGVut5lAhlA5sjnSC AkHRycl+Kzm71SW3Qx1El9gIzOaquF6/LyX6Iyg8buzcdHVZXd77ajxRwss8MwHkD7X+ EivnAJKIiyUCP6K+CAYXYNbKdvPwtrNlUmhy40HFaUV5v1u89HuKJN1n35JCNUCrLV1B +U9Q== X-Gm-Message-State: AOAM5324E2SPM7wWnU2t4cXimzyR24o1lhRgvPtYesu/XPNC0ZhcXALC Q0PoeTGMcNEzRLVZyZGpERZb3rSEBbVp+AEnR5QjcuOTutHapzJse/S6IPl8VNlIKfPPmHk02mp dWuy7n0FzL9SnoEmAXKzNe6Qe6dUOABtVkKgohj1E1ZcD+KV22XHmwtXDFw== X-Received: by 2002:a05:6870:14c3:b0:da:3703:329b with SMTP id l3-20020a05687014c300b000da3703329bmr3786484oab.54.1646655571408; Mon, 07 Mar 2022 04:19:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJz0BauCYXUUtV8NW70lSCdhxqJhNg/9xRdwnGXnEFZMiy9VS3n4OvNo9dbPPyEE7RHVfdYiF9oRCjrHiODIwkk= X-Received: by 2002:a05:6870:14c3:b0:da:3703:329b with SMTP id l3-20020a05687014c300b000da3703329bmr3786467oab.54.1646655571116; Mon, 07 Mar 2022 04:19:31 -0800 (PST) MIME-Version: 1.0 References: <20220307115623.37492-1-andriy.shevchenko@linux.intel.com> In-Reply-To: <20220307115623.37492-1-andriy.shevchenko@linux.intel.com> From: Kai-Heng Feng Date: Mon, 7 Mar 2022 20:19:20 +0800 Message-ID: Subject: Re: [PATCH v1 1/1] gpiolib: acpi: Convert ACPI value of debounce to microseconds To: Andy Shevchenko Cc: Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Mika Westerberg , Linus Walleij , Hans de Goede Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 7, 2022 at 7:56 PM Andy Shevchenko wrote: > > It appears that GPIO ACPI library uses ACPI debounce values directly. > However, the GPIO library APIs expect the debounce timeout to be in > microseconds. > > Convert ACPI value of debounce to microseconds. > > While at it, document this detail where it is appropriate. > > BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=215664 > Reported-by: Kai-Heng Feng > Fixes: 8dcb7a15a585 ("gpiolib: acpi: Take into account debounce settings") > Signed-off-by: Andy Shevchenko This works for me. Thanks! Tested-by: Kai-Heng Feng > --- > drivers/gpio/gpiolib-acpi.c | 6 ++++-- > drivers/gpio/gpiolib.c | 10 ++++++++++ > 2 files changed, 14 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpio/gpiolib-acpi.c b/drivers/gpio/gpiolib-acpi.c > index c0f6a25c3279..a5495ad31c9c 100644 > --- a/drivers/gpio/gpiolib-acpi.c > +++ b/drivers/gpio/gpiolib-acpi.c > @@ -307,7 +307,8 @@ static struct gpio_desc *acpi_request_own_gpiod(struct gpio_chip *chip, > if (IS_ERR(desc)) > return desc; > > - ret = gpio_set_debounce_timeout(desc, agpio->debounce_timeout); > + /* ACPI uses hundredths of milliseconds units */ > + ret = gpio_set_debounce_timeout(desc, agpio->debounce_timeout * 10); > if (ret) > dev_warn(chip->parent, > "Failed to set debounce-timeout for pin 0x%04X, err %d\n", > @@ -1035,7 +1036,8 @@ int acpi_dev_gpio_irq_get_by(struct acpi_device *adev, const char *name, int ind > if (ret < 0) > return ret; > > - ret = gpio_set_debounce_timeout(desc, info.debounce); > + /* ACPI uses hundredths of milliseconds units */ > + ret = gpio_set_debounce_timeout(desc, info.debounce * 10); > if (ret) > return ret; > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > index f5e7443208d4..f956c533f218 100644 > --- a/drivers/gpio/gpiolib.c > +++ b/drivers/gpio/gpiolib.c > @@ -2223,6 +2223,16 @@ static int gpio_set_bias(struct gpio_desc *desc) > return gpio_set_config_with_argument_optional(desc, bias, arg); > } > > +/** > + * gpio_set_debounce_timeout() - Set debounce timeout > + * @desc: GPIO descriptor to set the debounce timeout > + * @debounce: Debounce timeout in microseconds > + * > + * The function calls the certain GPIO driver to set debounce timeout > + * in the hardware. > + * > + * Returns 0 on success, or negative error code otherwise. > + */ > int gpio_set_debounce_timeout(struct gpio_desc *desc, unsigned int debounce) > { > return gpio_set_config_with_argument_optional(desc, > -- > 2.34.1 >