From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 310A5C2BA13 for ; Tue, 19 Jan 2021 18:29:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0054723108 for ; Tue, 19 Jan 2021 18:29:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392483AbhASSQh (ORCPT ); Tue, 19 Jan 2021 13:16:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392569AbhASSNV (ORCPT ); Tue, 19 Jan 2021 13:13:21 -0500 Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8914FC061573 for ; Tue, 19 Jan 2021 10:12:23 -0800 (PST) Received: by mail-pl1-x62f.google.com with SMTP id b8so10958999plh.12 for ; Tue, 19 Jan 2021 10:12:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JGbRgtl+Xd7NnNyvzbFz33TQ6zZwYmuEBrx6vdWmM7w=; b=uTCh6cTUQ3XE47LM0eMIuoE/GdPoJeTZ45hU0Bpqt8WbI8TJkaMX+XFhiGPVV/gE5Q bGnBAI2ROPIZ58VKuh+c0xvYKjQZ53sB8OzLoqhag/9inhgyOo0NVB8vOzweiYB9p+4J W6whNIGREJDN6AcX03G09m3vXbE4JK0edcSCWXD+rco9zWJpolWlNg/ZoTYn+xilq2as gho4LGra0Z2+J1Fv8GUM4bJ/gRDZGbCQxWiT9cwkzRI5QnINnDh+XoEWFNlp6e5nbviU NcgqVh5ivwErJGv8xs8ekw0bcKBacl0iaZ70qTcw9IEfT+h8a18Flix0rL4ZslVyX/p4 ef6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JGbRgtl+Xd7NnNyvzbFz33TQ6zZwYmuEBrx6vdWmM7w=; b=K3I5HnJ+UgTnBcMOoXhQi4j0EXG472vz3uQ7yxj520fSsNM7OM2Bves5pmm7dJyeR7 aaOk91PK2d0UC518tYZ01C0oQvCbfdrbQWeUkNENerVkZ/BuSoNzwFJxwJl+c0+KY7NY UUqL8X1s1LkdEX15SONz4LUdg9eEcEjUs5IYsbhcJW/m+ekbJ1Mc+pz38/+UJLkfAmPa 8bVRFV7oJ8hD4bdmTTW+WwTOs1rQwEXvNfz14kZwF1I0aWG3pY59IdDn+W31dqZI++Ou mNahX3tIFzywizGTRs28DZaw5LOLa8DmkZ4NEdqTsYm1yga7yKeAF68x7kWSufYQ6xVI mrmw== X-Gm-Message-State: AOAM533WYoWI+ToVeYX5SIXCsW0NlD/jErVmR8MKDVzoGNFXexfD132T SPUFSDS4I/lk7PxY2fbCLpj3i+6KbZyV8DFpCERGHA== X-Google-Smtp-Source: ABdhPJzBasDVEG6vdysTxWNctZueWMzAYRygGHyEkpY748jJPjW7ukdkNgObxdsRFxvPhYSz1R4jbuYeShW3H3ks1V0= X-Received: by 2002:a17:903:31d1:b029:de:8361:739b with SMTP id v17-20020a17090331d1b02900de8361739bmr6013728ple.85.1611079942969; Tue, 19 Jan 2021 10:12:22 -0800 (PST) MIME-Version: 1.0 References: <20210118183033.41764-1-vincenzo.frascino@arm.com> <20210118183033.41764-4-vincenzo.frascino@arm.com> <20210119130440.GC17369@gaia> <813f907f-0de8-6b96-c67a-af9aecf31a70@arm.com> <20210119144625.GB2338@C02TD0UTHF1T.local> In-Reply-To: <20210119144625.GB2338@C02TD0UTHF1T.local> From: Andrey Konovalov Date: Tue, 19 Jan 2021 19:12:11 +0100 Message-ID: Subject: Re: [PATCH v4 3/5] kasan: Add report for async mode To: Mark Rutland , Vincenzo Frascino Cc: Catalin Marinas , Branislav Rankov , Marco Elver , Evgenii Stepanov , LKML , kasan-dev , Alexander Potapenko , Linux ARM , Andrey Ryabinin , Will Deacon , Dmitry Vyukov Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 19, 2021 at 3:46 PM Mark Rutland wrote: > > Given there's no information available, I think it's simpler and > preferable to handle the logging separately, as is done for > kasan_report_invalid_free(). For example, we could do something roughly > like: > > void kasan_report_async(void) > { > unsigned long flags; > > start_report(&flags); > pr_err("BUG: KASAN: Tag mismatch detected asynchronously\n"); "BUG: KASAN: invalid-access" It also might make sense to pass the ip, even though it's not exactly related to the access: pr_err("BUG: KASAN: invalid-access in %pS\n", (void *)ip); Up to you. > pr_err("KASAN: no fault information available\n"); pr_err("Asynchronous mode enabled: no access details available\n"); > dump_stack(); > end_report(&flags); > } This approach with a dedicated function is better. Thanks, Mark! Please put it next to kasan_report_invalid_free().