From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752510AbcFCMpR (ORCPT ); Fri, 3 Jun 2016 08:45:17 -0400 Received: from mail-vk0-f66.google.com ([209.85.213.66]:33741 "EHLO mail-vk0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751866AbcFCMpP (ORCPT ); Fri, 3 Jun 2016 08:45:15 -0400 MIME-Version: 1.0 In-Reply-To: References: <1464230275-25791-1-git-send-email-iamjoonsoo.kim@lge.com> From: Joonsoo Kim Date: Fri, 3 Jun 2016 21:45:13 +0900 Message-ID: Subject: Re: [PATCH v2 1/7] mm/compaction: split freepages without holding the zone lock To: Vlastimil Babka Cc: Andrew Morton , Mel Gorman , Minchan Kim , Alexander Potapenko , Hugh Dickins , Michal Hocko , LKML , Linux Memory Management List , Joonsoo Kim Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-06-03 19:10 GMT+09:00 Vlastimil Babka : > On 05/26/2016 04:37 AM, js1304@gmail.com wrote: >> >> From: Joonsoo Kim >> >> We don't need to split freepages with holding the zone lock. It will cause >> more contention on zone lock so not desirable. >> >> Signed-off-by: Joonsoo Kim > > > So it wasn't possible to at least move this code from compaction.c to > page_alloc.c? Or better, reuse prep_new_page() with some forged > gfp/alloc_flags? As we discussed in v1... Sorry for not mentioning that I did it as a separate patch, Please see below link which is the last one within this patchset. Link: http://lkml.kernel.org/r/1464230275-25791-7-git-send-email-iamjoonsoo.kim@lge.com Thanks.