From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932964AbbFWSX7 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 23 Jun 2015 14:23:59 -0400
Received: from mail-wi0-f170.google.com ([209.85.212.170]:35902 "EHLO
	mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754265AbbFWSXw convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 23 Jun 2015 14:23:52 -0400
MIME-Version: 1.0
In-Reply-To: <20150623180513.GE20178@xsjsorenbubuntu>
References: <1435082402-29239-1-git-send-email-moritz.fischer@ettus.com>
	<1435082402-29239-2-git-send-email-moritz.fischer@ettus.com>
	<20150623180513.GE20178@xsjsorenbubuntu>
Date: Tue, 23 Jun 2015 11:23:51 -0700
Message-ID: <CAAtXAHd9zcrUGpYcPFaMDF-eDMN+-t4tuB7KmH7A2B1AzW+psg@mail.gmail.com>
Subject: Re: [PATCHv5 1/2] dts: Adding docs for Xilinx LogiCORE IP mailbox driver.
From: Moritz Fischer <moritz.fischer@ettus.com>
To: =?UTF-8?Q?S=C3=B6ren_Brinkmann?= <soren.brinkmann@xilinx.com>
Cc: Jassi Brar <jassisinghbrar@gmail.com>, linux-kernel@vger.kernel.org,
        robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
        ijc+devicetree@hellion.org.uk, Kumar Gala <galak@codeaurora.org>,
        Michal Simek <michal.simek@xilinx.com>, akpm@linux-foundation.org,
        Greg KH <gregkh@linuxfoundation.org>, mchehab@osg.samsung.com,
        Arnd Bergmann <arnd@arndb.de>, joe@perches.com,
        Jingoo Han <jingoohan1@gmail.com>, devicetree@vger.kernel.org,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 23, 2015 at 11:05 AM, Sören Brinkmann
<soren.brinkmann@xilinx.com> wrote:
> On Tue, 2015-06-23 at 11:00AM -0700, Moritz Fischer wrote:
>> Changes from v4:
>> - Changed mbox cells property from 1 to 0
>> - Fixed interrupt property
>>
>> Changes from v3:
>> - Changed reg size to 0x100
>>
>> Changes from v2:
>> - Addressed Michal's stylistic comments
>> - Fixed typo in compatible string
>>
>> Changes from v1:
>> - Added common clock framework support
>>
>> Changes from v0:
>> - Fixed example bindings
>>
>> Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
>> Acked-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>  .../devicetree/bindings/mailbox/xilinx-mailbox.txt | 44 ++++++++++++++++++++++
>>  1 file changed, 44 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/mailbox/xilinx-mailbox.txt
>>
>> diff --git a/Documentation/devicetree/bindings/mailbox/xilinx-mailbox.txt b/Documentation/devicetree/bindings/mailbox/xilinx-mailbox.txt
>> new file mode 100644
>> index 0000000..269c026
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/mailbox/xilinx-mailbox.txt
>> @@ -0,0 +1,44 @@
>> +Xilinx Mailbox Driver
>> +=====================
>> +
>> +Required properties:
>> +- compatible       : "xlnx,mailbox-2.1".
>> +- reg              :  physical base address of the mailbox and length of
>> +                      memory mapped region.
>> +- #mbox-cells      :  common mailbox binding property to identify the number
>> +                      of cells required for the mailbox specifier, should be 1
>
> I guess this should say "should be 0" now?

D'Oh, yeah ...

Moritz