From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754676AbcC1H5J (ORCPT ); Mon, 28 Mar 2016 03:57:09 -0400 Received: from mail-lf0-f68.google.com ([209.85.215.68]:35073 "EHLO mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753416AbcC1H45 (ORCPT ); Mon, 28 Mar 2016 03:56:57 -0400 MIME-Version: 1.0 In-Reply-To: <20160325095015.341a11eb@bbrezillon> References: <1457923684-13505-1-git-send-email-peterpandong@micron.com> <20160325095015.341a11eb@bbrezillon> Date: Mon, 28 Mar 2016 15:56:56 +0800 Message-ID: Subject: Re: [PATCH 00/11] mtd: nand_bbt: introduce independent nand BBT From: Peter Pan To: Boris Brezillon Cc: Brian Norris , David Woodhouse , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, karlzhang@micron.com, beanhuo@micron.com, xuejiancheng@huawei.com, Peter Pan Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 25, 2016 at 4:50 PM, Boris Brezillon wrote: > On Mon, 14 Mar 2016 02:47:53 +0000 > Peter Pan wrote: > >> Sorry for send the v3 out late. I went through a busy time in the past >> two month. >> >> Currently nand_bbt.c is tied with struct nand_chip, and it makes other >> NAND family chips hard to use nand_bbt.c. Maybe it's the reason why >> onenand has own bbt(onenand_bbt.c). >> >> Separate struct nand_chip from BBT code can make current BBT shareable. >> We create struct nand_bbt to take place of nand_chip in nand_bbt.c. >> Struct nand_bbt contains all the information BBT needed from outside and >> it should be embedded into NAND family chip struct (such as struct nand_chip). >> >> Below is mtd folder structure we want: >> drivers/mtd/nand/ >> drivers/mtd/nand/raw/ >> drivers/mtd/nand/spi/ >> drivers/mtd/nand/onenand/ >> drivers/mtd/nand/chips/ > > Hm, we should have a chips directory under each interface type, because > vendor specific handling is dependent on the NAND interface. > Otherwise, yes, that's the idea. Update this in v4 Thanks, Peter Pan