From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC9253AC0F9 for ; Wed, 22 Apr 2026 08:15:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=209.85.216.53 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776845733; cv=pass; b=CJ+Lbf6ZxgmstO1e3nwmdzuD3gwZWfJcB3pr6g0Thpzf0Ai7G+cxcebHEh/O9T8FzaK6uWsevZLxPljzLCTaCYZV8oSNxVjy4I6N7SLk247QIZ7GtFcuDtZGkZF3yMEiQ3SYGsP52A0x8YlnXOt+Cw/VMgB7vxvkgqCO2ZN5QRk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776845733; c=relaxed/simple; bh=DncC7/rJMefHvs6jsOamy6nnhVmB7rwaLiNnQJd6iYk=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=tJWUIEhWtlPnV/5dJPV6U245HooeOV9FL6xbI98YZnMLpXOq/fSvFvRo8g5qKXueiZsIAfW6JPQ5Tt4P3AKO6wlARLiqptTCf5zNIEtBOECBfCnbBuu2LkqakMRrrP6OZQA011m7fn07zk4Lm0aglv12oBqfZB9Q6SzLqZdZFhY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=kyko7ikH; arc=pass smtp.client-ip=209.85.216.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="kyko7ikH" Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-3614826eca4so4704602a91.1 for ; Wed, 22 Apr 2026 01:15:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1776845729; cv=none; d=google.com; s=arc-20240605; b=EYFkg7K2rsgXIUhQzNqVzYlrrr2h02yIwOmTjEUx8WaQZwctwIDOgefiZKR4RYCcN8 ycYJACZbODT8JI8k83YGQskpDHbo1PRWZAPEbEiSDUccfXI+aZuyvoe0kQNH3eDMTOJ9 2EnS9T6y6Al/H23XlLezXhbpbA0rj8QkqjcIAQzQl4yWowVXX5b5vWOofzYV2cWCOXVj NzmzkmqsgXABIy3Y9gwbhHMlC987BfAk4kEY3E/kdokRfjtuR78uIPTqL2Wltj76TBcX 1GzF3ENFpH1bqlj3ZD99cyuplJbLSbxGwQVzbgOUXzYNnxZWB7lNkKn9PYe0ufzYsdeH 60jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=d9Svqf7nagVQGDYJm+292ujdtORxRBGZ1VO5yq6bktQ=; fh=PUbk3xvVdCaeB72Pm6KIIBEpCganRBnnnNC4N4bQ5s8=; b=N17qTPSUT57Bn9vv/IMEb5o68D02Daxq7jEtfJrm8U+ZnkWgvPKiNCgrQFGK7zFcu8 lN+EfL2D5nFtOq0ZRh3WUMFTjiy+Er8irUVVRusREUPFX97lWbGrvO818pw3dLpWhYTw fndBFrkafHr5edPVeDJ0B4zJEaUFcdL3UfcIV1LuzBKugRQzcKuFFEIwPvjt0k7PlQwv FH9Jy4op7bT78gp1vgaFwEaOlz+ugCkPHBmk36aF9o690UknY6NyK/klTaJvRYG8BzrW cCqL0iDVUKRehQnYzmcQ+WfT8KmmG2oB5FdqD9F2iZ+V1WuYj/+JY7wVF2dc6Uokvc2N YtdQ==; darn=vger.kernel.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1776845729; x=1777450529; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=d9Svqf7nagVQGDYJm+292ujdtORxRBGZ1VO5yq6bktQ=; b=kyko7ikHlZDTQDrxAvGPJLLhO6k0wsuuk5cBi+hbGY5LGu3kbYySWVO+v8MonTnX1c xbgLkBd1iIwgQgdY0vPoq9yeRKnvOlVuttblzdO7E9wx1iCBZ+jubQJS6nHHn+cbsstP 3NLstWsbJiycQsRTlw1/vPcaqMYSuO/vLyGa662F92QTFO7lAeS7xGkL6bLzUMHSrJp8 tv/Jlw9tLB+A7s3Jo1CrzyEF1haJKWpLRQUJcMNatrtF7H9/3k0lc3MIArb5e17Rdb0S 6pjqxZe9z1fcvuP6YmjZb6woSifLEAqSfEw3tD9oZAJQbRnYlnh/fX5/BkbQwHqIOZHB vw6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776845729; x=1777450529; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=d9Svqf7nagVQGDYJm+292ujdtORxRBGZ1VO5yq6bktQ=; b=fKHYHWXbN50Yyg/FJUzUV3pk/o38ZCP4khsyjVJjDlimFV6mSJHsdMTO051wSttkKE UlO6NLpqiBchrvs1GbbcPFJhJPaTHYn5CMYyuZVM/y84vQawzzkvgFJWM4AUeyJl2o5s gI3Y4hDanGwD9Sw3gMnsbHEhdB5zj2hsH4sAvvkO/KWDcaDwXVN2j0QLuylb2AZyle7B QwwhbPC6VhRbmbTOmbt7NwedRZd8DRJK0sURM4mBqVpR65/8cpNi7rntifyqLnMYVimY LDT9Y6542D4s67FXmruqV7TJLK+0+tk5KgMrcrjtFnlImRAq4a5G6505kixO+XBEbO2m O38A== X-Forwarded-Encrypted: i=1; AFNElJ/DUWpdEyaw5/IFZVbEcJ5PmLCf40qw1d0IyhF768dKi/Bel4gHhT9/5Kh/v8IObbjm/Vq2auFDRQ0DxvM=@vger.kernel.org X-Gm-Message-State: AOJu0YzMLaGJWGo7IGvOcO+8NJ+6D/CW8z7LdTaIECceIlr0iNSxUbHk S4lSC1pldyUcW2JMLlHCMYzgGoG8ojuls/6KHcywqqGxoX0Z2+S1bhdEzXh6ii49oa13EIMUCKH h0Vf9/AQmYHeosFEREJCxskY7Wfhjyjg= X-Gm-Gg: AeBDieuS1RbyGGZVe6Yp1ORI8Ovv1XJ4UaqjJS6Axxb3txhqxz25u0EM9ifBJAtL0Cm myG6B1zT6Snubgjh6lMU9grJZeVgTPgXFsYnEFz+H3uazmZWAPbs5dQxL7p1Mcb6PpPBHm6GFdK 4JEEdm6LTpg1BUyep626zEi7SFjJmSz3oWmDr7ruOltPd0RWQLQm5gBCnNSaW94/4pgF9GJH/s+ ZTqmmEodghdD/tqVr17EBp74oMuMpML48MldBj6SbtthsnTLinktjtKlggowEKyDUmEDdwxq1Az sWmxbJ3lWN+17imaDg== X-Received: by 2002:a17:90b:2fc4:b0:35f:b6d3:da7d with SMTP id 98e67ed59e1d1-361404635e6mr20506309a91.17.1776845729036; Wed, 22 Apr 2026 01:15:29 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20260422070203.698716-1-linchengming884@gmail.com> <20260422070203.698716-3-linchengming884@gmail.com> <87a4uv5set.fsf@bootlin.com> In-Reply-To: <87a4uv5set.fsf@bootlin.com> From: Cheng Ming Lin Date: Wed, 22 Apr 2026 16:14:26 +0800 X-Gm-Features: AQROBzCXDwT8wfI3IxhKZWv7FK4oUhFYcEJUA7pBhDvdYOh76PDtet4MkYQV5Ps Message-ID: Subject: Re: [PATCH v9 2/3] mtd: spi-nand: Add support for randomizer To: Miquel Raynal Cc: richard@nod.at, vigneshr@ti.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alvinzhou@mxic.com.tw, Cheng Ming Lin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Miquel, Miquel Raynal =E6=96=BC 2026=E5=B9=B44=E6=9C=88= 22=E6=97=A5=E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=884:08=E5=AF=AB=E9=81=93=EF= =BC=9A > > Hi Cheng Ming, > > > +static int spinand_randomizer_init(struct spinand_device *spinand) > > +{ > > + struct device_node *np =3D spinand->spimem->spi->dev.of_node; > > + u32 rand_val; > > + int ret; > > + > > + if (!spinand->set_randomizer) > > + return 0; > > + > > + ret =3D of_property_read_u32(np, "nand-randomizer", &rand_val); > > + if (ret) > > + return 0; > > + > > + return spinand->set_randomizer(spinand, rand_val =3D=3D 1); > > You do not need the "=3D=3D 1" part. rand_val is cast into a boolean, so = any > non zero value will be taken understood as an "enable" and zero will be > treated as "disable", which is fine. Got it, thanks for the tip. I will drop the "=3D=3D 1" part and rely on the implicit boolean cast in the next version. Since the rest of the patch looks fine to you, I will wait for the Device Tree maintainers' feedback on the dt-binding patch (Patch 1/3) before spinning v10 to avoid spamming the list. > > The rest looks fine. > > Thanks, > Miqu=C3=A8l Thanks, Cheng Ming Lin