From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1E363806B2 for ; Mon, 12 Jan 2026 18:09:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768241359; cv=none; b=rfzuDcmTuu5SLKfvvByha+JjxpT68Z+s9olXAY6563lk/uAzLRgg5arAn33VngokXbbvJKz4/JkLXJdqrEu2G5wyLcsBpPMaMSZpZw1hMdDoNmZe86j8CSDmF6sCfKFEJl4/epeOFEtq3y66y/A3KBtHKfsoWOo3Hldi1K1ffN8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768241359; c=relaxed/simple; bh=zVgDjt6fjdf4BBH0+K2VyUEBTjG8SYQlzr7dYZjePmI=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=KamGT4nwuUb7VrZHAfxNt03HAdwOGY77fz6Hhw1cOHpBtOsJg7G4MU2K+GtmxaeyL8H3H7iQmVg5LsEAGExPJ8jXqwtxb/nllPqrFx4z+nwBq39f3sQfejmgl+6f0+xj8WeZDSeS9ILThAuGHAuJXhpD1cb/sIOd0kz+JJZaiVE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=FaKyZzo7; arc=none smtp.client-ip=209.85.218.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="FaKyZzo7" Received: by mail-ej1-f43.google.com with SMTP id a640c23a62f3a-b87108066c3so213856666b.2 for ; Mon, 12 Jan 2026 10:09:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1768241356; x=1768846156; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Gh7LLYNrjRjP3D+25YLQ7uFtmarzJZFabcCNONp6hIA=; b=FaKyZzo7HR03WvprOPAorkV8hDjOlMZBE2uACu5kJkbo/UJ51ZjosYDZlrQeTwLZbh 7d8f/3A+eK/C5JAsV1e+oGdJ4XJqM88CdG0I50By1YLCYpw0y2SqZhaSRRCUZMvq7mZz TTrKJDDcjJ/KaSxqNk7b9JusbKjn8nnFr2EhNq0DF8dS/7mj3QVxnMas7JDF4WRMYbre /OHuN55vZFmMh1IIT/R6ZFfOaou/TiYWOKUFcMTlTyBess83gZrvDM/YRd9A06YMeYIp C2MrR6y/oBdXdOUbtbRYn8a0rG3mwL0dEqLVTpsjmB2k824/fBzLz4ipdFinXHQpDhFa 2s4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768241356; x=1768846156; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Gh7LLYNrjRjP3D+25YLQ7uFtmarzJZFabcCNONp6hIA=; b=FT+Dg27aHifXVldvR6CRpGbBgue4R03nLg1YXKffBBlCiWbdgFFdmy7KRF6jmGG3cY hGHmhhSmsptdrZSuT4Ko6YWMvN+FljhafiFpDu4C3hrXxv1OyFvtvkU22muoX0lDXbZa USfc0VfhJk/jewDsbfld/PPxRcPyzG2869YgeHOL+bHxJaDGra05uAbBRnUCxqtELqOj sOTXys1yYvcXOgZIvzCt92ovc+I/jOSVMAPZ8296lR0VnDP+Fzu3HVgt/GquncGy8QMg Qt8Hl4MY92LBdROOBNFCeHrNJcIztxLUBRI82kwXBteY1tlxVnGbl3M2eI85Q5gw6xcV NDjw== X-Forwarded-Encrypted: i=1; AJvYcCVou/QkOLhx/vDEcLr1UR15HLKf0yuBmlOPDPHSWh8c0zFTLkPuYK8PPD/iAdGvHwkcQGaStXI7dyGAW78=@vger.kernel.org X-Gm-Message-State: AOJu0YxMe+/c+q5yEBPSaILWE6+RulNo1HmTDUDpMnUB2S3zc9+vV2eZ p0uCM+y6iFhcJvyCzrjEYNzot+3FJM/SfZlD89NM04+VfMWeFoyAd78mYykhoNhsuRxw4G47Pe6 cruKZRIAO4q7P5/3oJ2ZK5NiN/MN0kFgN26rrb0l1oQ== X-Gm-Gg: AY/fxX7h9MMGp0YCoeVWvRv8LD0c6FWAqbNaFbRYb9R35+hjvDZ2t93I0QK6B+JeHkJ J5dxUCTSzPEIy09AL7X0iQUTG5R5gSJnkf83hubjtYhFDjqTlkp+Gi9pThRxHa+rK2AUIylEqG4 5h98AzNE2P9lxVOHpglrFHLCeOCdNKyYl669gOE/r8i/2u6SUrL56dITnS9EXi20TVVjSVovnY1 2QBtiz5hMYAWixqt50HQqnJDrdJPndJup1YzkWQ72bacv2fPCWQg0x1dQHXW/0FXElYb+JLrVI5 Es8i6w== X-Google-Smtp-Source: AGHT+IEYm6JmZ6oxVEG3sghkMbFby4352xUDa/QghGdKg6QzWrgPW5eiKR07M1PCnZmMpNOPMHgZmF9fd+u0Fl3r/lQ= X-Received: by 2002:a17:907:9723:b0:b87:fc5:40ba with SMTP id a640c23a62f3a-b870fc61ea2mr481798866b.20.1768241356080; Mon, 12 Jan 2026 10:09:16 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: In-Reply-To: From: Seamus Connor Date: Mon, 12 Jan 2026 10:09:04 -0800 X-Gm-Features: AZwV_QiXATLjlde29NI6GjNCFmTeW-I4i6Tsfut-UMedDBzTGyIMyurHYb9RAvI Message-ID: Subject: Re: [PATCH] ublk: fix ublksrv pid handling for pid namespaces To: Ming Lei Cc: Jens Axboe , linux-block@vger.kernel.org, Caleb Sander , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" > Can we fix it in the following way? > > + struct pid *pid = find_vpid(ublksrv_pid); > + > + if (!pid || pid_nr(pid) != ub->ublksrv_tgid) > + return -EINVAL; Sure that makes sense. Let me try that out. > Also your patch has patch style issue, please check it before posting out > by `./scripts/checkpatch.pl`. Or you may have to use `git send-email` to > send patch file. Sorry about that.