From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757910Ab2IMMUN (ORCPT ); Thu, 13 Sep 2012 08:20:13 -0400 Received: from mail-lpp01m010-f46.google.com ([209.85.215.46]:42010 "EHLO mail-lpp01m010-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755004Ab2IMMUL (ORCPT ); Thu, 13 Sep 2012 08:20:11 -0400 MIME-Version: 1.0 In-Reply-To: <1347538571.15764.133.camel@twins> References: <1347459195-5491-1-git-send-email-eranian@google.com> <1347459195-5491-3-git-send-email-eranian@google.com> <1347459764.15764.32.camel@twins> <1347538571.15764.133.camel@twins> Date: Thu, 13 Sep 2012 14:20:09 +0200 Message-ID: Subject: Re: [PATCH v2 2/3] perf: use hrtimer for event multiplexing From: Stephane Eranian To: Peter Zijlstra Cc: LKML , "mingo@elte.hu" , "ak@linux.intel.com" , "Yan, Zheng" , Robert Richter Content-Type: text/plain; charset=UTF-8 X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 13, 2012 at 2:16 PM, Peter Zijlstra wrote: > On Wed, 2012-09-12 at 17:37 +0200, Stephane Eranian wrote: > >> Note however that the rotation_list is still used in perf_event_task_tick() >> to iterate over the ctx which needs unthrottling. We would have to switch >> that loop over to a for-each-pmu() which would necessary incur more >> iterations as it would include all the SW PMUs. > > Oh urgh, right. I think that was one of the reasons I bailed on the > hrtimer thing, the frequency and throttle stuff. > > ctx->nr_freq and needs_unthr could help, but yeah. I think for now, we could keep rotation list for the unthrottling. Multiplexing won't use rotation_list anymore.