From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34DA8C433EF for ; Fri, 10 Sep 2021 22:21:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 191AA611CC for ; Fri, 10 Sep 2021 22:21:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234758AbhIJWWo (ORCPT ); Fri, 10 Sep 2021 18:22:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233602AbhIJWWl (ORCPT ); Fri, 10 Sep 2021 18:22:41 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6733DC061574 for ; Fri, 10 Sep 2021 15:21:29 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id t18so4702742wrb.0 for ; Fri, 10 Sep 2021 15:21:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=O957Ri/0BgbMSrPbxQY/9ULVJYFNDqjXyqmF7WgsPVo=; b=LhvJ5TKap96EqV9/pPcDlP3U58e7yk7wFss4ufzPsVIj5y2XJbPcKaAlOvABrLGrKd CmDE5YasEk5QfA+RKiPigj25VuDR6UuHnzRiCaYoq+K0CAG8NYbyGBvY8ej0MZc8VM7X IxjGId1hnLBYpgGrJP2zj7WaRkX53sDTuAv8EZablEdPkv7j/ZX2sQbAhjfrrTuIKkMp otLhkNMkkgX8sTYHW3wEYAlI2gN62tAFfyVtrmgD1uoCzfIzo0Qx2YR61X0F79pJztA5 9gKzxU93MSzBFOTyjkUAUPWifDmGlbnN2B2trk8LX+nkdqmcv1PHt2Y1Ihu9OOAtu9C1 xZzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=O957Ri/0BgbMSrPbxQY/9ULVJYFNDqjXyqmF7WgsPVo=; b=v/p+UWTxwopRiZy48kDTzbXIsmW5vQ0lr+2PaZbL4nFGY2/p+fFSUwHIkevs7f9+Uw FmmL4fQhwbRQFQZbBZEAfYQz/MApXdzs1eGQS4s3JBXOSUFVgBqfrZu4KmcMTsttbPeO tgpCaFNUGtdgRmkPP3jkFBdZHJxwyy38f/0jqk8UdVW9GmVej15hX8DnRER+hMu59mUk oLhsMeB+dJQJt6+18j8Xlb7T696gi/K43Bte+Ew3gaEt5NUujZ69K7ykuXIPcjAfxl9v 6Ywjh/UgYe69sw2ZDUJJwbnp34X2ag8G3I1uHu1IsBTbwIfnHuXyAAzXPH0cCg+sA1Wo Zf2A== X-Gm-Message-State: AOAM5331r58nDs06opiCJ7qsVDUppGdg55d7PDnyuWX+rrq83606MUHV u5xEc4PvU6yN18CP1KTImdT0aKkxBvxrb1b6tqWigg== X-Google-Smtp-Source: ABdhPJwPCI1BFrQljr8CVIaPm/HOKh9tjiswuqnbA3ltFmsMfJOsLlLTxXucgARNDednGBrthMujWF+g5kzitLnlR20= X-Received: by 2002:a05:6000:124b:: with SMTP id j11mr2646wrx.147.1631312487842; Fri, 10 Sep 2021 15:21:27 -0700 (PDT) MIME-Version: 1.0 References: <6A72EAE4-A0F7-4CD2-89BB-36A8F4A7D321@internode.on.net> In-Reply-To: <6A72EAE4-A0F7-4CD2-89BB-36A8F4A7D321@internode.on.net> From: David Gow Date: Sat, 11 Sep 2021 06:21:16 +0800 Message-ID: Subject: Re: After KUnit update for Linux 5.15-rc1 - unable to share VFAT filesystem via samba To: Arthur Marsh Cc: Shuah Khan , Linux Kernel Mailing List , Brendan Higgins , "open list:KERNEL SELFTEST FRAMEWORK" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Sep 10, 2021 at 8:02 PM Arthur Marsh wrote: > > > Hi, I have been sharing an old VFAT formatted hard disk on one pc to > another using Samba and sometime after kernel 5.14.0 it stopped working (apparently no longer being shared as the mount.smbfs command > on the client failed with error -13 yet mount.smbfs still worked for > ext3 filesytems shared from the same machine which had the VFAT > filesystem). > The only error I saw on the machine with the VFAT formatted hard disk > was the output of the mount command had truncated the name of the > mount to only include the first 4 characters of the base name of the > mount point. > e.g. when VFAT filesystem was mounted on /mnt/victoria, the output of > the mount command showed the filesytem mounted on /mnt/vict > I can't reproduce this on my machine (which is openSUSE Tumbleweed with their "vanilla" 5.14 kernel package on x86_64, mounting a FAT16 filesystem). # mount /dev/sda1 /mnt/victoria # mount | grep vic /dev/sda1 on /mnt/victoria type vfat (rw,relatime,fmask=0022,dmask=0022,codepage=437,iocharset=iso8859-1,shortname=mixed,errors=remount-ro) # uname -a Linux patpat 5.14.0-1-vanilla #1 SMP Mon Aug 30 07:01:36 UTC 2021 (dc06e24) x86_64 x86_64 x86_64 GNU/Linux I can try it again on an older i386 machine, but I doubt that'd change things: this doesn't smell architecture-specific to me. This seems a lot more like it's something to do with /proc/mounts or similar, rather than a FAT specific issue (and, unless something really strange has happened with the CONFIG_FAT_DEFAULT_CODEPAGE config option, which I doubt), this change shouldn't affect anything at all when KUnit isn't enabled and used. I suspect it just shows up in the bisect because it's basically the only change in fs/fat for a while. The bisect against the whole kernel tree seems likely to be of more use. -- David